How to modify this script to recurse subdirectories?

spiceuser-nenes · 2021-06-16T17:18:11.000Z

My Windows 10 Music folder has some albums where there are both MP3 and Flac versions of the songs. There are other albums that only contain MP3’s and still others that contain only Flac’s. In the album folders that both types, I want to delete the MP3’s since they are unnecessary lower quality duplicate versions. I found a script here that was doing something similar but with photos (bmps and jpegs) but it only looked in the photos folder. I have modified it to handle MP3’s and Flac’s, but I can’t figure out how to add recurse to get it to look into each album folder under the Music folder. Can someone help with this?

Here is the script I am trying to add recurse to:

$Path = “f:\music”
ForEach ($File in (Get-ChildItem $Path *.mp3))
{ If (-not (Test-Path “$Path$($File.Basename).flac”))
{ $File | Remove-Item -WhatIf
}
}

Neally · 2021-06-16T17:19:52.000Z

Welcome

If you post code, please use the ‘Insert Code’ button. Please and thank you!

PLEASE READ BEFORE POSTING! Read if you're new to the PowerShell forum! Programming & Development

Hi, and welcome to the PowerShell forum! Don’t apologize for being a “noob” or “newbie” or “n00b.” There’s just no need – nobody will think you’re stupid, and the forums are all about asking questions. Just ask! Use a descriptive subject. Don’t say “Need help” or “PowerShell Help”, actually summarize what the problem is. It helps the rest of us keep track of which problem is which. Don’t post massive scripts. We’re all volunteers and we don’t have time to read all that, nor will we copy…

Neally · 2021-06-16T17:20:46.000Z

you want to add the ‘recurse’ parameter.
e.g.

$Path = "f:\music"
ForEach ($File in (Get-ChildItem $Path *.mp3 -recurse)) {
    If (-not (Test-Path "$Path\$($File.Basename).flac")) {
        $File | Remove-Item -WhatIf
    }
}

DoctorDNS · 2021-06-16T17:53:45.000Z

You could…

#replace this
ForEach ($File in (Get-ChildItem $Path \*.mp3))
# with this
ForEach ($File in (Get-ChildItem $Path \*.mp3 -Recurse))

spiceuser-nenes · 2021-06-19T12:49:21.000Z

Can someone help me with a flaw in my logic. I am trying to delete mp3 files in my Windows 10 Music folder if (and only if) there exists a flac version of the song. For example:

Music
Artist1
Album A
SongA1.Flac
SongA1.MP3 <-Delete only this song
Artist2
Album B
SongB1.Flac
Album C
SongC1.MP3

What needs to change in the following Powershell script to work the way I desire? Currently, it is removing both of the MP3’s in the above example.

$Path = "f:\music"
ForEach ($File in (Get-ChildItem $Path *.mp3 -recurse)) {
    If (-not (Test-Path "$Path\$($File.Basename).flac")) {
        $File | Remove-Item
    }
}

gary-m-g · 2021-06-19T23:38:55.000Z

Logically, for each file in every directory, you have to see if there’s a file.mp3 AND a file.flac
If yes, delete the mp3

So, I would do:

$dirs = gci -path $rootDir -recurse -directory -force | select -exp Fullname

Then,

foreach ($dir in $dirs) {
cd dir
$files = gci . -file -force | select -exp name
if ($files) {
foreach ($file in $files) {

… here you strip the extension and check for both

left for you to finish…

}
}
}