Issue with do/until loop in Powershell

daphrack · 2019-06-18T07:50:07.000Z

Hello!
So, I’m a beginner in Powershell and this may seem like an idiotic question but, I’m writing my first script and encountered an issue with the do/until loop.

Here’s the script:

Clear-Host

$HowMenu = Read-Host -Prompt "================ Welcome ================

List of processes on the system
List of services on the system
Send a ping
Double a number
Q. Quit"

$option = Read-Host “Please select an option”

switch ($ShowMenu){
1{Get-Process}
2{Get-Service}
3{
$Connection = Read-Host “Please write an IP adress or a domain name”}
4{
$num1 = Read-Host “Please write a number”
Write-Host “Please wait …”
sleep -Seconds 1
Write-Host “Your chosen number was $num1 and now it’s $([int]$num1 + [int]$num1)”}
Q{return}
}
do
{
$Options = Read-Host “Please select an option”

pause
}
until ($input -eq ‘Q’)q

The issue lies that the loop focuses on question when initially asked and doesn’t break from it, even when writing “Q”. What am I doing wrong?

All help is appreciated!

jonsellors · 2019-06-18T08:21:28.000Z

Hi,

The first line that starts $HowMenu = Read-Host -Prompt "… doesn’t need to be a variable taken from a prompt.

(also, I think you meant $ShowMenu to be the variable name)

So change that to whole line to Write-Host "…

And the line that starts switch ($ShowMenu){ should have been switch ($option){

Also, you forgot the ping command but no bother.

To loop the menu option after someone has selected 1,2,3 or 4 you could use a while loop…

jonsellors · 2019-06-18T08:27:34.000Z

Here’s the code using a “while loop”:

$Option = "not q"

While ($Option -ne "q"){
Clear-Host

Write-Host "================ Welcome ================ 

1. List of processes on the system
2. List of services on the system
3. Send a ping
4. Double a number
Q. Quit"

$option = Read-Host "Please select an option" 

switch ($option){
    1{Get-Process}
    2{Get-Service}
    3{
      $Connection = Read-Host "Please write an IP adress or a domain name"
      #Do the ping
      Test-Connection $Connection}

    4{
      $num1 = Read-Host "Please write a number"
      Write-Host "Please wait ..."
      sleep -Seconds 1
      Write-Host "Your chosen number was $num1 and now it's $([int]$num1 + [int]$num1)"}
    Q{return}
}

}

daphrack · 2019-06-18T09:03:58.000Z

Thank you so much! Since I’m new, I still get a little confused with the process… And thanks for the ping command, totally forgot to add it!

jonsellors · 2019-06-18T09:09:58.000Z

Daphrack:

Thank you so much! Since I’m new, I still get a little confused with the process… And thanks for the ping command, totally forgot to add it!

Glad to help, you’re welcome

Neally · 2019-06-18T12:53:03.000Z

Both of you…

If you post code, please use the ‘Insert Code’ button. Please and thank you!

PLEASE READ BEFORE POSTING! Read if you're new to the PowerShell forum! Programming & Development

Hi, and welcome to the PowerShell forum! Don’t apologize for being a “noob” or “newbie” or “n00b.” There’s just no need – nobody will think you’re stupid, and the forums are all about asking questions. Just ask! Use a descriptive subject. Don't say "Need help" or "PowerShell Help", actually summarize what the problem is. It helps the rest of us keep track of which problem is which. Don’t post massive scripts. We’re all volunteers and we don’t have time to read all that, nor will we copy, past…

@jonsellors @daphrack

jonsellors · 2019-06-18T12:55:22.000Z

Will do Neally. I always used to forget, now I won’t

Also, I’ve also edited my original post so that its correctly “inserted as code”.