Loop in powershell

spiceuser-3fkxp · 2021-02-22T15:13:55.000Z

I need help to to execute a command in loop for multiple servers, I have these command I want to run them in a loop for multiple servers

Invoke-Command -Computer ‘IP’ -ScriptBlock {Remove-Item -Path $args[0] -force } -ArgumentList 'c:\Folder'

$Session = New-PSSession -ComputerName “IP” -Credential “user-name”
Copy-Item "C:\Folder" -Destination "C:" -ToSession $Session

Also how do I pass the password for the copy command ?
Any help is appreciated.

Neally · 2021-02-22T15:21:25.000Z

you’d use invoke -command instead and a foreach loop

spiceuser-3fkxp:

Also how do I pass the password for the copy command ?

hm?

e.g.

$cred = (Get-Credential)
$list = get-content "list.txt"

foreach($machine in $list){
    invoke-command -ComputerName $machine -ScriptBlock {
        Copy-Item "C:\Folder\" -Destination "C:\"
    } -Credential $cred
}

spiceuser-3fkxp · 2021-02-22T15:55:53.000Z

Tried this

$computers = Get-Content C:\computers.txt

foreach ($computer in $computers)
{
Invoke-Command -Computer ‘$computers’ -ScriptBlock {Remove-Item -Path $args[0] -force } -ArgumentList 'c:\Folder'

}

but getting error “Invoke-Command : One or more computer names are not valid. If you are trying to pass a URI, use the -ConnectionUri parameter, or pass URI objects instead of strings.”

I have added IPs in file computer.txt

what am I doing wrong here ?

tulioarends · 2021-02-22T16:04:58.000Z

spiceuser-3fkxp:

Tried this

$computers = Get-Content C:\computers.txt

foreach ($computer in $computers)
{
Invoke-Command -Computer ‘$computers’ -ScriptBlock {Remove-Item -Path $args[0] -force } -ArgumentList 'c:\Folder'

}

but getting error “Invoke-Command : One or more computer names are not valid. If you are trying to pass a URI, use the -ConnectionUri parameter, or pass URI objects instead of strings.”

I have added IPs in file computer.txt

what am I doing wrong here ?

From the Invoke-Command documentation:

To use an IP address in the value of ComputerName, the command must include the Credential parameter. The computer must be configured for the HTTPS transport or the IP address of the remote computer must be included in the local computer's WinRM TrustedHosts list. For instructions to add a computer name to the TrustedHosts list, see How to Add a Computer to the Trusted Host List.

Verify you meet those conditions or just use the FQDN or NETBIOS names.

Neally · 2021-02-22T16:05:16.000Z

spiceuser-3fkxp:

I have added IPs in file computer.txt

in what format?

like so?

192.168.15.20
192.168.15.21
192.168.15.22

spiceuser-3fkxp:

what am I doing wrong here ?

you can not use single quotes

Why are you trying to feed it “C:\Folder” as argument?
did you look at the sample I posted?
it should be also computer and not computerS in a foreach

 Invoke-Command -Computer '$computers' 
# needs to be 
 Invoke-Command -Computer $computer
#or
 Invoke-Command -Computer "$computer"

Neally · 2021-02-22T16:05:51.000Z

Also…
If you post code, please use the ‘Insert Code’ button. Please and thank you!

PLEASE READ BEFORE POSTING! Read if you're new to the PowerShell forum! Programming & Development

Hi, and welcome to the PowerShell forum! Don’t apologize for being a “noob” or “newbie” or “n00b.” There’s just no need – nobody will think you’re stupid, and the forums are all about asking questions. Just ask! Use a descriptive subject. Don't say "Need help" or "PowerShell Help", actually summarize what the problem is. It helps the rest of us keep track of which problem is which. Don’t post massive scripts. We’re all volunteers and we don’t have time to read all that, nor will we copy, past…

Neally · 2021-02-22T16:08:26.000Z

$computers = Get-Content C:\computers.txt

foreach ($computer in $computers)
{
  Invoke-Command -Computer '$computers' -ScriptBlock {Remove-Item -Path $args[0] -force } -ArgumentList 'c:\Folder\'

}

try like so
(again, we can not validate your input / computers.txt file, it should be just each IP listed under each other, no blank line )

$computers = Get-Content C:\computers.txt

foreach ($computer in $computers){
    Invoke-Command -Computer $computer -ScriptBlock {
        Remove-Item "c:\Folder" -force
    }
}

Evan7191 · 2021-02-22T16:09:11.000Z

spiceuser-3fkxp:

I have added IPs in file computer.txt

what am I doing wrong here ?

This is the problem. Invoke-Command uses WinRM for remoting, and WinRM uses DNS names by default. If you want to use IP address, the IP has to be added to the trusted list.

To use an IP address in the value of ComputerName, the command must include the Credential parameter. The computer must be configured for the HTTPS transport or the IP address of the remote computer must be included in the local computer's WinRM TrustedHosts list.

learn.microsoft.com

about Remote Troubleshooting - PowerShell

Describes how to troubleshoot remote operations in PowerShell.

spiceuser-3fkxp · 2021-02-22T16:17:30.000Z

@alexw Thank you so much for your help, I was able to run it with first code you gave.

Thanks again for your time I really appreciate your help.

$cred = (Get-Credential)
$list = get-content "computers.txt"

foreach($machine in $list){
    invoke-command -ComputerName $machine -ScriptBlock {
        Invoke-Expression -Command:"cmd.exe /c 'C:\batch\task.bat'"
    } -Credential $cred
}

spiceuser-3fkxp · 2021-02-22T16:25:01.000Z

@alexw Need one more help. I am trying to copy a folder to remote servers , is this the right command to do the same ?

$cred = (Get-Credential)
$list = get-content "computers.txt"

foreach($machine in $list){
    invoke-command -ComputerName $machine -ScriptBlock {
        Copy-Item "C:\Folder\" -Destination "C:\" -Recurse
    } -Credential $cred
}

Neally · 2021-02-22T16:27:34.000Z

spiceuser-3fkxp:

I am trying to copy a folder to remote servers

So you want FROM ComputerA to tell ComputerB to copy something to ComputerC ?

That’s the double hop problem, why don’t you copy it directly?

Making the second hop in PowerShell Remoting - PowerShell

This article explains the various methods for configuring second-hop authentication for PowerShell remoting, including the security implications and recommendations.

Progress Blogs – 15 Aug 18

The Infamous Double-Hop Problem in PowerShell

In this article, we will discuss how to get around the infamous double-hop problem in PowerShell.

https://4sysops.com/archives/solve-the-powershell-multi-hop-problem-without-using-credssp/

spiceuser-3fkxp · 2021-02-22T16:31:46.000Z

I just want to copy from Computer A to multiple computers (Computer B,C,D) I used the below command but was unable to put it in a loop

$Session = New-PSSession -ComputerName "IP" -Credential "user-name"
Copy-Item "C:\Folder\" -Destination "C:\" -ToSession $Session -Recurse

Neally · 2021-02-22T16:34:11.000Z

spiceuser-3fkxp:

I just want to copy from Computer A to multiple computers (Computer B,C,D) I used the below command but was unable to put it in a loop
$Session = New-PSSession -ComputerName "IP" -Credential "user-name"
Copy-Item "C:\Folder\" -Destination "C:\" -ToSession $Session -Recurse

You obviously can not use "C:" for that. you need a share or a file where everyone can access it.

So you can either put it in a share, or use the admin share.

#admin share
Copy-Item "\\computerA\C$\Folder" -Destination "C:\"
# shared folder
Copy-Item "\\computerA\ShareName\Folder" -Destination "C:\"

spiceuser-3fkxp · 2021-02-22T16:41:36.000Z

@alexw got that to work used the below code. Thanks for all your help

$cred = (Get-Credential)
$list = get-content "computers.txt"

foreach($machine in $list){
    $Session = New-PSSession -ComputerName "$machine" 
Copy-Item "C:\Folder\" -Destination "C:\" -ToSession $Session -Recurse
    } -Credential $cred

spiceuser-3fkxp · 2021-02-22T18:02:49.000Z

@alexw When trying to delete folder on remote server I have to say Yes for each machine when i run the script

I tried -Force , Confirm:$fasle but nothing works

Any thoughts how it can be done?

$cred = (Get-Credential)
$list = get-content "computers.txt"

foreach($machine in $list){
    invoke-command -ComputerName $machine -ScriptBlock {
        Remove-Item -Path $args[0] -force } -ArgumentList 'c:\Folder\'
    } -Credential $cred

Neally · 2021-02-22T18:05:27.000Z

spiceuser-3fkxp:

Neally When trying to delete folder on remote server I have to say Yes for each machine when i run the script

I tried -Force , Confirm:$fasle but nothing works

that should do the trick, did you typo it?

Remove-Item -Path $args[0] -force -confirm:$false -recurse

spiceuser-3fkxp · 2021-02-22T18:07:17.000Z

@alexw You are the man. Thanks a ton.

spiceuser-3fkxp · 2021-02-22T20:32:28.000Z

I am getting error for WinRm on a lot of the servers. How can I enable it on the servers remotely?
I don’t have AD

Neally · 2021-02-22T20:34:23.000Z

spiceuser-3fkxp:

I am getting error for WinRm on a lot of the servers. How can I enable it on the servers remotely?
I don’t have AD

How do you access them currently? RMM software? psexec?

e.g.

psexec.exe \\$computer -s C:\Windows\System32\winrm.cmd qc -quiet

spiceuser-3fkxp · 2021-02-25T14:25:33.000Z

@alexw using rmm
getting this error

CategoryInfo : OpenError: (192.168.1.10:String) , PSRemotingTransportException
FullyQualifiedErrorId : CannotConnect,PSSessionStateBroken