Modifying powershell script I have

anthonyowens3 · 2018-08-01T17:25:37.000Z

I have a Powershell script that creates three arrays One for OU’s and the other two for Security Groups.

Then it adds the users it finds in certain OU’s to certain security groups. Problem is that it tries to add users who are already in the security group. Is there a way to check the user it is pulling from the array of OU’s and then check it against the users in the Security Group that is currently being checked in the iteration of the loop? I can provide the scipt I’m using if needed

Neally · 2018-08-01T17:38:55.000Z

anthonyowens3:

Is there a way to check the user it is pulling from the array of OU’s and then check it against the users in the Security Group that is currently being checked in the iteration of the loop?

Sure

anthonyowens3:

Problem is that it tries to add users who are already in the security group.

While it’s not very efficient, why is that a problem?

anthonyowens3:

I can provide the scipt I’m using if needed

Yeah, without that we can’t help to match.

If you post code, please use the ‘Insert Code’ button. Please and thank you!

PLEASE READ BEFORE POSTING! Read if you're new to the PowerShell forum! Programming & Development

Hi, and welcome to the PowerShell forum! Don’t apologize for being a “noob” or “newbie” or “n00b.” There’s just no need – nobody will think you’re stupid, and the forums are all about asking questions. Just ask! Use a descriptive subject. Don't say "Need help" or "PowerShell Help", actually summarize what the problem is. It helps the rest of us keep track of which problem is which. Don’t post massive scripts. We’re all volunteers and we don’t have time to read all that, nor will we copy, past…

anthonyowens3 · 2018-08-01T17:43:23.000Z

Hey,

Glad to know it is possible I just do not know enough about scripting to do this myself. It’s not so much a problem but its not internal its for a client of mine its a contracted IT situation. If they ever see the errors even though they are not errors as such I know they will want it to now do that.

here is the code too thanks for the link.

Anthony.

#create the arrays for OU's and the two sets of Security Groups. AOU = All OU's. CSG = Core Security Groups RDSG = Remote Desktop Security Groups

#Create the for loop to cycle through the Organizational Units

for($i = 0;$i -lt $AOU.length; $i++) 
    
 { #opening OU loop
    
    #opening CSG loop
    for($j = 0;$j -lt $CSG.length; $j++)
        
        { #opening CSG loop

Get-ADUser –SearchBase $AOU[$i] –SearchScope OneLevel –LDAPFilter "(!memberOf=$CSG[$j])" | ForEach-Object {Add-ADPrincipalGroupMembership –Identity $_ –MemberOf $CSG[$j]}

        } #closing CSG loop
        
     
     #Starts forloop to cycle trough and add users to RDSG's
     for($l = 0;$l -lt $RDSG.length; $l++) 
        
        { #opening RDSG loop
           
Get-ADUser –SearchBase $AOU[$i] –SearchScope OneLevel –LDAPFilter "(!memberOf=$RDSG[$i])" | ForEach-Object {Add-ADPrincipalGroupMembership –Identity $_ –MemberOf $RDSG[$i]}

        } #closing RDSG loop
 
 } #closing OU loop

anthonyowens3 · 2018-08-01T17:44:30.000Z

I removed the part where I define the arrays cos of the Business name being in there.

Neally · 2018-08-01T17:45:21.000Z

What have you tried so far to match it?

anthonyowens3 · 2018-08-01T17:49:42.000Z

I tried writing the output of this line as I thought that is what it was doing but it was showing users who were in the group already. But I guess that line is not doing what I think it is doing.

Get-ADUser –SearchBase $AOU[$i] –SearchScope OneLevel –LDAPFilter "(!memberOf=$RDSG[$i])"

Neally · 2018-08-01T22:05:33.000Z

Basically you want to match it.

$members = Get-ADGroupMember -Identity $GroupName

if($members -contain $username){

}

or something like that to match it.