needs some coding advice

jongomes1992 · 2019-04-11T09:35:04.000Z

I have created this powershell code that creates new users and produces a report at the end of it.

I need to know how to i can capture accounts that haven’t be created because it has the same Username connected.

param(
[Parameter(Mandatory=$true)]$csvfile
)

Import-Module activedirectory

$users = Import-Csv -Path $csvfile

foreach ($User in $Users)
{ $Displayname = $User.lastname + “,” + $User.Firstname
$GivenName = $User.Firstname
$Sn = $User.Lastname
$Name = “$($User.Lastname), $($User.Firstname)”
$SamAccountName = “$($User.Firstname).$($User.Lastname)”
$UserPrincipalName = $UserPrincipalName = $User.Firstname + “.” + $User.Lastname + “@test.ruh.local” #Adds User Principle Name which was missing from previous script
$ProfilePath = $User.OU #user will be placed into the USERS ou on AD i will move them across manually
$Description = $User.Description
$password = $User.Password1

#creates new users
New-ADUser -DisplayName $Name -givenname “$GivenName” -Surname “$SN” -Name “$Name” -SamAccountName “$SamAccountName” -UserPrincipalName “$UserPrincipalName” -ProfilePath “$ProfilePath” -Description “$Description” -Enabled $False
Add-ADGroupMember -identity Guests -Members $SamAccountName #adds the groups
Add-ADGroupMember -identity Users -Members $SamAccountName

Write-Output “$(Get-Date) $SamAccountName Script excuted by $env:username” | Out-file C:\temp\test25.txt -append #Writes a csv file with the username of created accounts and who creates it

}

tulioarends · 2019-04-11T10:54:46.000Z

Hello and welcome to the community!.

First please read PLEASE READ BEFORE POSTING! Read if you're new to the PowerShell forum!

It helps us to help you if you follow the guidelines for posting code. Do use the insert code button.

jongomes1992 · 2019-04-11T10:56:18.000Z

thank you i will follow that next time

brad901 · 2019-04-11T11:03:46.000Z

Check out how Powershell implements a Try/Catch/Finally…

learn.microsoft.com

about Try Catch Finally - PowerShell

Describes how to use the `try`, `catch`, and `finally` blocks to handle terminating errors.

You should be able to catch any time that the New-ADUser command fails.

-Brad

coffeemaker2 · 2019-04-11T11:07:52.000Z

You may take a look at Thomas Cookbook:

https://www.amazon.com/Windows-Server-Automation-PowerShell-Cookbook-ebook/dp/B07KYRXX3D/ref=sr_1_fkmrnull_1?keywords=Thomas+lee+automation+powershell&qid=1554987762&s=gateway&sr=8-1-fkmrnull

There are very good examples for that (use it myself)

As for your Problem, I do not see a check if the User is connected… If I understand you correct, you want to Import a bunch of Users and create them, unless they are already active and/or connected to the Server?

Or do you just want to correct Users on your existing Server?

@thomaslee

jongomes1992 · 2019-04-11T11:14:38.000Z

Thank you for that website i will check it out.

also its to create user AD accounts, it has to recognise whether the account has already been created or the username has already been taken

brad901 · 2019-04-11T11:18:10.000Z

Another option is just to use Get-ADUser first.

jongomes1992 · 2019-04-11T11:21:54.000Z

Thanks I’ll have a go

tulioarends · 2019-04-11T11:22:28.000Z

The easiest way to get the information you want is to ask if the user already exists, rather than using try-catch blocks to handle exceptions.

$existingUsers = New-Object System.Collections.ArrayList
$newUsers = New-Object System.Collections.ArrayList

foreach ($User in $Users) {
    $SamAccountName = "$($User.Firstname).$($User.Lastname)"
    if (Get-ADUser $SamAccountName -ne $null) {
        $existingUsers.Add($User)
        return
    }
    else {
        $GivenName = $User.Firstname
        $Sn = $User.Lastname
        $Name = "$($User.Lastname), $($User.Firstname)"
        $UserPrincipalName = $UserPrincipalName = $User.Firstname + "." + $User.Lastname + "@test.ruh.local" #Adds User Principle Name which was missing from previous script
        $ProfilePath = $User.OU #user will be placed into the USERS ou on AD i will move them across manually
        $Description = $User.Description
        $password = $User.Password1
        #creates new users
        # Note the addition of the -PassTrough parameter to New-ADUser, otherwise it would return nothing
        $newUser = New-ADUser -DisplayName $Name -givenname "$GivenName" -Surname "$SN" -Name "$Name" -SamAccountName "$SamAccountName" -UserPrincipalName "$UserPrincipalName" -ProfilePath "$ProfilePath" -Description "$Description" -Enabled $False -PassThru
        $newUsers.Add($newUser)
        Add-ADGroupMember -identity Guests -Members $SamAccountName #adds the groups
        Add-ADGroupMember -identity Users -Members $SamAccountName
    }
    $existingUsers | Export-Csv "ExistingUsers.csv" -NoTypeInformation -Force
    $newUsers | Export-Csv "CreatedUsers.csv" -NoTypeInformation -Force
}

jongomes1992 · 2019-04-11T12:21:24.000Z

i’ve just tried this and throws me loads of errors

tulioarends · 2019-04-11T12:30:52.000Z

spicehead-wpx7o:

i’ve just tried this and throws me loads of errors

Good! Now you can fix and adjust until it fits your environment.

Most of the suggestions we can give you won’t be tested. For example, I have no need to create new users so I limited myself to my editor’s ( Visual Studio Code if you’re interested) syntax checker. I copied your script and removed some stuff from the beginning before doing my changes.

It’s up to you now to use the error messages to debug the code. If you’re stumped after a while feel free to post the errors and we can help, but remember that we are not a script writing service.

jongomes1992 · 2019-04-11T12:50:02.000Z

no thats fine thankyou for the help though