NTFS script

vanglee · 2020-05-14T17:51:07.000Z

Hello, I’m a newbie with PS and found this script on Netwrix’s website and even referenced the same script shared on here. I’ve made changes to the $Outfile and $Rootpath as suggested. I get the “where-object” below referencing the “foreach” parameter error and I’m not sure how to correct this.

Any help would be greatly appreciated.

Thanks!

PS C:\windows\system32> $OutFile = “C:\FileShareACL\Permissions1.csv” # Insert folder path where you want to save your file and its name
$Header = “Folder Path,IdentityReference,AccessControlType,IsInherited,InheritanceFlags,PropagationFlags”
$FileExist = Test-Path $OutFile
If ($FileExist -eq $True) {Del $OutFile}
Add-Content -Value $Header -Path $OutFile
$RootPath = “\servername\shareT” # Insert your share path
$Folders = dir $RootPath -recurse | where {$.psiscontainer -eq $true} foreach ($Folder) in ($Folders){
$ACLs = get-acl $Folder.fullname | ForEach-Object `{ $.Access }
Foreach ($ACL in $ACLs){
$OutInfo = $Folder.Fullname + “,” + $ACL.IdentityReference + “,” + $ACL.AccessControlType + “,” + $ACL.IsInherited + “,” + $ACL.InheritanceFlags + “,” + $ACL.PropagationFlags
Add-Content -Value $OutInfo -Path $OutFile
}

Where-Object : A positional parameter cannot be found that accepts argument ‘foreach’.
At line:7 char:37

… -recurse | where {$_.psiscontainer -eq $true} foreach ($Folder) in ( …
CategoryInfo : InvalidArgument: ( [Where-Object], ParameterBindingException
FullyQualifiedErrorId : PositionalParameterNotFound,Microsoft.PowerShell.Commands.WhereObjectCommand

big-green-man · 2020-05-14T18:14:48.000Z

I think you’re just missing a pipeline character.

$Folders = dir $RootPath -recurse | where {$_.psiscontainer -eq $true} foreach ($Folder) in ($Folders){

Should be:

$Folders = dir $RootPath -recurse | where {$_.psiscontainer -eq $true} | foreach ($Folder) in ($Folders){

Neally · 2020-05-14T18:24:28.000Z

If you post code, please use the ‘Insert Code’ button. Please and thank you!

PLEASE READ BEFORE POSTING! Read if you're new to the PowerShell forum! Programming & Development

Hi, and welcome to the PowerShell forum! Don’t apologize for being a “noob” or “newbie” or “n00b.” There’s just no need – nobody will think you’re stupid, and the forums are all about asking questions. Just ask! Use a descriptive subject. Don't say "Need help" or "PowerShell Help", actually summarize what the problem is. It helps the rest of us keep track of which problem is which. Don’t post massive scripts. We’re all volunteers and we don’t have time to read all that, nor will we copy, past…

Neally · 2020-05-14T18:28:12.000Z

i saw a backtick that was weird
But shame on that code, it’s so botched and fill with aliases.

$ACLs = get-acl $Folder.fullname | ForEach-Object `{ $_.Access }
##################################################^

so like so

# Insert folder path where you want to save your file and its name
$OutFile = "C:\FileShareACL\Permissions1.csv" 
$Header = "Folder Path,IdentityReference,AccessControlType,IsInherited,InheritanceFlags,PropagationFlags"
$FileExist = Test-Path $OutFile 
If ($FileExist -eq $True) { Del $OutFile } 
Add-Content -Value $Header -Path $OutFile 
# Insert your share path
$RootPath = "\\servername\shareT" 
$Folders = dir $RootPath -recurse | where { $_.psiscontainer -eq $true } 

foreach ($Folder in $Folders) {
    $ACLs = get-acl $Folder.fullname | 
    ForEach-Object { $folder.Access }
        Foreach ($ACL in $ACLs) {
            $OutInfo = $Folder.Fullname + "," + $ACL.IdentityReference + "," + $ACL.AccessControlType + "," + $ACL.IsInherited + "," + $ACL.InheritanceFlags + "," + $ACL.PropagationFlags
            Add-Content -Value $OutInfo -Path $OutFile 
        }
}

vanglee · 2020-05-14T18:33:55.000Z

Big Green Man, I added the pipeline you suggested and it returned with the error below.

$OutFile = "C:\FileShareACL\Permissions1.csv" # Insert folder path where you want to save your file and its name
$Header = "Folder Path,IdentityReference,AccessControlType,IsInherited,InheritanceFlags,PropagationFlags"
$FileExist = Test-Path $OutFile 
If ($FileExist -eq $True) {Del $OutFile} 
Add-Content -Value $Header -Path $OutFile 
$RootPath = "\\sp-file01\groups\ACCT" # Insert your share path
$Folders = dir $RootPath -recurse | where {$_.psiscontainer -eq $true} | ForEach ($Folder) in ($Folders){
    $ACLs = get-acl $Folder.fullname | ForEach-Object `{ $_.Access  }
    Foreach ($ACL in $ACLs){
    $OutInfo = $Folder.Fullname + "," + $ACL.IdentityReference  + "," + $ACL.AccessControlType + "," + $ACL.IsInherited + "," + $ACL.InheritanceFlags + "," + $ACL.PropagationFlags
    Add-Content -Value $OutInfo -Path $OutFile 
    }

ForEach-Object : Cannot bind parameter 'RemainingScripts'. Cannot convert the "in" value of type "System.String" to type "System.Management.Automation.ScriptBlock".
At line:7 char:74
+ ... where {$_.psiscontainer -eq $true} | ForEach ($Folder) in ($Folders){
+                                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidArgument: (:) [ForEach-Object], ParameterBindingException
    + FullyQualifiedErrorId : CannotConvertArgumentNoMessage,Microsoft.PowerShell.Commands.ForEachObjectCommand

big-green-man · 2020-05-14T18:38:31.000Z

Sorry, I missed one other thing in that line. The first part of your foreach statement has bad syntax. Should be:

$Folders = dir $RootPath -recurse | where {$_.psiscontainer -eq $true} | ForEach ($Folder in $Folders){

I’m also not sure what they’re doing with that back tick that Neally pointed out.

EDIT: And that foreach isn’t supposed to be accepting pipeline input. Spiceworks formatting threw me off (which is why the code blocks are important). Should be on a separate line like so:

$OutFile = "C:\FileShareACL\Permissions1.csv" # Insert folder path where you want to save your file and its name
$Header = "Folder Path,IdentityReference,AccessControlType,IsInherited,InheritanceFlags,PropagationFlags"
$FileExist = Test-Path $OutFile 
If ($FileExist -eq $True) {Del $OutFile} 
Add-Content -Value $Header -Path $OutFile 
$RootPath = "\\servername\shareT" # Insert your share path
$Folders = dir $RootPath -recurse | where {$_.psiscontainer -eq $true}
foreach ($Folder in $Folders){
    $ACLs = get-acl $Folder.fullname | ForEach-Object `{ $_.Access }
    Foreach ($ACL in $ACLs){
    $OutInfo = $Folder.Fullname + "," + $ACL.IdentityReference + "," + $ACL.AccessControlType + "," + $ACL.IsInherited + "," + $ACL.InheritanceFlags + "," + $ACL.PropagationFlags
    Add-Content -Value $OutInfo -Path $OutFile 
    }

Neally · 2020-05-14T18:41:04.000Z

Big Green Man:

Sorry, I missed one other thing in that line. The first part of your foreach statement has bad syntax. Should be:
$Folders = dir $RootPath -recurse | where {$_.psiscontainer -eq $true} | ForEach ($Folder in $Folders){
I’m also not sure what they’re doing with that back tick that Neally pointed out.

that’s still weird, as if they pipe sh…tuff it should be a foreach-object, not a foreach.

[...] where {$_.psiscontainer -eq $true} | ForEach ($Folder in $Folders){
# vs
[...] where {$_.psiscontainer -eq $true} | ForEach-Object {

big-green-man · 2020-05-14T18:42:14.000Z

Neally:

Big Green Man:
Sorry, I missed one other thing in that line. The first part of your foreach statement has bad syntax. Should be:
$Folders = dir $RootPath -recurse | where {$_.psiscontainer -eq $true} | ForEach ($Folder in $Folders){
I’m also not sure what they’re doing with that back tick that Neally pointed out.
that’s still weird, as if they pipe sh…tuff it should be a foreach-object, not a foreach.
[...] where {$_.psiscontainer -eq $true} | ForEach ($Folder in $Folders){
# vs
[...] where {$_.psiscontainer -eq $true} | ForEach {

Yeah, see my edit. Formatting in the OP stuck it on the same line.

Neally · 2020-05-14T18:48:24.000Z

so does THIS work for you, OP?

Big Green Man:

Got it :¬)

vanglee · 2020-05-14T19:20:25.000Z

Hi Guys. I’m testing it now against one of our shares on the file server. I’m no longer getting any errors after using the latest provided script so I think that’s a good thing. I appreciate both your help, especially the speedy responses. I’ve always had good experiences on here.