Pipe issue?

alistaircarr · 2020-07-06T05:35:38.000Z

I have the following script.

$CSVData = Import-Csv C:\mdm\import.csv
ForEach ($User in $CSVData) {
Get-MobileDevice -Mailbox $User.EmailAddress | Where {$.FirstSyncTime -lt (Get-Date -Hour 0 -Minute 00 -Second 00).AddDays(-22)} |
ForEach-Object {
Set-CasMailbox -identity $User.EmailAddress -ActiveSyncBlockedDeviceIDs $.DeviceID
| Remove-MobileDevice -Confirm:$False -whatif
}}

For some reason, the Set-CasMailbox -identity $User.EmailAddress -ActiveSyncBlockedDeviceIDs $_.DeviceID is not processing.

If i use the following script

$CSVData = Import-Csv C:\mdm\import.csv
ForEach ($User in $CSVData) {
Get-MobileDevice -Mailbox $User.EmailAddress | Where {$.FirstSyncTime -lt (Get-Date -Hour 0 -Minute 00 -Second 00).AddDays(-22)} |
ForEach-Object {
$.DeviceId
}
}
It outputs a list of the Active Sync Device ID"s so unsure as to whats happening?

If anyone could offer any assistance I’d be most grateful.

Thank you

Neally · 2020-07-06T10:55:34.000Z

If you post code, please use the ‘Insert Code’ button. Please and thank you!

PLEASE READ BEFORE POSTING! Read if you're new to the PowerShell forum! Programming & Development

Hi, and welcome to the PowerShell forum! Don’t apologize for being a “noob” or “newbie” or “n00b.” There’s just no need – nobody will think you’re stupid, and the forums are all about asking questions. Just ask! Use a descriptive subject. Don’t say “Need help” or “PowerShell Help”, actually summarize what the problem is. It helps the rest of us keep track of which problem is which. Don’t post massive scripts. We’re all volunteers and we don’t have time to read all that, nor will we copy…

Neally · 2020-07-06T10:58:36.000Z

looks like you are using foreach and foreach-object wrong

ForEach-Object {
            Set-CasMailbox -identity $User.EmailAddress

for foreach-object you use ‘$_’ or ‘$PSITEM’

ForEach-Object {
            Set-CasMailbox -identity $_.EmailAddress

alistaircarr · 2020-07-06T11:17:05.000Z

 $users = Get-Content -Path “C:\mdm\removeusers.txt”
Write-Host $users

foreach ($user in $users){
    $EASBLOCKS = get-mobiledevice -mailbox $user | Where {$_.FirstSyncTime -lt (Get-Date -Hour 0 -Minute 00 -Second 00).AddDays(-80)}  | Select-Object -ExpandProperty DeviceID
        foreach ($EASBLOCK in $EASBLOCKS) {
            Write-Host $user Active Sync ID to be moved to blocked is $EASBLOCKS | Set-CASMailbox -Identity $users ActiveSyncBlockedDeviceIDs $EASBLOCKS
        }
}

foreach ($user in $users) {
    $BLOCKEDIDS = Get-MobileDevice -mailbox $user | Where {$_.FirstSyncTime -lt (Get-Date -Hour 0 -Minute 00 -Second 00).AddDays(-80)}  | Select-Object -ExpandProperty identity 
            foreach ($BLOCKEDID in $BLOCKEDIDS) {
                Write-Host $BLOCKEDID belonging to $user has been removed | Remove-MobileDevice -Identity $BLOCKEDID.identity -Confirm:$false -whatif
    } 
}

Ok, I’ve re written the script.

The line having issues is

Set-CASMailbox -Identity $users ActiveSyncBlockedDeviceIDs $EASBLOCKS

$EASBLOCKS correctly shows the DeviceID

However, the DeviceID is not moved from the ActiveSyncAllowedDeviceDs to ActiveSyncBlockedDeviceIDs

(apologies for not posting code correctly in my earlier post)

Neally · 2020-07-06T11:45:31.000Z

that’s still off, you use the wrong variable, adn you can no pipe ‘write-host’ to a ‘set-’ cmdlet.

$users = Get-Content -Path "C:\mdm\removeusers.txt"
Write-Host $users

foreach ($user in $users) {
    $EASBLOCKS = get-mobiledevice -mailbox $user | 
                 Where { $_.FirstSyncTime -lt (Get-Date -Hour 0 -Minute 00 -Second 00).AddDays(-80) } | 
                 Select-Object -ExpandProperty DeviceID

    foreach ($EASBLOCK in $EASBLOCKS) {
        Write-Host $user Active Sync ID to be moved to blocked is $EASBLOCKS 
        Set-CASMailbox -Identity $EASBLOCK ActiveSyncBlockedDeviceIDs $EASBLOCKS
    }
}

foreach ($user in $users) {
    $BLOCKEDIDS = Get-MobileDevice -mailbox $user | 
                  Where { $_.FirstSyncTime -lt (Get-Date -Hour 0 -Minute 00 -Second 00).AddDays(-80) } | 
                  Select-Object -ExpandProperty identity 

    foreach ($BLOCKEDID in $BLOCKEDIDS) {
        Write-Host $BLOCKEDID belonging to $user has been removed
        Remove-MobileDevice -Identity $BLOCKEDID.identity -Confirm:$false -whatif
    } 
}

alistaircarr · 2020-07-06T12:09:11.000Z

Hi @alexw

So the following line in your script is incorrect i think

Set-CASMailbox -Identity $EASBLOCK -ActiveSyncBlockedDeviceIDs $EASBLOCKS

i think it needs to be the user email address which would be

Set-CASMailbox -Identity $User -ActiveSyncBlockedDeviceIDs $EASBLOCKS

However, if i try to run that I’m getting the following issue,

Cannot bind argument to parameter 'Identity' because it is null.
    + CategoryInfo          : InvalidData: (:) [Remove-MobileDevice], ParameterBindingValidationException
    + FullyQualifiedErrorId : ParameterArgumentValidationErrorNullNotAllowed,Remove-MobileDevice
    + PSComputerName        : outlook.office365.com

Neally · 2020-07-06T12:15:02.000Z

try like so

Set-CASMailbox -Identity $User -ActiveSyncBlockedDeviceIDs $EASBLOCK

if ‘$EASBLOCKS’ has multiple entries you might need a second foreach.

alistaircarr · 2020-07-06T13:43:55.000Z

Hi @alexw

Sorry, powershell novice, $EASBLOCKS can contain multiple values per $user

Could you give me an example of how that would look please?

Thank you for the input & help so far

Neally · 2020-07-06T14:13:14.000Z

like so in theory:

i have no access to those cmdlets so I can not test this for you

$users = Get-Content -Path “C:\mdm\removeusers.txt”
Write-Host $users

foreach ($user in $users) {
    $EASBLOCKS = get-mobiledevice -mailbox $user | 
    Where { $_.FirstSyncTime -lt (Get-Date -Hour 0 -Minute 00 -Second 00).AddDays(-80) } | 
    Select-Object -ExpandProperty DeviceID

    foreach ($EASBLOCK in $EASBLOCKS) {
        Write-Host "$user Active Sync ID to be moved to blocked is $EASBLOCK"
        Set-CASMailbox -Identity $user -ActiveSyncBlockedDeviceIDs $EASBLOCK
    }
}

foreach ($user in $users) {
    $BLOCKEDIDS = Get-MobileDevice -mailbox $user | 
    Where { $_.FirstSyncTime -lt (Get-Date -Hour 0 -Minute 00 -Second 00).AddDays(-80) } | 
    Select-Object -ExpandProperty identity 

    foreach ($BLOCKEDID in $BLOCKEDIDS) {
        Write-Host "$BLOCKEDID belonging to $user has been removed"
        Remove-MobileDevice -Identity $BLOCKEDID -Confirm:$false -whatif
    } 
}