For each loop?

spiceuser-jr5f9 · 2021-08-17T05:45:16.000Z

Hi,

I have a powershell script where i first do a invoke rest method to query an API, and then i convert the results to a data result, to finally create variables for the different values

$response = Invoke-RestMethod 'https:…

$response | ConvertTo-Json

$response.Data.result

Then the variables creation:

foreach ($responses in $response )

{ $task=$response.Data.result.task

$user=$response.Data.result.user

$group=$group }

The variables result is:

$task $user $group

task1 user1;user2 group1

task2 user3 group2

The goal is for each task to add users as members of Active Directory groups. (ex: add user 1 and user2 to group1 and user 3 to group 2) What would be the appropriate for each loop to have it working as desired?

Thanks, i am really blocked at the moment

Neally · 2021-08-17T06:05:56.000Z

Welcome

If you post code, please use the ‘Insert Code’ button. Please and thank you!

PLEASE READ BEFORE POSTING! Read if you're new to the PowerShell forum! Programming & Development

Hi, and welcome to the PowerShell forum! Don’t apologize for being a “noob” or “newbie” or “n00b.” There’s just no need – nobody will think you’re stupid, and the forums are all about asking questions. Just ask! Use a descriptive subject. Don't say "Need help" or "PowerShell Help", actually summarize what the problem is. It helps the rest of us keep track of which problem is which. Don’t post massive scripts. We’re all volunteers and we don’t have time to read all that, nor will we copy, past…

192033ab-bb8f-4032-88a5-8e2313af0344-codebutton_small.png

Neally Bot

Neally · 2021-08-17T06:07:17.000Z

Also, tough to help without sample data. Can you post sample data what the output of the response looks like?

spiceuser-jr5f9 · 2021-08-17T06:21:13.000Z

thank you for replying.

here’s the output of the response:

$response

Data Meta

@{result=System.Object} @{id=Id-752a1a612107e0685f489f27; timestamp=1629104757241; statusCode=200; self= https://operation.api.qua.intra.com/support/request/v1/getTasksByGroup?groups=GRP000390&c… .

DoctorDNS · 2021-08-17T10:54:27.000Z

One small thing => In the code

foreach ($responses in $response )
 { $task=$response.Data.result.task 
   $user=$response.Data.result.user 
   $group=$group 
  }

In each iteration through the $response array. $resonses is the current response. Ye know the 2nd and 3rd line you use $response - ie the whole array.

In general, I recommend you do this:

$NAMES = Get...   
Foreach ($Name in $Names) {

#  use $Name for this occurance

}