powershell add users to a group

donarachchi2 · 2021-05-19T01:04:32.000Z

HI

I am trying to add users with e3 license to a group call Microsoft E3 Licenses. but it fails. Here is the script. can some one help me. skulID is 1ict322:ems

$msolUsers = Get-MsolUser -EnabledFilter EnabledOnly | Where-Object {($_.licenses).AccountSkuId -eq ‘1ICT322:EMS’}

ForEach ($user in $msolUsers) {
try {
$ADUser = Get-ADUser -filter {UserPrincipalName -eq $user.UserPrincipalName} -ErrorAction stop

Add-ADGroupMember -Identity Microsoft E3 Licenses -Members $ADUser -ErrorAction stop

[PSCustomObject]@{
UserPrincipalName = $user.UserPrincipalName
Migrate = $true
}
}
catch {
[PSCustomObject]@{
UserPrincipalName = $user.UserPrincipalName
Migrate = $false
}
}
}

UserPrincipalName Migrate

din.arachchi@1ict.com.au False

Neally · 2021-05-19T01:57:32.000Z

If you post code, please use the ‘Insert Code’ button. Please and thank you!

PLEASE READ BEFORE POSTING! Read if you're new to the PowerShell forum! Programming & Development

Hi, and welcome to the PowerShell forum! Don’t apologize for being a “noob” or “newbie” or “n00b.” There’s just no need – nobody will think you’re stupid, and the forums are all about asking questions. Just ask! Use a descriptive subject. Don’t say “Need help” or “PowerShell Help”, actually summarize what the problem is. It helps the rest of us keep track of which problem is which. Don’t post massive scripts. We’re all volunteers and we don’t have time to read all that, nor will we copy…

seannoy2 · 2021-05-19T01:58:42.000Z

donarachchi2:

HI

I am trying to add users with e3 license to a group call Microsoft E3 Licenses. but it fails. Here is the script. can some one help me. skulID is 1ict322:ems

$msolUsers = Get-MsolUser -EnabledFilter EnabledOnly | Where-Object {($_.licenses).AccountSkuId -eq ‘1ICT322:EMS’}

ForEach ($user in $msolUsers) {
try {
$ADUser = Get-ADUser -filter {UserPrincipalName -eq $user.UserPrincipalName} -ErrorAction stop

Add-ADGroupMember -Identity Microsoft E3 Licenses -Members $ADUser -ErrorAction stop

[PSCustomObject]@{
UserPrincipalName = $user.UserPrincipalName
Migrate = $true
}
}
catch {
[PSCustomObject]@{
UserPrincipalName = $user.UserPrincipalName
Migrate = $false
}
}
}

UserPrincipalName Migrate

din.arachchi@1ict.com.au False

Hi, if you have Spaces in the group name you must wrap it with " "
See if that helps in the add-adgrouomember statement.
Best,
Sean

Neally · 2021-05-19T01:58:43.000Z

donarachchi2:

but it fails

UserPrincipalName Migrate

din.arachchi@1ict.com.au False

other than just ‘false’ you should write out the actual error message… that might help…

Neally · 2021-05-19T02:04:59.000Z

As Sean mentioned, make sure the groupname is right.

‘get-aduser’ does not error out if you use a filter, so there is no need for try/catch

try like so

$msolUsers = 
Get-MsolUser -EnabledFilter EnabledOnly | 
Where-Object { ($_.licenses).AccountSkuId -eq '1ICT322:EMS' }

ForEach ($user in $msolUsers) {
    $ADUser = Get-ADUser -filter { UserPrincipalName -eq $user.UserPrincipalName }
    try {
        Add-ADGroupMember -Identity "Microsoft E3 Licenses" -Members $ADUser -ErrorAction stop

        [PSCustomObject]@{
            UserPrincipalName = $user.UserPrincipalName
            Migrate           = $true
            Status            = 'Success'
        }
    }
    catch {
        [PSCustomObject]@{
            UserPrincipalName = $user.UserPrincipalName
            Migrate           = $false
            Status            = $error[0].exception.message
        }
    }
}