find user a member of group if not add

spitir2021 · 2021-03-19T00:29:10.000Z

I tried the script to find user a member of the group and If the user not add the user to group.

$users = Get-ADUser -SearchBase “OU=MD,OU=AU-Users,OU=AU, DC=CORP,DC=PRI” -Filter *
$group = “AU-GG-APP-SASReportViewer”
$members = Get-ADGroupMember -Identity $group -Recursive | Select -ExpandProperty SAMAccountName
ForEach ($user in $users) {
If ($members -contains $user) {
Write-Host “$user in group”
} Else {
Write-Host “$user not in group”
Add-ADGroupMember -Identity $group -Members $user
}
}

Getting the result always as:

CN=test McD,OU=MD,OU=AU-Users,OU=AU,DC=corp,DC=pri not in group
CN=test 2,OU=MD,OU=AU-Users,OU=AU,DC=corp,DC=pri not in group

Even if the user is a part of the group, it says it is not. When i change the $users variable to just one user, it gives the right result.

Neally · 2021-03-19T00:35:55.000Z

Welcome!

If you post code, please use the ‘Insert Code’ button. Please and thank you!

PLEASE READ BEFORE POSTING! Read if you're new to the PowerShell forum! Programming & Development

Hi, and welcome to the PowerShell forum! Don’t apologize for being a “noob” or “newbie” or “n00b.” There’s just no need – nobody will think you’re stupid, and the forums are all about asking questions. Just ask! Use a descriptive subject. Don’t say “Need help” or “PowerShell Help”, actually summarize what the problem is. It helps the rest of us keep track of which problem is which. Don’t post massive scripts. We’re all volunteers and we don’t have time to read all that, nor will we copy…

spitir2021 · 2021-03-19T00:58:51.000Z

sure.

$users = Get-ADUser -SearchBase "OU=MD,OU=AU-Users,OU=AU, DC=CORP,DC=PRI" -Filter * | select SamaccountName
$group = "AU-GG-APP-SASReportViewer"
$members = Get-ADGroupMember -Identity $group -Recursive
ForEach ($user in $users) {
    If ($members -contains $user) {
        Write-Host "$user in group"
    } Else {
        Write-Host "$user not in group"
        Add-ADGroupMember -Identity $group -Members $user
    }
}

Neally · 2021-03-19T01:01:22.000Z

You are comparing apples to oranges

(samaccountname) to (AD Object)

try like so:

$users = Get-ADUser -Filter * -SearchBase "OU=MD,OU=AU-Users,OU=AU, DC=CORP,DC=PRI"
$group = "AU-GG-APP-SASReportViewer"
$members = (Get-ADGroupMember -Identity $group -Recursive).SAMAccountName

ForEach ($user in $users) {
    If ($members -contains "$($user.samaccountname)") {
        Write-output "$user in group"
    }
    Else {
        Write-output "$user not in group"
        Add-ADGroupMember -Identity $group -Members $user
    }
}

spitir2021 · 2021-03-19T01:52:35.000Z

I did that but the result is the same where the users are shown as not in the group.

I want to test if the user is a part of the group or not. If not then add the user as a member of the group. The script looks simple but not ready to work.

spitir2021 · 2021-03-19T01:54:12.000Z

I test the script you added. Seems to work. Thanks for that. I am testing it again. Will let you know in few minutes.

spitir2021 · 2021-03-19T02:09:34.000Z

Any advice on how to export the list of users not in group and in group to CSV in the same script?

jitensh · 2021-03-19T02:10:33.000Z

with a bit of try catch

$users  =  Get-ADUser -SearchBase "OU=MD,OU=AU-Users,OU=AU, DC=CORP,DC=PRI" -Filter * | select -ExpandProperty SamaccountName
$groups = "AU-GG-APP-SASReportViewer"
Foreach   ($user in $users) {
Foreach   ($group in $groups){
$ErrorActionPreference='stop'
Try{
        $members = Get-ADGroupMember -Identity $group -Recursive | Select -ExpandProperty SamAccountName
        }
        Catch{
        $members = $null
        Write-Warning "$_"  
        }
        If ($members -contains $user) 
        {
         "$user is in $group" 
              
        } 
        Else
         {
         "$user is not in $group"   
           Add-ADGroupMember -Identity $group -Members $user
        }
    }
}

spitir2021 · 2021-03-19T02:15:17.000Z

Hi Jiten that works but I want to export the result for in the group and not in group toa CSV. I know I can export the membership result but not sure how to get result in the function.

Neally · 2021-03-19T02:17:01.000Z

sure, how do you want it to look like?

$users = Get-ADUser -Filter * -SearchBase "OU=MD,OU=AU-Users,OU=AU, DC=CORP,DC=PRI"
$group = "AU-GG-APP-SASReportViewer"
$members = (Get-ADGroupMember -Identity $group -Recursive).SAMAccountName

ForEach ($user in $users) {
    If ($members -contains "$($user.samaccountname)") {
        Write-output "$user in group" |
        out-file "GroupInfo.txt" -Append
    }
    Else {
        Write-output "$user not in group" |
        out-file "GroupInfo.txt" -Append
        Add-ADGroupMember -Identaity $group -Members $user
    }
}