Powershell output format question.

atsur415 · 2020-03-17T20:24:44.000Z

I have to write a script that collects data about computer and user objects and need one line output per foreach loop.
Quick example…
If($host.pingsucceeded){
write-output Ping Sucessful
}
else{
write-output Ping Failed
}
There are multiple tests for each user and host. How do I store the output and write it to one line at the end of each loop?

Neally · 2020-03-17T21:02:27.000Z

Atsur415:

have to write a script

cool, what have you tried? Where are you stuck?

If you post code, please use the ‘Insert Code’ button. Please and thank you!

PLEASE READ BEFORE POSTING! Read if you're new to the PowerShell forum! Programming & Development

Hi, and welcome to the PowerShell forum! Don’t apologize for being a “noob” or “newbie” or “n00b.” There’s just no need – nobody will think you’re stupid, and the forums are all about asking questions. Just ask! Use a descriptive subject. Don't say "Need help" or "PowerShell Help", actually summarize what the problem is. It helps the rest of us keep track of which problem is which. Don’t post massive scripts. We’re all volunteers and we don’t have time to read all that, nor will we copy, past…

qexle · 2020-03-18T10:39:16.000Z

Try this

If($host.pingsucceeded){
$hostResult = Write-Host 'Ping Success'
}
else{
$hostResult = Write-Host 'Ping Failed'
}
$hostResult

DoctorDNS · 2020-03-18T12:06:49.000Z

Can you explain the use case a bit more? What do you want to achieve??

atsur415 · 2020-03-18T12:44:02.000Z

Below is a detailed example. This returns two lines of code if the host is online. Line one, host is online. Line two, service is Running. How can I format the output to show on one line? Host x is online and service x is running/ stopped?

$computers = 'comp1','comp2'

foreach ($comp in $computers){   
    $testconnection= tnc $comp
    $servicecheck = Get-Service -ComputerName $comp -Name BITS
    if($testconnection.PingSucceeded -eq $true){
    Write-Output $comp is ON
       if($servicecheck.Status -eq "Stopped"){
       Write-Output "Service is Stopped"
       }
       if($servicecheck.Status -eq "Running"){
       Write-Output "Service is Running"
       }
    } 
    elseif($testconnection.PingSucceeded -eq $false){
    Write-Output $comp is OFF
    }
 }

DoctorDNS · 2020-03-18T13:35:16.000Z

Something like this?

foreach ($comp in $computers){   
    $MSG = ''
    $testconnection= tnc $comp
    $servicecheck = Get-Service -ComputerName $comp -Name BITS
    if($testconnection.PingSucceeded -eq $true){
    $MSG += "$comp is ON "
       if($servicecheck.Status -eq "Stopped"){
       $MSG += "Service is Stopped"
       }
       if($servicecheck.Status -eq "Running"){
       $MSG += "Service is Running"
       }
    } 
    elseif($testconnection.PingSucceeded -eq $false){
    $MSG += "$comp is OFF"
    }
  $MSG
}

Evan7191 · 2020-03-18T13:51:59.000Z

Atsur415:

I have to write a script that collects data about computer and user objects and need one line output per foreach loop.
Quick example…
If($host.pingsucceeded){
write-output Ping Sucessful
}
else{
write-output Ping Failed
}
There are multiple tests for each user and host. How do I store the output and write it to one line at the end of each loop?

You can set a variable equal to a loop, and it will contain all of the output produced by the loop.

$Results = ForEach ($host in $hosts) {
    If ($host.pingsucceeded){
        "Ping Sucessful"
    } else{ 
        "Ping Failed"
    }
}
$Results | Out-File "Drive:\Folder\File.txt"

DoctorDNS · 2020-03-18T13:57:14.000Z

Assigning a for each loop to a variable is not a good idea. ANd it does not work. To illustrate:

PS C:\foo> $a = 1,2,3
PS C:\foo> foreach ($a in $a) {$a}
1
2
3
PS C:\foo> $x = foreach ($a in $a) {$a}
PS C:\foo> $x
3

atsur415 · 2020-03-18T14:34:38.000Z

tfl:

Something like this?

foreach ($comp in $computers){   
    $MSG = ''
    $testconnection= tnc $comp
    $servicecheck = Get-Service -ComputerName $comp -Name BITS
    if($testconnection.PingSucceeded -eq $true){
    $MSG += "$comp is ON "
       if($servicecheck.Status -eq "Stopped"){
       $MSG += "Service is Stopped"
       }
       if($servicecheck.Status -eq "Running"){
       $MSG += "Service is Running"
       }
    } 
    elseif($testconnection.PingSucceeded -eq $false){
    $MSG += "$comp is OFF"
    }
  $MSG
}

This is exactly what I was looking for. Thank you!

Evan7191 · 2020-03-18T16:42:23.000Z

tfl:

Assigning a for each loop to a variable is not a good idea.

Why is it not a good idea? It is more efficient than using the += operator on an array.

tfl:

ANd it does not work. To illustrate:

PS C:\foo> $a = 1,2,3
PS C:\foo> foreach ($a in $a) {$a}
1
2
3
PS C:\foo> $x = foreach ($a in $a) {$a}
PS C:\foo> $x
3

It does work. I’ve done it many times. To illustrate:

PS> $test = @("a","b","c")
PS> $Result = ForEach ($Letter in $test) {$Letter}
PS> $Result
a
b
c

Neally · 2020-03-18T17:12:08.000Z

Evan7191:

tfl:

Assigning a for each loop to a variable is not a good idea.

Why is it not a good idea? It is more efficient than using the += operator on an array.

Totally agree, can you elaborate Thomas? I was going to comment on it as well.
I get it for a small collection it’s tomayto, tomato, but if you have a larger collection, assigning a variable is so so much faster and it works just fine.

@thomaslee @techadmin8

DoctorDNS · 2020-03-18T18:44:19.000Z

OK - I Goofed. Taking a closer look at that code reveals some errors oh my part.

One of those days.