Problem with If/else statement.

brunofrisan · 2019-02-07T18:15:27.000Z

New to power shell and for the life of me can’t figure out what I’m doing wrong with my if/else statement.

Neally · 2019-02-07T18:17:01.000Z

Do you have a sample What you are actually doing?

the basic is this:

if($condition){
    #true
    # do stuff
}
else{
    #false
    # do other stuff
}

If you post code, please use the ‘Insert Code’ button. Please and thank you!

PLEASE READ BEFORE POSTING! Read if you're new to the PowerShell forum! Programming & Development

Hi, and welcome to the PowerShell forum! Don’t apologize for being a “noob” or “newbie” or “n00b.” There’s just no need – nobody will think you’re stupid, and the forums are all about asking questions. Just ask! Use a descriptive subject. Don't say "Need help" or "PowerShell Help", actually summarize what the problem is. It helps the rest of us keep track of which problem is which. Don’t post massive scripts. We’re all volunteers and we don’t have time to read all that, nor will we copy, past…

brunofrisan · 2019-02-07T18:19:06.000Z

Trying to insert powershell code but it won’t let me using the insert code button.

creating a script for our users to run where it will pop up some basic computer info.

[void] [System.reflection.Assembly]::LoadWithPartialName(“System.drawing”)
[void] [System.reflection.Assembly]::LoadWithPartialName(“System.Windows.Forms”)

$objForm = New-object System.Windows.Forms.Form
$objForm.Text = “Computer Information”
$objForm.Size = New-Object System.Drawing.Size(300,300)
$objForm.StartPosition = “CenterScreen”

$objForm.KeyPreview = $True
$objForm.Add_KeyDown({if ($.KeyCode -eq “Enter”)
{$x=$objTextBox.Text;$objForm.Close()}})
$objForm.Add_KeyDown({if ($.KeyCode -eq “Escape”)
{$objForm.Close()}})

Get Host Name

$HostN = (Get-WmiObject -Class Win32_ComputerSystem -Property Name).Name
$HostN = $HostN

Host Name Label

$objLabel = New-Object System.Windows.Forms.Label
$objLabel.Location = New-Object System.Drawing.Size(50,20)
$objLabel.size = New-Object System.Drawing.Size(225,23)
$objLabel.Text = “COMPUTER NAME: $HostN”
$OBJFORM.Controls.Add($objLabel)

#Get IP
$ip=get-WmiObject Win32_NetworkAdapterConfiguration|Where {$_.Ipaddress.length -gt 1}
$IPADDR=$ip.ipaddress[0]

If ($IPADDR -like “192...*”) {$OutputTxtbx.text = “On network”}
Else {$OutputTxtbx.text = “Off network”}

IP Label

$objLabel = New-Object System.Windows.Forms.Label
$objLabel.Location = New-Object System.Drawing.Size(70,72)
$objLabel.size = New-Object System.Drawing.Size(200,23)
$objLabel.Text = “IP ADDRESS: $IPADDR”
$objform.Controls.Add($objLabel)

#OUtput Box
$OutputTxtbx = New-Object System.Windows.Forms.Textbox
$OutputTxtbx.Location = ‘70,100’
$OutputTxtbx.Size = ‘150,30’
$outputTxtbx.MultiLine = $True
$outputTxtbx.BackColor = “Black”
$outputTxtbx.foreColor = “White”
$outputTxtbx.Borderstyle = “none”
#$OutputTxtbx.scrollbars = “vertical”
$objForm.Controls.Add($OutputTxtbx)
$objForm.Topmost = $True
$objForm.add_Shown({$objForm.Activate()})
[void] $objForm.ShowDialog()

OK Button

$OKButton = New-Object System.Windows.Forms.Button
$OKButton.Location = New-Object System.Drawing.Size(100,200)
$OKButton.Size = New-Object System.Drawing.Size(75,23)
$OKButton.Text = “OK”
$OKButton.Add_Click({$x=$objTextBox.Text;$objForm.Close()})
$objForm.Controls.Add($OKButton)

$objForm.Topmost = $True

$objForm.add_Shown({$objForm.Activate()})
[void] $objForm.ShowDialog()

Neally · 2019-02-07T18:20:47.000Z

Ok… that’s a bunch of code, what part exactly does not work, can you condense it down to a few lines?

Have you tried a different browser for the insert code feature? This is pretty much unreadable.

brunofrisan · 2019-02-07T18:32:38.000Z

Sorry using IE and it will not let me insert code. Firefox will not let us access this spiceworks. : (

$ip=get-WmiObject Win32_NetworkAdapterConfiguration|Where {$_.Ipaddress.length -gt 1}

$IPADDR=$ip.ipaddress[0]

If ($IPADDR -like “192...*”) {$OutputTxtbx.text = “On Network”}

Else {$OutputTxtbx.text = “Off Network”}

Evan7191 · 2019-02-07T18:37:48.000Z

Don’t put an If statement with a method call. Run your If statements before calling the method, or call the method from within the If statement.

brunofrisan · 2019-02-07T18:45:51.000Z

no matter where I run if I get this

Else : The term ‘Else’ is not recognized as the name of a cmdlet, function, script file, or operable program.

Check the spelling of the name, or if a path was included, verify that the path is correct and try again.

Neally · 2019-02-07T18:53:46.000Z

Another error I get it that you are trying to set the text before you actually declare the object.

try to set the if after the decalration

e.g.

[void] [System.reflection.Assembly]::LoadWithPartialName("System.drawing")
[void] [System.reflection.Assembly]::LoadWithPartialName("System.Windows.Forms")

$objForm = New-object System.Windows.Forms.Form
$objForm.Text = "Computer Information"
$objForm.Size = New-Object System.Drawing.Size(300, 300)
$objForm.StartPosition = "CenterScreen"

$objForm.KeyPreview = $True
$objForm.Add_KeyDown( {if ($_.KeyCode -eq "Enter")
        {$x = $objTextBox.Text; $objForm.Close()}})
$objForm.Add_KeyDown( {if ($_.KeyCode -eq "Escape")
        {$objForm.Close()}})

# Get Host Name
$HostN = (Get-WmiObject -Class Win32_ComputerSystem -Property Name).Name
$HostN = $HostN

# Host Name Label
$objLabel = New-Object System.Windows.Forms.Label
$objLabel.Location = New-Object System.Drawing.Size(50, 20)
$objLabel.size = New-Object System.Drawing.Size(225, 23)
$objLabel.Text = "COMPUTER NAME: $HostN"
$OBJFORM.Controls.Add($objLabel)

#Get IP
$ip = get-WmiObject Win32_NetworkAdapterConfiguration| Where {$_.Ipaddress.length -gt 1}
$IPADDR = $ip.ipaddress[0]

# IP Label
$objLabel = New-Object System.Windows.Forms.Label
$objLabel.Location = New-Object System.Drawing.Size(70, 72)
$objLabel.size = New-Object System.Drawing.Size(200, 23)
$objLabel.Text = "IP ADDRESS: $IPADDR"
$objform.Controls.Add($objLabel)
  
#OUtput Box
$OutputTxtbx = New-Object System.Windows.Forms.Textbox
If ($IPADDR -like "192.*.*.*") {
    $OutputTxtbx.text = "On network"
}
Else {
    $OutputTxtbx.text = "Off network"
}
$OutputTxtbx.Location = '70,100'
$OutputTxtbx.Size = '150,30'
$outputTxtbx.MultiLine = $True
$outputTxtbx.BackColor = "Black" 
$outputTxtbx.foreColor = "White" 
$outputTxtbx.Borderstyle = "none" 
#$OutputTxtbx.scrollbars = "vertical"
$objForm.Controls.Add($OutputTxtbx)
$objForm.Topmost = $True
$objForm.add_Shown( {$objForm.Activate()})
[void] $objForm.ShowDialog()

# OK Button
$OKButton = New-Object System.Windows.Forms.Button
$OKButton.Location = New-Object System.Drawing.Size(100, 200)
$OKButton.Size = New-Object System.Drawing.Size(75, 23)
$OKButton.Text = "OK"
$OKButton.Add_Click( {$x = $objTextBox.Text; $objForm.Close()})
$objForm.Controls.Add($OKButton)

$objForm.Topmost = $True

$objForm.add_Shown( {$objForm.Activate()})
[void] $objForm.ShowDialog()

brunofrisan · 2019-02-07T19:19:23.000Z

Think this might work. Thank you!

barnaclejack · 2019-02-11T14:05:02.000Z

I found that this works just fine.

change {$.Ipaddress.length -gt 1} to {$.Ipaddress.length -ne 0}

$ip=get-WmiObject Win32_NetworkAdapterConfiguration|Where {$_.Ipaddress.length -ne 0}