Second foreach loop will not append to Export-csv

kurolearnstocode · 2022-02-10T07:43:15.000Z

Hi everyone thanks for reading my question. I have something like below that works:

                $clustercheck = Get-Cluster
                $clshostreport = @()
                $clsdatastorereport = @()
                foreach($clsname in $clustercheck){

                    $hosts = Get-VMHost -Location $clsname | select -expandproperty name
                    foreach($clshost in $hosts){
                        $hostcputotal = [Math]::Round(((get-vmhost -name $clshost | select -expandproperty cputotalmhz)*2),2)
                        $hostcpuusage = [Math]::Round((((get-vmhost -name $clshost | Get-Stat -Stat cpu.usagemhz.average -Start (Get-Date).AddDays(-30) -IntervalMins 5 | Measure-Object Value -Average).Average)),2)
                        $hostmemtotal = [Math]::Round((get-vmhost -name $clshost | select -expandproperty memorytotalgb),2)
                        $hostmemusage = [Math]::Round((get-vmhost -name $clshost | select -expandproperty memoryusagegb),2)
                        $freecpuperc = [Math]::Round(((1 - ($hostcpuusage/$hostcputotal))*100),2)
                        $freememperc = [Math]::Round(((1 - ($hostmemusage/$hostmemtotal))*100),2)
                        $clshostreport += [PSCustomObject]@{
                            Hostname = (get-vmhost -name $clshost | select -expandproperty name )
                            HostCPUTotalMHz = $hostcputotal
                            HostCPUUsageMHz = $hostcpuusage
                            HostCPUFreePercentage = $freecpuperc
                            HostMemTotalGB = $hostmemtotal
                            HostMemUsageGB = $hostmemusage
                            HostMemFreePercentage = $freememperc

                        }

                        $clshostreport | select Hostname,HostCPUTotalMHz,HostCPUUsageMHz,HostCPUFreePercentage,HostMemTotalGB,HostMemUsageGB,HostMemFreePercentage | Export-Csv .\clshostreport.csv -NoTypeInformation -encoding "unicode"
                         
                    }

                    $clsdatastore = get-cluster -name $clsname | get-datastore | where {$_.ExtensionData.Summary.MultipleHostAccess}
                    foreach ($clsds in $clsdatastore){

                        $clsstgtotal = $clsds | select-object -expandproperty capacityGB
                        $clsstgfree = $clsds | select -expandproperty freespaceGB      
                        $clsstgfreeperc = ($clsstgfree/$clsstgtotal)*100
                        $clsdatastorereport += [PSCustomObject] @{
                            DsName = $clsds.Name
                            TotalSpace = [Math]::Round($clsstgtotal,2)
                            FreeSpace = [Math]::Round($clsstgfree,2)
                            FreeSpacePercentage = [Math]::Round($clsstgfreeperc,2)

                        }

                        $clsdatastorereport | select DsName, TotalSpace, FreeSpace, FreeSpacePercentage | Export-Csv .\clsdsreport.csv -NoTypeInformation -encoding "unicode"
                       
                    }

                }

As you can see I have two foreach loops which output is two different .csv files.

I want them to be in one .csv, with first foreach’s output on top and second foreach at the bottom.

I tried adding putting the same .csv files while the second foreach i added -append like

$clsdatastorereport | select DsName, TotalSpace, FreeSpace, FreeSpacePercentage | Export-Csv .\clshostreport.csv -append -NoTypeInformation -encoding “unicode”

but the the second foreach loop output wont come out.

Any help is appreciated. Thanks

Neally · 2022-02-10T07:56:36.000Z

spicehead-68ixe:

Export-Csv .\clsdsreport.csv -NoTypeInformation -encoding “unicode”

the second one does not append anyways? does the data return output?

If you post code, please use the ‘Insert Code’ button. Please and thank you!

PLEASE READ BEFORE POSTING! Read if you're new to the PowerShell forum! Programming & Development

Hi, and welcome to the PowerShell forum! Don’t apologize for being a “noob” or “newbie” or “n00b.” There’s just no need – nobody will think you’re stupid, and the forums are all about asking questions. Just ask! Use a descriptive subject. Don’t say “Need help” or “PowerShell Help”, actually summarize what the problem is. It helps the rest of us keep track of which problem is which. Don’t post massive scripts. We’re all volunteers and we don’t have time to read all that, nor will we copy…

192033ab-bb8f-4032-88a5-8e2313af0344-codebutton_small.png

kurolearnstocode · 2022-02-10T08:03:15.000Z

Hi @alexw

Edited my post to put the code in the insert code box.

Yes it does not append, if i were to run the code with the second export-csv line like below;

$clsdatastorereport | select DsName, TotalSpace, FreeSpace, FreeSpacePercentage | Export-Csv .\clshostreport.csv -append -NoTypeInformation -encoding “unicode”

clshostreport.csv will only have output from the first foreach.

i know my arrays and inputs are correct because i get my desired outputs if they are printed out to two different .csv

just juicing my head on how to make them export to a single csv.

Thanks again in advance

adminofthings · 2022-02-10T12:52:46.000Z

CSV output does not work the way you want. The first set of data will have property1, property2, property3, etc. When the CSV file is created from the first set of data, it will have Header1, Header2, Header3, which correspond to the property names. The second set of data will have different properties like property4, property5, and property6. Those properties won’t have any corresponding headers in the already existing CSV file and therefore outputs no data. The only way to do what you want is to have all objects have the same property set.