Need help on teams/AD powershell that logs success/fail

iamtnerb · 2022-05-24T05:29:02.000Z

I need help on customizing my script that can export the following to csv:

Success/Fail

Email address of the user.

My script is below. Im not very verse with powershell hoping someone

$Users=Import-csv c:\temp\user.csv
$failedUsers = @()
$successUsers = @()
$VerbosePreference = "Continue"
$LogFolder = "C:\temp"
ForEach($User in $Users)
{
  $Identity = $User.identity
  $PhoneNumber = $User.PhoneNumber

try {
    if (!(get-csonlineuser -identity $Identity))
    {
      Set-CsPhoneNumberAssignment -Identity $identity -PhoneNumber $PhoneNumber -PhoneNumberType DirectRouting
        Write-Verbose "[PASS] Phone number and Enterprise voice enabled for $Identity"
        $successUsers += $Identity
    }
    else {
        Write-Warning "[WARNING] No result found on [$($Identity)]"
        $usersAlreadyExist += $Identity
    }
}
catch {
    Write-Warning "[ERROR]Can't create user [$($Identity)] : $_"
    $failedUsers += $Identity
}
}
if ( !(test-path $LogFolder)) {
    Write-Verbose "Folder [$($LogFolder)] does not exist, creating"
    new-item $LogFolder -Force
}

Write-verbose "Writing logs"
$failedUsers | out-file -FilePath $LogFolder\FailedUsers.log -Force -Verbose
$usersAlreadyExist | out-file -FilePath $LogFolder\usersAlreadyExist.log -Force -Verbose
$successUsers | out-file -FilePath $LogFolder\successUsers.log -Force -Verbose

ealy · 2022-05-24T10:33:40.000Z

$Users=Import-csv c:\temp\user.csv
$failedUsers = @()
$successUsers = @()
$VerbosePreference = "Continue"
$LogFolder = "C:\temp"
ForEach($User in $Users)
{
  $Identity = $User.identity
  $PhoneNumber = $User.PhoneNumber

try {
    if (!(get-csonlineuser -identity $Identity))
    {
      Set-CsPhoneNumberAssignment -Identity $identity -PhoneNumber $PhoneNumber -PhoneNumberType DirectRouting
        Write-Verbose "[PASS] Phone number and Enterprise voice enabled for $Identity"
        $successUsers += $Identity
    }
    else {
        Write-Warning "[WARNING] No result found on [$($Identity)]"
        $usersAlreadyExist += $Identity
    }
}
catch {
    Write-Warning "[ERROR]Can't create user [$($Identity)] : $_"
    $failedUsers += $Identity
}
}
if ( !(test-path $LogFolder)) {
    Write-Verbose "Folder [$($LogFolder)] does not exist, creating"
    new-item $LogFolder -Force
}

Write-verbose "Writing logs"
$failedUsers | out-file -FilePath $LogFolder\FailedUsers.log -Force -Verbose
$usersAlreadyExist | out-file -FilePath $LogFolder\usersAlreadyExist.log -Force -Verbose
$successUsers | out-file -FilePath $LogFolder\successUsers.log -Force -Verbose

If you use the insert code block it makes your code easier to read in the post.

adminofthings · 2022-05-24T11:55:01.000Z

Can you provide some details as to what you want to accomplish? “Help [me]” is not very helpful.

Neally · 2022-05-24T13:08:58.000Z

spicehead-l4yn2:

We do too!
If you post code, please use the ‘Insert Code’ button. Please and thank you!

PLEASE READ BEFORE POSTING! Read if you're new to the PowerShell forum! Programming & Development

Hi, and welcome to the PowerShell forum! Don’t apologize for being a “noob” or “newbie” or “n00b.” There’s just no need – nobody will think you’re stupid, and the forums are all about asking questions. Just ask! Use a descriptive subject. Don’t say “Need help” or “PowerShell Help”, actually summarize what the problem is. It helps the rest of us keep track of which problem is which. Don’t post massive scripts. We’re all volunteers and we don’t have time to read all that, nor will we copy…

192033ab-bb8f-4032-88a5-8e2313af0344-codebutton_small.png

Neally · 2022-05-24T13:18:39.000Z

spicehead-l4yn2:

export the following to csv

What exactly do you want as CSV ? the error messages?

+= should get avoided with powershell - PowerShell’s plus equals (+=), the array serial killer | The PoSh Wolf

Look into lists instead.

untested but that’s the idea:

$Users             = Import-csv "c:\temp\user.csv"
$failedUsers       = [System.Collections.Generic.List[pscustomobject]]::new()
$successUsers      = [System.Collections.Generic.List[pscustomobject]]::new()
$usersAlreadyExist = [System.Collections.Generic.List[pscustomobject]]::new()
$VerbosePreference = "Continue"
$LogFolder         = "C:\temp"

ForEach ($User in $Users) {
    $Identity    = $User.identity
    $PhoneNumber = $User.PhoneNumber

    try {
        if ( -not(get-csonlineuser -identity $Identity)) {
            Set-CsPhoneNumberAssignment -Identity $identity -PhoneNumber $PhoneNumber -PhoneNumberType DirectRouting -erroraction stop
            Write-Verbose "[PASS] Phone number and Enterprise voice enabled for $Identity" -Verbose
            $successUsers.Add($Identity)
        }
        else {
            Write-Warning "[WARNING] No result found on [$($Identity)]"
            $usersAlreadyExist.add($Identity)
        }
    }
    catch {
        Write-Warning "[ERROR]Can't create user [$($Identity)] : $_"
        $failedUsers.add($Identity)
    }
}

if ( -not(test-path $LogFolder) ) {
    Write-Verbose "Folder [$($LogFolder)] does not exist, creating" -Verbose
    new-item $LogFolder -Force
}

Write-verbose "Writing logs" -Verbose
$failedUsers       | export-csv "$LogFolder\FailedUsers.csv"       -notypeinformation -Force -Verbose
$usersAlreadyExist | export-csv "$LogFolder\usersAlreadyExist.csv" -notypeinformation -Force -Verbose
$successUsers      | export-csv "$LogFolder\successUsers.csv"      -notypeinformation -Force -Verbose

now there is still more stuff off with it.

TRY/CATCH needs a terminating error (hence erroraction stop), the if statement in it might make things weird.

Maybe try it, and report back what you need changed or where exactly you are stuck.

iamtnerb · 2022-05-25T04:50:35.000Z

Thanks Neally and apologize if i didnt format the PS command well as its my first time posting here. Anyway you pointed me to the right direction and was able to get it right. Currently my script will export two csv file (Failed and Success). Im thinking of customizing the script so it could only use 1 csv file with the following result. I tried putting the result in one csv but only one is being captured.

UPN,Success/Failed

xxxx@domain.com, Success

xxxx@domain.com, Failed

Below is the script im currently using

$Users             = Import-csv "c:\temp\user.csv"
$failedUsers       = [System.Collections.Generic.List[pscustomobject]]::new()
$successUsers      = [System.Collections.Generic.List[pscustomobject]]::new()
$VerbosePreference = "Continue"
$LogFolder         = "C:\temp"

ForEach ($User in $Users) {
    $Identity    = $User.identity
    $PhoneNumber = $User.PhoneNumber

    try {
            Set-CsPhoneNumberAssignment -Identity $identity -PhoneNumber $PhoneNumber -PhoneNumberType DirectRouting -erroraction stop
            Write-Verbose "[Success] Phone number and Enterprise voice enabled for $Identity" -Verbose
            $successUsers.Add($Identity)
        }
    catch {
        Write-Warning "[Failed] User not found $Identity"
        $failedUsers.add($Identity)
    	  }
if ( -not(test-path $LogFolder) ) {
    Write-Verbose "Folder [$($LogFolder)] does not exist, creating" -Verbose
    new-item $LogFolder -Force
}
}

Write-verbose "Writing logs" -Verbose
$failedUsers | out-file -FilePath "$LogFolder\Users.csv" -Force
$successUsers | out-file -FilePath "$LogFolder\Userserror.csv" -Force

adminofthings · 2022-05-25T12:28:08.000Z

At the end, you can output using Export-Csv rather than Out-File. You can use calculated properties to create the UPN and Success/Failed properties with their corresponding values. Note that the second output to CSV uses -Append to not overwrite the first output.

$successUsers | Select @{n='UPN';e={$_}},@{n='Success/Failed';e={'Success'}} |
    Export-Csv c:\temp\output.csv -NoType
$FailedUsers | Select @{n='UPN';e={$_}},@{n='Success/Failed';e={'Failed'}} |
    Export-Csv c:\temp\output.csv -NoType -Append

iamtnerb · 2022-05-25T23:31:00.000Z

Thanks that did the trick