Where Are My Filenames Going?

s31064 · 2017-09-26T16:28:48.000Z

OK, this is either weird or I’m blind/doing something stupid. I’m creating an array of filenames using Get-ChildItem, and the array is being created, I’ve written it to the console to make sure; however, when I try to pull a file from the list using ForEach, the filename is blank. Is something wrong here, or am I as dumb as I’m starting to feel? I’ve been chasing this for over two days now. I know it’s a bit long, but I’m posting the entire script because I’m using inter-dependent functions.

Function Install-Downloads
{
  $script:MSIFiles = Get-ChildItem -Path $TargetDir -Name '*.msi' -File
  
  #Inserted for logging to make sure the array(s) are created.
  Write-HostLog "`n`rMSIFiles"
  $MSIFiles | Format-Table -AutoSize
 
  $script:EXEFiles = Get-ChildItem -Path $TargetDir -Name '*.exe' -File
  
  Write-HostLog "`n`r$EXEFiles"
  $ExeFiles | Format-Table -AutoSize

#Start processing downloads.
  Try
  {
    if ($MSIFiles = '')
    {
      Write-HostLog "`n`rNo MSI files downloaded.  Skipping...`n`r"
    }
    else
    {
      Write-HostLog "`n`rProcessing MSI files...`n`r"
      foreach ($File in $MSIFiles) 
      {
        $MSIArguments = @(
          '/i',
          "$File"
          '/qn',
          '/norestart'
        )
      
#This is the first sign something's wrong.  $File is blank.
        Write-HostLog "`n`rMSI = $File"
        Write-HostLog "`n`rProcessing $File ..."
        Start-Process -FilePath $env:systemroot\system32\msiexec.exe -ArgumentList $MSIArguments -PassThru -Verb runas -Wait
      }
    }
  }
  
  Catch
  {
    Write-HostLog "`n`rError processing file $File.  See $ErrorLogFullPath for details.`n`r"
    $Line = Write-Line
    Write-ErrorLog "`n`r$Line" -LogFile $ErrorLogFullPath
    $LineNumber = Get-CurrentLine
    Write-ErrorLog $LineNumber -LogFile $ErrorLogFullPath
    Write-ErrorLog "Exception Type: $($_.Exception.GetType().FullName)" -LogFile $ErrorLogFullPath
    Write-ErrorLog "Exception Message: $($_.Exception.Message)" -LogFile $ErrorLogFullPath
  }
      
  Finally
  {
    Write-HostLog "`n`rMSI installation is now complete!`n`r"
  }      
}

This is the transcript log file.

**********************
Host Application: C:\WINDOWS\system32\WindowsPowerShell\v1.0\PowerShell_ISE.exe
PSVersion: 5.1.14393.206
PSEdition: Desktop
PSCompatibleVersions: 1.0, 2.0, 3.0, 4.0, 5.0, 5.1.14393.206
BuildVersion: 10.0.14393.206
CLRVersion: 4.0.30319.42000
WSManStackVersion: 3.0
PSRemotingProtocolVersion: 2.3
SerializationVersion: 1.1.0.1
**********************
Transcript started, output file is C:\Logs\SpecialLogs\AR_Test9\\AR_Test9-Log_2017.09.26-14.15.30.log
...

MSIFiles
ExternalDiskCache_amd64_en-US.msi
requestRouter_amd64.msi
rewrite_amd64_en-US.msi
WebDeploy_amd64_cs-CZ.msi
WebFarm2_x64.msi
WebPlatformInstaller_amd64_en-US.msi

Processing MSI files...

MSI =

Processing  ...
PS C:\WINDOWS\system32> TerminatingError(Start-Process): "Cannot validate argument on parameter 'ArgumentList'. The argument is null or empty. Provide an argument that is not null or empty, and then try the command again."

Error processing file .  See C:\Logs\SpecialLogs\ARR_Test11\\ARR_Test11-ErrorLog_2017.09.26-14.50.31.log for details.

MSI installation is now complete!

There were errors encountered during script execution.  Please see C:\Logs\SpecialLogs\ARR_Test11\\ARR_Test11-ErrorLog_2017.09.26-14.50.31.log for details.
**********************

@martin9700 @thomaslee

Neally · 2017-09-26T16:33:40.000Z

Can you maybe please just post the few lines that you think are causing the issue?
I mean you just posted about 500 lines of code…

martin9700 · 2017-09-26T16:44:47.000Z

Agreed. Please cut all that out and take a gander at: PLEASE READ BEFORE POSTING! Read if you're new to the PowerShell forum!

s31064 · 2017-09-26T17:15:06.000Z

I guess that was a bit long. Seeing it online it looks a whole lot bigger than in my editor where I can compress regions.

I think the problem is somewhere in this function. The $MSIFiles array is getting created, but I can’t pull a file out of it to process with the ForEach loop.

Evan7191 · 2017-09-26T17:17:14.000Z

Look at line 402 (by my count) in the Try block. You have equal sign (=) for a condition statement instead of -eq. The equal sign assigns a value s instead of comparing values.

Try
  {
    if ($MSIFiles = '')
    {
      Write-HostLog "`n`rNo MSI files downloaded.  Skipping...`n`r"
    }
...

Instead, it should be something like this:

Try
  {
    if ($MSIFiles.Count -eq 0)
    {
      Write-HostLog "`n`rNo MSI files downloaded.  Skipping...`n`r"
    }

Neally · 2017-09-26T17:24:23.000Z

Right but that parts , I think, will cause it to automatically go in the else loop.

$MSIArguments = @(
          '/i',
          "$File"
          '/qn',
          '/norestart'
        )

Start-Process -FilePath $env:systemroot\system32\msiexec.exe -ArgumentList $MSIArguments -PassThru -Verb runas -Wait

And it says it can’t find the arguments?

Evan7191 · 2017-09-26T17:34:46.000Z

Neally:

Right but that parts , I think, will cause it to automatically go in the else loop.

No. The line if ($MSIFiles = ‘’) will reset the value of $MSIFiles to a blank string. I tested it.

s31064 · 2017-09-26T17:38:31.000Z

Right, it says “Cannot validate argument on parameter ‘ArgumentList’. The argument is null or empty. …”. I know the array isn’t empty because I can dump it to the console and all of the filenames are there. It doesn’t seem to be able to pull $File from $MSIFiles.

Neally · 2017-09-26T17:39:19.000Z

Yes, that’s for sure, I was jus wondering how if / else is evaluating it, if there is no real condition.

It looks like it jumps in the if condition, rather than the else condition. interesting.

if($test = 'somethingsilly'){
    write-output 'IF'
}else{
    write-output 'ELSE'
}

# output is IF

I’d have thought it would have jumped to else as there isn’t a condition in the IF, but no condition seem to be a true. ¯_(ツ)_/¯

Neally · 2017-09-26T17:41:06.000Z

It’s weird if it does not jump in the else loop, why does it try the ‘start-process’?

Evan7191 · 2017-09-26T17:41:40.000Z

Evan7191:

No. The line if ($MSIFiles = ‘’) will reset the value of $MSIFiles to a blank string. I tested it.

Here is what happens if you use the equals sign (=) in a condition statement:

PS> $MSIFiles = @("c:\test1.msi","c:\test2.msi")

PS> $MSIFiles
c:\test1.msi
c:\test2.msi

PS> If ($MSIFiles = '') {$True}

PS> $MSIFiles

PS> $MSIFiles.count
1

The value of the variable gets reset rather than compared.

Evan7191 · 2017-09-26T17:44:02.000Z

Neally:

It’s weird if it does not jump in the else loop, why does it try the ‘start-process’?

My best guess is because the If statement did not evaluate to $True, so Powershell automatically went to Else, because that’s how Else is designed to work. I rarely use If . . . Else, because it’s too easy to overlook a possibility that could lead to Else unintentionally. I prefer ElseIf or Switch.

Neally · 2017-09-26T17:47:11.000Z

Evan7191:

Right, but the issue seem if, it jumps in the if loop, but according to the transcript log it is runing the else loop as it is trying to start the process?

$test = @('stuff1','stuff2')

if($test = ''){
    write-output $test
    # this is where the IF jumps to
}else{
    write-output $test
    # but the error shows it's trying to run stuff here?
}

Evan7191 · 2017-09-26T17:48:48.000Z

s31064:

I know the array isn’t empty because I can dump it to the console and all of the filenames are there.

Is that before or after the If ($MSIFiles = ‘’) statement?

Evan7191 · 2017-09-26T17:51:33.000Z

Neally:

Evan7191:

Right, but the issue seem if, it jumps in the if loop, but according to the transcript log it is runing the else loop as it is trying to start the process?
$test = @('stuff1','stuff2')

if($test = ''){
    write-output $test
    # this is where the IF jumps to
}else{
    write-output $test
    # but the error shows it's trying to run stuff here?
}

The If statement does not resolve to $True, because there is not a proper condition to evaluate. When the If statement does not resolve to $True, Powershell will go to Else, when it exists.

Neally · 2017-09-26T17:54:23.000Z

I think I found it, you have no comma after $file

$MSIArguments = @(
          '/i',
          "$File"
          '/qn',
          '/norestart'
        )

Neally · 2017-09-26T17:56:23.000Z

Evan7191:

The If statement does not resolve to $True, because there is not a proper condition to evaluate. When the If statement does not resolve to $True, Powershell will go to Else, when it exists.

Ya , I think that’s what I said earlier

Where Are My Filenames Going? Programming & Development

Right but that parts , I think, will cause it to automatically go in the else loop. $MSIArguments = @( '/i', "$File" '/qn', '/norestart' ) Start-Process -FilePath $env:systemroot\system32\msiexec.exe -ArgumentList $MSIArguments -PassThru -Verb runas -Wait And it says it can’t find the arguments?

I was just confused as when I tested it I gave it a random value, rather than leaving it blank

Evan7191 · 2017-09-26T17:57:14.000Z

Neally:

I think I found it, you have no comma after $file
$MSIArguments = @(
          '/i',
          "$File"
          '/qn',
          '/norestart'
        )

Good catch. That should fix the error message about a null argument.

Neally · 2017-09-26T17:59:58.000Z

So technically we need 2 BAs, as without Evan’s finding the argument would always be blank, and without my finding the argument would always be invalid

s31064 · 2017-09-26T18:04:46.000Z

Evan7191:

Look at line 402 (by my count) in the Try block. You have equal sign (=) for a condition statement instead of -eq. The equal sign assigns a value s instead of comparing values.

AARRRGGGHHH!!! How did I not see that? I did the same thing last week in another script, but I found it in no time. It’s now able to pull the individual files. They’re not getting installed properly for some reason, but at least they’re being passed to the msiexec process.

MSI = requestRouter_amd64.msi

Processing requestRouter_amd64.msi ...

Id      : 3676
Handles : 22
CPU     : 0.015625
SI      : 2
Name    : msiexec

... etc.

At least now I can troubleshoot something other than why it’s not passing filenames. Thanks for the help guys.