Help with script

jcizek · 2017-06-13T21:21:41.000Z

I run the following script:

$reportFile = “c:\temp\report-serviceaccounts.html”

$ErrorActionPreference = “Stop”

$maxThreads = 10

$currentDomain = $env:USERDOMAIN.ToUpper()

$serviceAccounts = @{}

[string]$warnings = @()

$readServiceAccounts = {

scriptblock to retrieve service list from a remote machine

param( $hostname )

if ( Test-Connection -ComputerName $hostname -Count 3 -Quiet ){

try {

$serviceList = @( gwmi -Class Win32_Service -ComputerName $hostname -Property Name,StartName,SystemName -ErrorAction Stop )

$serviceList

}

catch{

“Failed to retrieve data from $hostname : $($_.toString())”

}

else{

“$hostname is unreachable”

}

} function processCompletedJobs(){

reads service list from completed jobs,

updates $serviceAccount table and removes completed job

$jobs = Get-Job -State Completed

foreach( $job in $jobs ) {

$data = Receive-Job $job

Remove-Job $job

if ( $data.GetType() -eq [Object] ){

$serviceList = $data | ? { $_.StartName.toUpper().StartsWith( $currentDomain )}

foreach( $service in $serviceList ){

$account = $service.StartName

$occurance = “"$($service.Name)” service on $($service.SystemName)"

if ( $script:serviceAccounts.Contains( $account ) ){ $script:serviceAccounts.Item($account) += $occurance

}

else {

$script:serviceAccounts.Add( $account, @( $occurance ) )

}

elseif ( $data.GetType() -eq [String] ) {

$script:warnings += $data

Write-warning $data

}

} ################# MAIN #########################

Import-Module ActiveDirectory

read computer accounts from current domain

Write-Progress -Activity “Retrieving server list from ActiveDirectory” -Status “Processing…” -PercentComplete 0

$serverList = Get-ADComputer -Filter {OperatingSystem -like “Windows Server*”} -Properties DNSHostName, cn | ? { $_.enabled }

start data retrieval job for each server in the list

use up to $maxThreads threads

$count_servers = 0

foreach( $server in $serverList ){

Start-Job -ScriptBlock $readServiceAccounts -Name “read_$($server.cn)” -ArgumentList $server.dnshostname | Out-Null

++$count_servers

Write-Progress -Activity “Retrieving data from servers” -Status “Processing…” -PercentComplete ( $count_servers * 100 / $serverList.Count )

while ( ( Get-Job -State Running).count -ge $maxThreads ) { Start-Sleep -Seconds 3 } processCompletedJobs }

process remaining jobs

Write-Progress -Activity “Retrieving data from servers” -Status “Waiting for background jobs to complete…” -PercentComplete 100

Wait-Job -State Running -Timeout 30 | Out-Null

Get-Job -State Running | Stop-Job

processCompletedJobs

prepare data table for report

Write-Progress -Activity “Generating report” -Status “Please wait…” -PercentComplete

0 $accountTable = @()

foreach( $serviceAccount in $serviceAccounts.Keys ) {

foreach( $occurance in $serviceAccounts.item($serviceAccount) ){

$row = new-object psobject

Add-Member -InputObject $row -MemberType NoteProperty -Name “Account” -Value $serviceAccount

Add-Member -InputObject $row -MemberType NoteProperty -Name “Usage” -Value $occurance

$accountTable += $row

}

create report

$report = "

Service account report for $currentDomain domain

$($serverList.count) servers processed. Discovered $($serviceAccounts.count) service accounts.

Discovered service accounts

$( $accountTable | Sort Account | ConvertTo-Html Account, Usage -Fragment )

Warning messages

$( $warnings | % { “

$_

” } )

"

Write-Progress -Activity “Generating report” -Status “Please wait…” -Completed

$report | Set-Content $reportFile -Force

Invoke-Expression $reportFile

And I am getting the following error:

Receive-Job : Cannot bind argument to parameter ‘Job’ because it is null.
At line:6 char:28

$data = Receive-Job <<<< $job
CategoryInfo : InvalidData: ( [Receive-Job], ParentContainsErrorRecordException
FullyQualifiedErrorId : ParameterArgumentValidationErrorNullNotAllowed,Microsoft.PowerShell.Commands.ReceiveJobCommand

Little-Green-Man · 2017-06-13T21:25:37.000Z

PLEASE READ BEFORE POSTING! Read if you're new to the PowerShell forum! Programming & Development

Hi, and welcome to the PowerShell forum! Don’t apologize for being a “noob” or “newbie” or “n00b.” There’s just no need – nobody will think you’re stupid, and the forums are all about asking questions. Just ask! Use a descriptive subject. Don’t say “Need help” or “PowerShell Help”, actually summarize what the problem is. It helps the rest of us keep track of which problem is which. Don’t post massive scripts. We’re all volunteers and we don’t have time to read all that, nor will we copy…

rogerberrisford · 2017-06-14T08:57:31.000Z

It is complaining that $job is Null

and since you got

foreach( $job in $jobs)

$jobs is probably Null too

Reckon you need to figure if/why the get-job command

$jobs = Get-Job -State Completed

is not returning anything

jcizek · 2017-06-14T14:37:13.000Z

I do apologize for entering the entire script. I am not very good at scripting yet and am not sure where to look in the script for the error. It is for this reason that I posted the entire thing.

Little-Green-Man · 2017-06-14T15:16:10.000Z

That’s the problem with grabbing other peoples crap code from the interwebz, especially if you aren’t good at scripting. You learn by rolling your own PowerShell code.

Can you describe what task you are trying to accomplish instead? Maybe we can discuss a better way?

jcizek · 2017-06-14T15:45:03.000Z

Thank you for the reply. My goal is to get a list of all AD user accounts that are being used for “Logon As” to run services throughout the domain. I am hoping to get a list that looks something like this:

domain\user server a

server b

server c

domain\user2 server b

server c

server d

etc…etc

Let me know if you need any further information. Thank you for all your help.

gungnir · 2017-06-14T16:03:08.000Z

jcizek:

And I am getting the following error:

Receive-Job : Cannot bind argument to parameter ‘Job’ because it is null.
At line:6 char:28

$data = Receive-Job <<<< $job

CategoryInfo : InvalidData: ( [Receive-Job], ParentContainsErrorRecordException

FullyQualifiedErrorId : ParameterArgumentValidationErrorNullNotAllowed,Microsoft.PowerShell.Commands.ReceiveJobCommand

As Roger pointed out, the source of this error is the Get-Job line. With how you’re calling the processCompletedJobs function, there’s no guarantee that there will be new completed jobs on each pass. One choice to resolve this would be to remove the processCompletedJobs call from the foreach loop and only make the one call you have afterward. Another choice would be to wrap the foreach loop inside the function with an if statement to check if $jobs contains anything.

function processCompletedJobs{
    $jobs = Get-Job -State Completed     

    if( $jobs ){
        foreach( $job in $jobs ) {
            }
        }
    }

Also, as an aside, please use the insert code button ( </> ) and select the PowerShell language when posting PowerShell scripts to the community. It makes your post easier to read and adds some syntax highlighting.

Service account report for $currentDomain domain<\/h1>\n
$($serverList.count) servers processed. Discovered $($serviceAccounts.count) service accounts.<\/p>\n

Discovered service accounts<\/h2>\n
$( $accountTable | Sort Account | ConvertTo-Html Account, Usage -Fragment )<\/p>\n

Service account report for $currentDomain domain<\/h1>\n
$($serverList.count) servers processed. Discovered $($serviceAccounts.count) service accounts.<\/p>\n

Discovered service accounts<\/h2>\n
$( $accountTable | Sort Account | ConvertTo-Html Account, Usage -Fragment )<\/p>\n

Service account report for $currentDomain domain<\/h1>\n$($serverList.count) servers processed. Discovered $($serviceAccounts.count) service accounts.<\/p>\n

Discovered service accounts<\/h2>\n$( $accountTable | Sort Account | ConvertTo-Html Account, Usage -Fragment )<\/p>\n

Service account report for $currentDomain domain<\/h1>\n$($serverList.count) servers processed. Discovered $($serviceAccounts.count) service accounts.<\/p>\n

Discovered service accounts<\/h2>\n$( $accountTable | Sort Account | ConvertTo-Html Account, Usage -Fragment )<\/p>\n

Service account report for $currentDomain domain<\/h1>\n
$($serverList.count) servers processed. Discovered $($serviceAccounts.count) service accounts.<\/p>\n

Discovered service accounts<\/h2>\n
$( $accountTable | Sort Account | ConvertTo-Html Account, Usage -Fragment )<\/p>\n

Service account report for $currentDomain domain<\/h1>\n
$($serverList.count) servers processed. Discovered $($serviceAccounts.count) service accounts.<\/p>\n

Discovered service accounts<\/h2>\n
$( $accountTable | Sort Account | ConvertTo-Html Account, Usage -Fragment )<\/p>\n