Skip to content

Conversation

@tarunramsinghani
Copy link
Collaborator

Context

Describe the context or motivation for this PR. Include links to any related Azure DevOps Work Items or GitHub issues.
📌 How to link to ADO Work Items

Depends on dotnet/sdk#50673


Task Name

DotNetCoreCLI


Description

In past, we added support for dotnet.config (this was shipped during .NET 10 previews, and will be shipped in RC1 as well).

However, starting from RC2 (if the dotnet/sdk PR above is merged), we will be dropping dotnet.config completely, and switching to global.json. This PR updates the DotNetCoreCLI task to read global.json instead of dotnet.config.


Risk Assessment (Low / Medium / High)

Low. This is a .NET 10 feature that didn't yet ship in GA and has very low number of users.


Change Behind Feature Flag (Yes / No)

Can this change be behind feature flag, if not why?

There is already a feature flag in this code path.


Tech Design / Approach

Instead of parsing dotnet.config as TOML, we parse now global.json.


Documentation Changes Required (Yes/No)

Indicate whether related documentation needs to be updated.

  • User guides, API specs, system diagrams, or runbooks are updated.

Unit Tests Added or Updated (Yes / No)

Indicate whether unit tests were added or modified to reflect these changes.

Tested manually.


Additional Testing Performed

List all other tests performed (manual or automated, including integration, regression, scenario tests, etc.).

Tested manually.


Logging Added/Updated (Yes/No)

Debug logging is added.


Telemetry Added/Updated (Yes/No)

No


Rollback Scenario and Process (Yes/No)

No


Dependency Impact Assessed and Regression Tested (Yes/No)

  • All impacted internal modules, APIs, services, and third-party libraries are analyzed.
  • Results are reviewed and confirmed to not break existing functionality.

Checklist

  • Related issue linked (if applicable)
  • Task version was bumped — see versioning guide
  • Verified the task behaves as expected

@tarunramsinghani tarunramsinghani requested review from a team and DergachevE as code owners September 11, 2025 06:44
@tarunramsinghani tarunramsinghani mentioned this pull request Sep 11, 2025
3 tasks
@tarunramsinghani
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@tarunramsinghani
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@tarunramsinghani
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@tarunramsinghani tarunramsinghani enabled auto-merge (squash) September 12, 2025 10:17
@tarunramsinghani tarunramsinghani merged commit 74e085d into master Sep 12, 2025
11 checks passed
@tarunramsinghani tarunramsinghani deleted the mtp-detection branch September 12, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants