fix(aster): Messages dropped in Aster private WS methods #27821
Merged
+27
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: When two WebSocket messages arrive in quick succession, the second message is lost entirely. Root Cause: In handleOrder and handlePositions, the code checks findMessageHashes() to see if there's an active subscriber before adding data to the cache. When client.resolve() is called, it deletes the future from client.futures. If a second message arrives before the caller can re-invoke watchOrders(), findMessageHashes() returns empty and the entire handler body is skipped—the order/position is never added to the cache. The Fix: Always add incoming data to the cache first, then check for subscribers only when deciding whether to call client.resolve().
colin-nl
requested review from
carlosmiei,
frosty00 and
kroitor
as code owners
Member
|
Thx for the PR @colin-nl ! We will run some tests and will merge it asap.
On handleBalance – i think this is due to the nature of the stream (it's the same messageHash for all watchers), as for the handleMyTrade – we will take a deeper look into it and will revert to you on this. |
Collaborator
|
@colin-nl Running this code a few times we can see it ocasionally (using master version), will check using your PR async def watch_orders():
while True:
orders = await exchange.watch_orders(params = {'type':'swap'})
for order in orders:
print('WatchOrders:', order['id'], order['status'], order['symbol'], order['filled'], order['remaining'])
async def place_order(symbol, type, side, amount, price = None):
order = await exchange.create_order(symbol, type, side, amount, price)
print("Placed order:", order['id'], order['status'], order['symbol'], order['filled'], order['remaining'])
return order
async def cancel_order(order_id, symbol):
result = await exchange.cancel_order(order_id, symbol)
print("Cancelled order:", result['id'], result['status'])
return result
async def example_1():
markets = await exchange.load_markets()
watch_task = asyncio.create_task(watch_orders())
await asyncio.sleep(5)
order1 = place_order('ADA/USDT:USDT', 'limit', 'buy', 20, 0.3)
order2 = place_order('ASTER/USDT:USDT', 'limit', 'buy', 20, 0.544)
res = await asyncio.gather(order1, order2)
await asyncio.sleep(5)
cancel1 = cancel_order(res[0]['id'], res[0]['symbol'])
cancel2 = cancel_order(res[1]['id'], res[1]['symbol'])
await asyncio.gather(cancel1, cancel2)
await asyncio.sleep(10)
await watch_task |
Collaborator
|
@colin-nl And yeah |
Collaborator
|
Log with the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Issue #27804
Problem: When two WebSocket messages arrive in quick succession, the second message is lost entirely.
Root Cause: In
handleOrderandhandlePositions, the code checksfindMessageHashesto see if there's an active subscriber before adding data to the cache. Whenclient.resolve()is called, it deletes the future from client.futures. If a second message arrives before the caller can re-invokewatchOrders,findMessageHashesreturns empty and the entire handler body is skipped. The order/position is never added to the cache.The Fix: Always add incoming data to the cache first, then check for subscribers only when deciding whether to call
client.resolve().Questions/Discussion: I noticed that
handleBalanceandhandleMyTradedon't callfindMessageHasheslikehandleOrderandhandlePositionsdo. There may be some context that I'm missing that could make this PR more correct.