Fixes #90125 - Add a task instancePolicy to task runOptions #117129

alpalla · 2021-02-20T12:56:24Z

Fixes #90125.
This pull request replaces the old one I opened (#90914) for the same issue almost a year ago.

Summary

Added an instancePolicy to runOptions. The instancePolicy is applied when creating a new instance of a task once the instanceLimit has been reached.

There are five options for instancePolicy:

terminateNewest: the newest instance is terminated
terminateOldest: the oldest instance is terminated
prompt: the QuickPick is shown and the user picks an instance to restart
warn: do nothing (do not terminate an existing instance or create a new one) and show a warning that indicates that the instanceLimit has been reached
silent: do nothing

prompt is the default option.

Testing changes

Create a tasks.json and set the instancLimit and instancePolicy properties. Here is an example configuration:

{
    "version": "2.0.0",
    "tasks": [
        {
            "label": "echo",
            "type": "shell",
            "command": "date && sleep 300",
            "runOptions": {
                "instanceLimit": 2,
                "instancePolicy": "terminateOldest"
            }
        }
    ]
}

Ensure that once the instanceLimit is reached, the chosen instancePolicy behaves as intended.

@alexr00 to get things working I had to revert some changes you made for Fix unlimited instances of recent tasks bug.
In particular here and here.
I just want to be sure there are no regressions.

creating a new instance of a task, once the instanceLimit has been reached.

alexr00 · 2021-02-22T13:02:11Z

Thanks for the updated PR! I will try to take a look in March.

blooop · 2021-07-14T09:04:55Z

I am interested in this feature, as the current task system require more manual clicking (to restart) that just using the terminal.

alexr00

Thanks for the PR! In May of 2020 I made some changes to task instance to fix some related bugs, but it looks like this updated PR doesn't take those changes into account.

src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts

src/vs/workbench/contrib/tasks/browser/terminalTaskSystem.ts

alpalla · 2021-09-03T16:00:27Z

@alexr00 ping 🙂

MikolajKolek · 2021-11-24T11:10:49Z

Hello, I'm sorry if I'm being annoying, but this has been waiting to be reviewed for over the last 4 months with completely no progress. This feature seems really quite useful, so I'd appreciate someone at least looking at this

victorvianna · 2022-03-03T18:17:18Z

@alexr00 Is this PR on the right path? If someone finds time to rebase it, will it be LGTM-ed?

dn54321 · 2022-12-19T05:23:54Z

Any updates to this ticket?

meganrogge · 2023-01-06T16:48:21Z

There are some conflicts - I will try to make time to review it if those get fixed

Imran-imtiaz48

The code revisions refine the logic for selecting instances to terminate by directly comparing task IDs instead of common prefixes. The updated code simplifies the filtering process to match tasks based on their exact IDs rather than a shared prefix, which enhances accuracy in identifying the correct instance. This change eliminates potential mismatches caused by common ID prefixes and ensures that users are prompted to select the exact instance they intend to terminate, improving both precision and user experience.

meganrogge · 2024-07-29T15:44:30Z

src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts

-				} else {
-					this._taskSystem?.revealTask(executeResult.task);
-				}
+				this.handleInstancePolicy(executeResult.task, executeResult.task.runOptions!.instancePolicy);


we are now missing this check for task visibility this._taskSystem?.isTaskVisible(executeResult.task). If a task is not visible, I don't think it'll be revealed with this change?

vivodi · 2024-12-29T16:35:08Z

Is this still relevant?

dimateos · 2025-01-09T13:46:56Z

IMO #90125 is still relevant: avoid having to manually terminate tasks... or the workaround to terminate ALL tasks

This PR seems to be the most recent one referencing the issue.

y2kbugger · 2025-01-27T17:28:12Z

Also here from #90125 Would be really nice for any task that doesn't have it's own filewatcher built in

meganrogge · 2025-05-12T14:55:27Z

The conflicts are pretty confusing, @alpalla , would you consider creating a new branch based on main with your changes? If not, I might do so and just add you as a co-author.

…ish/tweak. Co-authored-by: alpalla <[email protected]>

Bring changes from #117129 to new branch to avoid conflicts. Also polish/tweak. Co-authored-by: alpalla <[email protected]>

meganrogge · 2025-05-16T17:11:29Z

Closing in favor of #248747, but will be sure you are credited with this work in the release notes @alpalla! Thanks so much!

alpalla · 2025-06-12T14:32:25Z

The conflicts are pretty confusing, @alpalla , would you consider creating a new branch based on main with your changes? If not, I might do so and just add you as a co-author.

@meganrogge sorry I didn't see your comment, thank you so much for taking care of this 🙏🏻

Added an instancePolicy to be applied when

f370091

creating a new instance of a task, once the instanceLimit has been reached.

vscode-triage-bot assigned alexr00 Feb 20, 2021

alexr00 added this to the March 2021 milestone Feb 22, 2021

alexr00 mentioned this pull request Feb 22, 2021

Fixes #90125 - Add a task instancePolicy to task runOptions #90914

Closed

alexr00 modified the milestones: March 2021, April 2021 Mar 24, 2021

alexdima modified the milestones: April 2021, May 2021 Apr 30, 2021

alexr00 modified the milestones: May 2021, June 2021 Jun 2, 2021

alexr00 modified the milestones: June 2021, July 2021 Jun 29, 2021

alexr00 added 2 commits July 16, 2021 14:48

Merge remote-tracking branch 'origin/main' into pr/alpalla/117129

c46910d

Merge remote-tracking branch 'origin/main' into pr/alpalla/117129

e902c1e

alexr00 requested changes Jul 16, 2021

View reviewed changes

src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts Outdated Show resolved Hide resolved

src/vs/workbench/contrib/tasks/browser/terminalTaskSystem.ts Outdated Show resolved Hide resolved

alexr00 removed this from the July 2021 milestone Jul 16, 2021

Avoid splitting task._id with "|" and keep task._id readonly

3729c53

alpalla requested a review from alexr00 August 7, 2021 10:44

alexr00 assigned meganrogge and unassigned alexr00 Dec 19, 2022

Imran-imtiaz48 reviewed Jul 22, 2024

View reviewed changes

meganrogge added this to the August 2024 milestone Jul 23, 2024

meganrogge reviewed Jul 29, 2024

View reviewed changes

meganrogge removed this from the August 2024 milestone Aug 2, 2024

meganrogge added this to the May 2025 milestone May 12, 2025

meganrogge added a commit that referenced this pull request May 12, 2025

Bring changes from #117129 to new branch to avoid conflicts. Also pol…

61f53ef

…ish/tweak. Co-authored-by: alpalla <[email protected]>

meganrogge added a commit that referenced this pull request May 12, 2025

Bring changes from #117129 to new branch to avoid conflicts. Also pol…

175c949

…ish/tweak. Co-authored-by: alpalla <[email protected]>

meganrogge mentioned this pull request May 12, 2025

Add runOptions.instancePolicy for tasks #248747

Merged

meganrogge added a commit that referenced this pull request May 12, 2025

Add runOptions.instancePolicy for tasks (#248747)

712f0ad

Bring changes from #117129 to new branch to avoid conflicts. Also polish/tweak. Co-authored-by: alpalla <[email protected]>

meganrogge closed this May 16, 2025

vs-code-engineering bot locked and limited conversation to collaborators Jun 30, 2025

Fixes #90125 - Add a task instancePolicy to task runOptions #117129

Fixes #90125 - Add a task instancePolicy to task runOptions #117129

Uh oh!

Conversation

alpalla commented Feb 20, 2021

Summary

Testing changes

Uh oh!

alexr00 commented Feb 22, 2021

Uh oh!

blooop commented Jul 14, 2021

Uh oh!

alexr00 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

alpalla commented Sep 3, 2021

Uh oh!

MikolajKolek commented Nov 24, 2021

Uh oh!

victorvianna commented Mar 3, 2022

Uh oh!

dn54321 commented Dec 19, 2022

Uh oh!

meganrogge commented Jan 6, 2023

Uh oh!

Imran-imtiaz48 left a comment

Choose a reason for hiding this comment

Uh oh!

meganrogge Jul 29, 2024

Choose a reason for hiding this comment

Uh oh!

vivodi commented Dec 29, 2024

Uh oh!

dimateos commented Jan 9, 2025

Uh oh!

y2kbugger commented Jan 27, 2025

Uh oh!

meganrogge commented May 12, 2025

Uh oh!

meganrogge commented May 16, 2025

Uh oh!

alpalla commented Jun 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants