Replace hardcoded inlay hints limit with config option (#265980) #291802
+19
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces the hardcoded inlay hints limit of 1500 with a configurable option editor.inlayHints.maxHintsCount to address issue #265980. This allows extensions like Rainbow CSV that generate many inlay hints (for virtual column alignment) to configure a higher or unlimited limit.
Changes:
- Added configurable
maxHintsCountoption toeditor.inlayHintswith a default value of 1500 (matching the previous hardcoded limit) - Removed the hardcoded
_MAX_DECORATORSconstant from InlayHintsController - Setting
maxHintsCountto 0 enables unlimited inlay hints
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/monaco.d.ts | Added maxHintsCount property to the IEditorInlayHintsOptions interface for Monaco editor API |
| src/vs/editor/common/config/editorOptions.ts | Defined the maxHintsCount configuration option with default value of 1500, validation, and localized description |
| src/vs/editor/contrib/inlayHints/browser/inlayHintsController.ts | Removed hardcoded _MAX_DECORATORS constant and replaced with dynamic retrieval of maxHintsCount from editor options |
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #265980
The change allows to configure max inlay hints limit.
It is not typical for regular languages to set that many inlay hints but Rainbow CSV extension can generate so many inlay hints in "virtual align" mode.
In order to test the change, the following can be done:
editor.inlayHints.maxHintsCountto 500 in settings.editor.inlayHints.maxHintsCountto 0 or a very large valueHere are some demo screenshots: