Hardcode commonly used settings and remove productService dependency #291987

Copilot · 2026-01-30T22:07:23Z

Moves commonly used settings list from productService.commonlyUsedSettings to a hardcoded constant COMMONLY_USED_SETTINGS, adding GitHub.copilot.manageExtension to the list in the contrib layer.

Changes

New constant: COMMONLY_USED_SETTINGS in contrib/preferences/common/preferences.ts as a readonly array to prevent accidental mutations:

export const COMMONLY_USED_SETTINGS: readonly string[] = [
  'editor.fontSize',
  'editor.formatOnSave',
  'files.autoSave',
  'GitHub.copilot.manageExtension',  // Added
  'editor.defaultFormatter',
  'editor.fontFamily',
  'editor.wordWrap',
  'chat.agent.maxRequests',
  'files.exclude',
  'workbench.colorTheme',
  'editor.tabSize',
  'editor.mouseWheelZoom',
  'editor.formatOnPaste'
];

Removed productService dependency: getExperimentalExtensionToggleData now checks only productService.extensionRecommendations (removed && productService.commonlyUsedSettings condition)
Updated files:
- settingsLayout.ts: Uses COMMONLY_USED_SETTINGS directly as default parameter with readonly type (removed defaultCommonlyUsedSettings variable)
- preferences.ts: getExperimentalExtensionToggleData uses COMMONLY_USED_SETTINGS directly; ExtensionToggleData.commonlyUsed typed as readonly string[]
- preferencesService.ts: Updated getMostCommonlyUsedSettings() method with a similar list (excludes GitHub.copilot.manageExtension to maintain proper layering between services and contrib)
Type Safety: Made COMMONLY_USED_SETTINGS readonly to prevent accidental mutations that could affect all consumers. Updated all type signatures to use readonly string[] for consistency.

This ensures consistency across the codebase with COMMONLY_USED_SETTINGS as the single source of truth for the contrib layer, while maintaining the existing architecture and proper layering between services and contrib layers.

Original prompt

Change commonly used settings to the following value and don't call productService anymore for it
"commonlyUsedSettings": [
"editor.fontSize",
"editor.formatOnSave",
"files.autoSave",
"GitHub.copilot.manageExtension",
"editor.defaultFormatter",
"editor.fontFamily",
"editor.wordWrap",
"chat.agent.maxRequests",
"files.exclude",
"workbench.colorTheme",
"editor.tabSize",
"editor.mouseWheelZoom",
"editor.formatOnPaste"
]

Created from VS Code.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: rzhao271 <[email protected]>

src/vs/workbench/contrib/preferences/browser/settingsLayout.ts

…ectly Co-authored-by: rzhao271 <[email protected]>

rzhao271 · 2026-01-30T22:54:08Z

@copilot update src/vs/workbench/services/preferences/browser/preferencesService.ts to also reference new COMMONLY_USED_SETTINGS.

Co-authored-by: rzhao271 <[email protected]>

Copilot · 2026-01-30T22:58:15Z

@copilot update src/vs/workbench/services/preferences/browser/preferencesService.ts to also reference new COMMONLY_USED_SETTINGS.

Done in c3e493e. Updated getMostCommonlyUsedSettings() to return COMMONLY_USED_SETTINGS constant instead of maintaining a separate hardcoded list.

rzhao271 · 2026-01-30T23:04:05Z

@copilot remove getMostCommonlyUsedSettings function and just use the constant

…TINGS directly Co-authored-by: rzhao271 <[email protected]>

Copilot · 2026-01-30T23:07:08Z

@copilot remove getMostCommonlyUsedSettings function and just use the constant

Done in e495b95. Removed the function and replaced all three calls with COMMONLY_USED_SETTINGS directly.

rzhao271 · 2026-01-30T23:37:42Z

@copilot undo the changes in src/vs/workbench/services/preferences/browser/preferencesService.ts but then update the hardcoded list to match the existing one.

Copilot

Pull request overview

This PR centralizes the “commonly used settings” list into a single hardcoded constant and removes reliance on productService.commonlyUsedSettings, including adding GitHub.copilot.manageExtension to the list.

Changes:

Introduced a shared COMMONLY_USED_SETTINGS constant and switched callers to use it.
Updated getExperimentalExtensionToggleData to no longer depend on productService.commonlyUsedSettings.
Removed the duplicated “most commonly used settings” list from PreferencesService.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
src/vs/workbench/services/preferences/browser/preferencesService.ts	Replaces the local “most commonly used” list with the shared constant (but introduces a services → contrib import).
src/vs/workbench/contrib/preferences/common/preferences.ts	Adds `COMMONLY_USED_SETTINGS` and returns it from `getExperimentalExtensionToggleData` instead of reading from `productService`.
src/vs/workbench/contrib/preferences/browser/settingsLayout.ts	Removes the local default list and uses `COMMONLY_USED_SETTINGS` as the default for the “Commonly Used” TOC section.

src/vs/workbench/services/preferences/browser/preferencesService.ts

Copilot · 2026-01-30T23:39:51Z

src/vs/workbench/contrib/preferences/common/preferences.ts

+export const COMMONLY_USED_SETTINGS: string[] = [
+	'editor.fontSize',
+	'editor.formatOnSave',
+	'files.autoSave',
+	'GitHub.copilot.manageExtension',
+	'editor.defaultFormatter',


COMMONLY_USED_SETTINGS is exported as a mutable string[] and is returned (and cached) by getExperimentalExtensionToggleData. Since callers receive the same array reference, accidental mutation would affect all subsequent consumers. Consider typing it as readonly string[]/ReadonlyArray<string> and/or returning a defensive copy when exposing it on ExtensionToggleData.

@copilot apply changes based on this feedback

Done in c001c58. Changed COMMONLY_USED_SETTINGS to readonly string[] and updated ExtensionToggleData.commonlyUsed and function parameters to use readonly string[] to prevent accidental mutations.

…ch COMMONLY_USED_SETTINGS Co-authored-by: rzhao271 <[email protected]>

Copilot · 2026-01-30T23:41:18Z

@copilot undo the changes in src/vs/workbench/services/preferences/browser/preferencesService.ts but then update the hardcoded list to match the existing one.

Done in 9ba80e3. Reverted preferencesService.ts to keep the getMostCommonlyUsedSettings() function, but updated the hardcoded list to match COMMONLY_USED_SETTINGS.

Co-authored-by: rzhao271 <[email protected]>

rzhao271 · 2026-01-30T23:50:34Z

src/vs/workbench/services/preferences/browser/preferencesService.ts

 			'editor.fontSize',
+			'editor.formatOnSave',
+			'files.autoSave',
+			'GitHub.copilot.manageExtension',


@copilot remove this setting from this list

Done in daf357c. Removed GitHub.copilot.manageExtension from the getMostCommonlyUsedSettings() list in preferencesService.ts.

Co-authored-by: rzhao271 <[email protected]>

rzhao271 · 2026-01-31T00:46:23Z

To-do before merge: test in OSS

Initial plan

3a72ece

Copilot AI assigned Copilot and rzhao271 Jan 30, 2026

Copilot started work on behalf of rzhao271 January 30, 2026 22:07 View session

Copilot AI and others added 3 commits January 30, 2026 22:11

Update commonly used settings and remove productService dependency

f3cba8a

Co-authored-by: rzhao271 <[email protected]>

Extract COMMONLY_USED_SETTINGS constant to avoid code duplication

d137cef

Co-authored-by: rzhao271 <[email protected]>

Remove unnecessary intermediate variable

ec29d1a

Co-authored-by: rzhao271 <[email protected]>

Copilot AI changed the title ~~[WIP] Change commonly used settings values without calling productService~~ Hardcode commonly used settings and remove productService dependency Jan 30, 2026

Copilot AI requested a review from rzhao271 January 30, 2026 22:16

Copilot finished work on behalf of rzhao271 January 30, 2026 22:16

rzhao271 reviewed Jan 30, 2026

View reviewed changes

src/vs/workbench/contrib/preferences/browser/settingsLayout.ts Outdated Show resolved Hide resolved

Copilot started work on behalf of rzhao271 January 30, 2026 22:50 View session

Remove defaultCommonlyUsedSettings and use COMMONLY_USED_SETTINGS dir…

92166ce

…ectly Co-authored-by: rzhao271 <[email protected]>

Copilot AI requested a review from rzhao271 January 30, 2026 22:53

Copilot finished work on behalf of rzhao271 January 30, 2026 22:53

Copilot started work on behalf of rzhao271 January 30, 2026 22:54 View session

Update preferencesService.ts to use COMMONLY_USED_SETTINGS constant

c3e493e

Co-authored-by: rzhao271 <[email protected]>

Copilot finished work on behalf of rzhao271 January 30, 2026 22:59

Copilot started work on behalf of rzhao271 January 30, 2026 23:04 View session

Remove getMostCommonlyUsedSettings function and use COMMONLY_USED_SET…

e495b95

…TINGS directly Co-authored-by: rzhao271 <[email protected]>

Copilot finished work on behalf of rzhao271 January 30, 2026 23:08

rzhao271 approved these changes Jan 30, 2026

View reviewed changes

rzhao271 marked this pull request as ready for review January 30, 2026 23:29

Copilot AI review requested due to automatic review settings January 30, 2026 23:29

Copilot started reviewing on behalf of rzhao271 January 30, 2026 23:30 View session

vs-code-engineering bot added this to the February 2026 milestone Jan 30, 2026

Copilot started work on behalf of rzhao271 January 30, 2026 23:38 View session

Copilot AI reviewed Jan 30, 2026

View reviewed changes

Revert preferencesService.ts changes but update hardcoded list to mat…

9ba80e3

…ch COMMONLY_USED_SETTINGS Co-authored-by: rzhao271 <[email protected]>

Copilot AI requested a review from rzhao271 January 30, 2026 23:42

Copilot finished work on behalf of rzhao271 January 30, 2026 23:42

Copilot started work on behalf of rzhao271 January 30, 2026 23:45 View session

Make COMMONLY_USED_SETTINGS readonly to prevent accidental mutations

c001c58

Co-authored-by: rzhao271 <[email protected]>

Copilot finished work on behalf of rzhao271 January 30, 2026 23:49

rzhao271 mentioned this pull request Jan 30, 2026

Add 'chat.agent.maxRequests' to commonly used settings #291779

Draft

rzhao271 reviewed Jan 30, 2026

View reviewed changes

Copilot started work on behalf of rzhao271 January 30, 2026 23:51 View session

Remove GitHub.copilot.manageExtension from preferencesService list

daf357c

Co-authored-by: rzhao271 <[email protected]>

Copilot AI requested a review from rzhao271 January 30, 2026 23:54

Copilot finished work on behalf of rzhao271 January 30, 2026 23:54

rzhao271 approved these changes Jan 31, 2026

View reviewed changes

Hardcode commonly used settings and remove productService dependency #291987

Are you sure you want to change the base?

Hardcode commonly used settings and remove productService dependency #291987

Conversation

Copilot AI commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

Uh oh!

rzhao271 commented Jan 30, 2026

Uh oh!

Copilot AI commented Jan 30, 2026

Uh oh!

rzhao271 commented Jan 30, 2026

Uh oh!

Copilot AI commented Jan 30, 2026

Uh oh!

rzhao271 commented Jan 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

rzhao271 Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jan 30, 2026

Uh oh!

rzhao271 Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

rzhao271 commented Jan 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Jan 30, 2026 •

edited

Loading