feat: support deployment under a sub-path #1289
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Owner
|
@KevenLi8888 thanks for this, and apologies for the delay! Looks good - I'll give it a test when I get a chance, but I see no reason why this can't be merged 👍 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1289 +/- ##
===========================================
- Coverage 83.19% 83.15% -0.05%
===========================================
Files 197 197
Lines 1982 1983 +1
Branches 465 466 +1
===========================================
Hits 1649 1649
- Misses 325 326 +1
Partials 8 8 ☔ View full report in Codecov by Sentry. |
Owner
|
@KevenLi8888 if I try the docker-compose instructions, I get an error: export NEXT_PUBLIC_BASE_PATH="/string-is"
docker-compose up --build
validating /Users/dave/Documents/Code/string-is/docker-compose.yml: services.string-is.build.args.0 must be a stringI'm a bit of a docker-compose noob - can we make that arg optional ? |
Contributor
Author
|
@recurser Thank you for pointing that out! I've added a default blank value for this environment variable and tested it locally. Could you please double-check and see if the problem resolved? Thanks! |
recurser
pushed a commit
that referenced
this pull request
Jan 3, 2024
recurser
pushed a commit
that referenced
this pull request
Jan 3, 2024
Owner
|
@KevenLi8888 thanks for this! 🙏 I've rebased and merged it but for some reason it didn't close the PR - closing. |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 3, 2024
## [1.36.0](v1.35.4...v1.36.0) (2024-01-03) ### Features * [[#1289](#1289)] support for deployment under a sub-path ([51d61e7](51d61e7)) ### Bug Fixes * [[#1142](#1142)] resolve prettier type versions ([af7176a](af7176a)) * [[#1308](#1308)] fix jest setup after upgrade ([05ece6c](05ece6c)) * [[#1313](#1313)] fix flakey time tests ([804bb42](804bb42)) ### Dependencies * bump @compiled/react from 0.16.2 to 0.16.8 ([50d0dc4](50d0dc4)) * bump chrono-node from 2.7.0 to 2.7.4 ([14cd632](14cd632)) * bump prettier and @types/prettier ([15feef5](15feef5)) * bump terser from 5.24.0 to 5.26.0 ([48da8fc](48da8fc))
github-actions bot
pushed a commit
that referenced
this pull request
Jan 3, 2024
## [1.36.0](v1.35.4...v1.36.0) (2024-01-03) ### Features * [[#1289](#1289)] support for deployment under a sub-path ([51d61e7](51d61e7)) ### Bug Fixes * [[#1142](#1142)] resolve prettier type versions ([af7176a](af7176a)) * [[#1308](#1308)] fix jest setup after upgrade ([05ece6c](05ece6c)) * [[#1313](#1313)] fix flakey time tests ([804bb42](804bb42)) * add missing packages ([d36a6e9](d36a6e9)) ### Dependencies * bump @compiled/react from 0.16.2 to 0.16.8 ([50d0dc4](50d0dc4)) * bump chrono-node from 2.7.0 to 2.7.4 ([14cd632](14cd632)) * bump prettier and @types/prettier ([15feef5](15feef5)) * bump terser from 5.24.0 to 5.26.0 ([48da8fc](48da8fc))
github-actions bot
pushed a commit
that referenced
this pull request
Jan 3, 2024
## [1.37.0](v1.36.0...v1.37.0) (2024-01-03) ### Features * [[#1289](#1289)] support for deployment under a sub-path ([51d61e7](51d61e7)) ### Bug Fixes * [[#1142](#1142)] resolve prettier type versions ([af7176a](af7176a)) * [[#1308](#1308)] fix jest setup after upgrade ([05ece6c](05ece6c)) * [[#1313](#1313)] fix flakey time tests ([804bb42](804bb42)) * add missing packages ([d36a6e9](d36a6e9)) * use the browser location when constructing the share URL ([59f93d3](59f93d3)) ### Dependencies * bump @compiled/react from 0.16.2 to 0.16.8 ([50d0dc4](50d0dc4)) * bump chrono-node from 2.7.0 to 2.7.4 ([14cd632](14cd632)) * bump prettier and @types/prettier ([15feef5](15feef5)) * bump terser from 5.24.0 to 5.26.0 ([48da8fc](48da8fc))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an environment variable
NEXT_PUBLIC_BASE_PATHto provide support for deployment under a sub-path.For example, if you're deploying to https://tools.example.com/string-is, you'll need to set
NEXT_PUBLIC_BASE_PATHto/string-is.Checklist
.env.example(if necessary).