Skip to content

Conversation

@dmgardiner25
Copy link
Member

@dmgardiner25 dmgardiner25 commented Oct 3, 2023

The main goal of this PR is to unblock the gh cs ssh --stdio command in the GitHub CLI. This command redirects stdin/stdout to the stream rather than opening up a local TCP port which was previously supported in Live Share but was not implemented when the Dev Tunnels Go SDK was created. This is done by updating the ConnectToForwardedPort to allow for direct connection to an io.ReadWriteCloser when connecting to a forwarded port. The previous functionality to pass in a local port listener was migrated to ConnectListenerToForwardedPort.

cc. @jfullerton44

Changes proposed:

  • Update ConnectToForwardedPort to accept an io.ReadWriteCloser
  • Create ConnectListenerToForwarded that accepts a net.Listener
  • Update tests

Other Tasks:

  • If you updated the Go SDK did you update the PackageVersion in tunnels.go

@jfullerton44 jfullerton44 merged commit 97233d2 into microsoft:main Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants