Allow direct port connection in Go SDK #325
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this PR is to unblock the
gh cs ssh --stdiocommand in the GitHub CLI. This command redirects stdin/stdout to the stream rather than opening up a local TCP port which was previously supported in Live Share but was not implemented when the Dev Tunnels Go SDK was created. This is done by updating theConnectToForwardedPortto allow for direct connection to anio.ReadWriteCloserwhen connecting to a forwarded port. The previous functionality to pass in a local port listener was migrated toConnectListenerToForwardedPort.cc. @jfullerton44
Changes proposed:
ConnectToForwardedPortto accept anio.ReadWriteCloserConnectListenerToForwardedthat accepts anet.ListenerOther Tasks: