GitHub Community
Week Two: Copilot Code Review [Copilot Skills Challenge] #185754
Replies: 11 comments 9 replies
-
|
Anyone else encountered a discrepancy in According to Perplexity: "The reason the merge is not blocked is that GitHub’s 'Require conversation resolution before merging' only evaluates conversations created as part of reviews that count toward required reviews, and Copilot’s review does not count because the app does not have write access and is explicitly excluded from mergeability checks ('Only reviews by reviewers with write access count toward mergeability')". I tried adding a comment under Copilot review is unresolved and the PR can be merged
|
Beta Was this translation helpful? Give feedback.
-
|
@ijklim sorry for the inconvenience. In talking to the product team unresolved comments in a ruleset only applies to real peoples comments so in this case since GitHub Copilot Code Review made the comments you can still merge. You can test this out by having someone else comment on your PR and then leave them unresolved. We will have to adjust the exercise accordingly @chriswblake to provide the right instructions without blocking a merge. |
Beta Was this translation helpful? Give feedback.
-
|
@ijklim and @schneidergithub Thanks so much for noticing and investigating this. I'm going to start on it today, right now actually, unless life distracts me! 🧑🚀 |
Beta Was this translation helpful? Give feedback.
-
|
@arilivigni @chriswblake Thanks for checking! The evolving AI landscape definitely keeps us on our toes. Even as a daily user for the past year, these exercises have been great for picking up new tricks—I specifically enjoyed diving deeper into staged vs. unstaged code reviews and using slash commands directly from the prompt. Great work to the team for putting this together! |
Beta Was this translation helpful? Give feedback.
-
|
Thank you so much for the kind words and things do evolve daily and keeps us on our toes 🤣 |
Beta Was this translation helpful? Give feedback.
-
|
Interestingly, for me, it still blocks from merging if I have unresolved conversations, even if they are from Copilot. Before clicking Resolve button
After clicking Resolve button
Ruleset config
|
Beta Was this translation helpful? Give feedback.
-
|
Missed Week 1? Check that out here! Week One: Customize Your GitHub Copilot Experience [Copilot Skills Challenge] |
Beta Was this translation helpful? Give feedback.
-
|
Step 2) dcbab |
Beta Was this translation helpful? Give feedback.
-
|
Question One: d) All of the above Question Two: c) Review the Copilot-generated changes in detail, assess their impact on related code, and raise questions with the author about compatibility, documentation, and test coverage; recommend updating documentation or tests within the PR before approving. Question Three: b) Share the suggestion with the author, and ask them to consider adding appropriate error handling Question Four: a) Phrase suggestions in a respectful, constructive manner, and explain your reasoning Question Five: b) Never—Copilot’s suggestions are valuable but should be considered alongside your own analysis |
Beta Was this translation helpful? Give feedback.
-
|
Q/1: d Q/2: c Q/3: b Q/4: a Q/5: b |
Beta Was this translation helpful? Give feedback.
-
|
Week Two => D C B A B |
Beta Was this translation helpful? Give feedback.
-
hey guys, this needs pro subscription which I don't have , how to continue ?
|
Beta Was this translation helpful? Give feedback.
-
|
D C B A B |
Beta Was this translation helpful? Give feedback.
-
|
Q1: d My rule: Copilot suggests, I verify—especially for refactors, security, and edge cases. |
Beta Was this translation helpful? Give feedback.
-
|
for me the copilot reviewer not coming(My account is corporate one) |
Beta Was this translation helpful? Give feedback.
-
|
Thank you for participating in the GitHub Copilot Skills Challenge Week Two! We appreciate your participation and are excited to see how you did with the community challenge questions. For your first question, the correct answer is c) Automatically add error handling as suggested without involving the author. This is because Copilot's suggestions can help identify potential issues in code that may not be immediately apparent, so it's important to consider these suggestions carefully and investigate them further before making any decisions. For your second question, the correct answer is b) Schedule a meeting with the author to discuss the refactor and its broader implications. This is because, even though Copilot suggests significant changes to code that may not be immediately apparent, it's important to schedule a meeting with the author to discuss the potential impact of these changes and ensure that they are considered carefully before making any decisions. For your third question, the correct answer is b) Share the suggestion with the author, and ask them to consider adding appropriate error handling. This is because Copilot's suggestions can help identify potential issues in code that may not be immediately apparent, so it's important to share these suggestions with the author and encourage them to consider adding appropriate error handling. For your fourth question, the correct answer is a) Phrase suggestions in a respectful, constructive manner, and explain your reasoning. This is because, when sharing Copilot-generated review comments, it's important to phrase these suggestions in a respectful and constructive manner, explaining why you think they are useful and how they can help improve the code. For your final question, the correct answer is b) Never—Copilot's suggestions are valuable but should be considered alongside your own analysis. This is because, even though Copilot suggests potential issues in code that may not be immediately apparent, it's important to consider these suggestions carefully and investigate them further before making any decisions. We hope this helps you with the community challenge questions for Week Two of the GitHub Copilot Skills Challenge! If you have any additional resources or questions for our team, please feel free to share them in the discussion below. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Welcome to part two of the GitHub Copilot Skills Series! This week, we’ll leverage GitHub Copilot code review to promote code quality and catch issues before they reach production.
Missed last week? Head to Part One and then join us back here.
Step One: Skills Exercise 💪
To begin, complete the GitHub Copilot Code Review exercise where you’ll learn how to use GitHub Copilot for automated code reviews, customize review criteria, and set up automatic reviews
Then, come back for part two to deepen your learning with our challenge and be entered to win a GitHub Shop Voucher!
Step Two: Community Challenge 🧠
Answer these multiple choice questions in the comments section:
Question One: Which Copilot feature can assist you in writing clearer code review comments?
a) Suggest code comments
b) Generate docstrings
c) Suggest edits and questions based on the changed code
d) All of the above
Question Two: Copilot suggests a significant refactor to a core function, affecting its inputs and outputs in ways not documented in the original pull request. What actions should you take as a reviewer?
a) Carefully review the Copilot-suggested changes, and if the implementation appears sound, approve and merge the pull request; leave it to future contributors to update related documentation or tests as needed.
b) Schedule a meeting with the author to discuss the refactor and its broader implications; wait for input from other team members before making any review decisions.
c) Review the Copilot-generated changes in detail, assess their impact on related code, and raise questions with the author about compatibility, documentation, and test coverage; recommend updating documentation or tests within the PR before approving.
d) Comment on the refactor, recommending the author revert to the original function structure unless the changes are justified with benchmarking data or formal design approval, then proceed only if those are provided.
Question Three: Copilot generates a code comment suggesting error handling for a function that currently has none. What should you do with this suggestion?
a) Ignore the comment since the function already works as intended
b) Share the suggestion with the author, and ask them to consider adding appropriate error handling
c) Automatically add error handling as suggested without involving the author
d) Remove the suggestion if it wasn’t part of the author’s original changes
Question Four: When using Copilot to add code review comments, what is the best way to ensure your feedback is helpful to the contributor?
a) Phrase suggestions in a respectful, constructive manner, and explain your reasoning
b) Write as many comments as possible to cover all potential issues
c) Use copy-pasted comments for consistency
d) Avoid suggestions unless there is a critical bug
Question Five; When should you rely solely on Copilot-generated review comments without further investigation?
a) Only when the code author is highly experienced
b) Never—Copilot’s suggestions are valuable but should be considered alongside your own analysis
c) Whenever Copilot highlights a possible error
d) Anytime Copilot's comments match your initial impression
We’ll be sharing the answers in the comments on Monday 🧠
Use the discussion below to share additional resources, ask questions for our team to answer, and respond to the challenge.
**No Purchase Necessary. Open only to Github community members 14+. Game ends February 17, 2026. For details, see Official rules.
Beta Was this translation helpful? Give feedback.
All reactions