Skip to content

Adding Sam.gov implementations #1714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 9, 2023
Merged

Conversation

brunerae
Copy link
Contributor

Adding Sam.gov implementations.

Sam-Styles - https://github.com/GSA/sam-styles - HTML/CSS design library built on USWDS 2.0 and Fractal.
Sam-Design-System - https://github.com/GSA/sam-design-system - Common Angular components integrated with sam-styles css framework.
Sam-Prototypes - https://github.com/GSA/sam-prototypes - A test application that incorporates sam-styles and sam-design-system components with real-world examples.

UI components: For pull requests that impact the look, feel, or functionality of USWDS itself, please open a pull request on the web-design-standards repo (https://github.com/uswds/uswds-site).

-->

Description

Include a high-level description of the issue your pull request fixes; include only one issue per pull request. Please also link to the GitHub issue it resolves.

Additional information

Include any of the following (as necessary):

  • Relevant research and support documents
  • Type of content review needed: stylistic or copy editing
  • Screenshot images
  • Notes
  • etc.

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@brunerae brunerae requested review from amyleadem and mejiaj July 13, 2022 19:15
@brunerae brunerae linked an issue Jul 13, 2022 that may be closed by this pull request
@amyleadem
Copy link
Contributor

amyleadem commented Jul 14, 2022

@brunerae
Excess spacing before - name was causing a Jekyll error. I pushed up a change that removes the extra spacing and it resolved the error.

While I was in there, I also reordered the items to be alphabetical by framework.

Updates found in e2b4586.

We still have some CircleCI errors, but those should be resolved once #1713 is merged. Fixed!

url: https://github.com/GSA/sam-design-system
author:
name: SAM.gov
url: https://github.com/GSA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thrown off by the the SAM.gov link pointing to GSA's GitHub. Does it make sense to but the author name as GSA? Or maybe something like SAM.gov/GSA?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably GSA if it's from there.

@amyleadem amyleadem self-assigned this Jul 14, 2022
mejiaj
mejiaj previously requested changes Jul 15, 2022
Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other notes use a period at the end, so let's add one to these new implementations. Thank you!

@thisisdano thisisdano changed the base branch from main to release-3.4.0 March 7, 2023 20:53
@thisisdano thisisdano added this to the uswds 3.4.0 milestone Mar 7, 2023
@thisisdano thisisdano dismissed mejiaj’s stale review March 9, 2023 18:53

Addressed comments

@thisisdano thisisdano merged commit 88a1816 into release-3.4.0 Mar 9, 2023
@thisisdano thisisdano deleted the SAM-implementations branch March 9, 2023 18:53
@thisisdano thisisdano mentioned this pull request Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SAM.gov resources to the implementations documentation
4 participants