Skip to content

USWDS - Icon: add missing contrast icons #4686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2022
Merged

USWDS - Icon: add missing contrast icons #4686

merged 2 commits into from
May 12, 2022

Conversation

amyleadem
Copy link
Contributor

@amyleadem amyleadem commented May 10, 2022 •
edited
Loading

Description

Add missing fallback icon assets. These icons provide accessible contrast when $theme-body-background-color is given a dark color value.

Closes #4643

Additional information

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@amyleadem amyleadem changed the title USWDS - usa-icon: add missing --white icons USWDS - usa-icon: missing contrast icons May 10, 2022
@amyleadem amyleadem marked this pull request as ready for review May 11, 2022 15:43
@amyleadem amyleadem requested review from mejiaj and mahoneycm May 11, 2022 15:43
@amyleadem amyleadem changed the title USWDS - usa-icon: missing contrast icons USWDS - Icon: add missing contrast icons May 12, 2022
@amyleadem
Copy link
Contributor Author

These icons will need to go through svgo optimization --> must coordinate with this PR: #4683

@thisisdano thisisdano merged commit fee235c into develop May 12, 2022
@thisisdano thisisdano deleted the al-missing-background-icons branch May 12, 2022 23:15
@thisisdano thisisdano mentioned this pull request Jun 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisdano thisisdano thisisdano approved these changes

@mejiaj mejiaj Awaiting requested review from mejiaj

@mahoneycm mahoneycm Awaiting requested review from mahoneycm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compile fails when modifying $theme-body-background-color
2 participants
@amyleadem @thisisdano