USWDS: Fix typos #6251

szepeviktor · 2024-12-12T10:12:05Z

Summary

Found few misspellings.

Breaking change

I do not recognize one.

Solution

https://github.com/crate-ci/typos

packages/usa-icon/src/usa-icon--sizes/usa-icon--sizes.json

amyleadem

Looks good to me. Thanks for this contribution @szepeviktor!

amyleadem · 2025-01-02T17:13:53Z

packages/uswds-utilities/src/styles/palettes/_index.scss

Note
I confirmed that the file names for these have the correct spelling, so no update is needed on the file names themselves:

color-palettes.scss

default-palettes.scss

font-palettes.scss

spacing-palettes.scss

It isn't immediately clear to me what this index file is used for, but given that the forwards are currently misspelled, we might not need this file. Something to consider as a follow-on.

Odd that the misspellings weren't breaking anything.. should we open a new issue to investigate this file?

Since this is in the utilities directory, I'm wondering if these are used by utilities that are not output by default. We might find something helpful in _settings-utilities.scss

amyleadem · 2025-01-02T19:56:43Z

webpack.twig.config.js

@@ -35,7 +35,7 @@ function buildFileObj(dir, file, dataFile){

  function buildModifierData(dataSource) {
    const regexDashes = /--([\s\S]*)$/
-    const regexTilda = /~([\s\S]*)$/
+    const regexTilde = /~([\s\S]*)$/


Note
Confirmed that all references to regexTilda in this file have been updated to regexTilde.

amyleadem · 2025-01-02T20:03:08Z

packages/templates/usa-landing/includes/_usa-landing-inner.twig

@@ -65,7 +65,7 @@
        are, your goal or mission, and how you approach it. Use this section to encourage them to act. Describe why they
        should get in touch here, and use an active verb on the button below. “Get in touch,” “Learn more,” and so on.
      </p>
-      <a class="usa-button usa-button--big" href="{{ placholder_link }}">Call to action</a>
+      <a class="usa-button usa-button--big" href="{{ placeholder_link }}">Call to action</a>


Note
Neither placeholder_link nor placholder_link are defined in the usa-landing directory. I don't consider this to be a blocker for this PR, so I have opened issue #6277 to fix this.

amyleadem · 2025-01-02T21:00:04Z

packages/templates/usa-sign-in/includes/_max.twig

@@ -24,7 +24,7 @@
    <p>
      <a
        class="{{ settings[lang].cta.type | default(button_defaults) }}"
-        href="{{ placholder_link }}">
+        href="{{ placeholder_link }}">


Note
Same comment as above. Neither placeholder_link nor placholder_link are defined. I don't consider this to be a blocker for this PR, so I have opened issue #6277 to fix this.

packages/usa-icon/src/usa-icon--sizes/usa-icon--sizes.json

szepeviktor · 2025-01-02T22:06:39Z

Glad to contribute.

finekatie

Following your lead on these, @amyleadem - looks good to me.

mandylloyd

Confirmed no regressions! lgtm

heymatthenry

Thanks, Viktor!

mahoneycm

LGTM! Thanks @szepeviktor 🥳

packages/usa-icon/src/usa-icon--sizes/usa-icon--sizes.json

mahoneycm · 2025-01-03T17:37:30Z

packages/uswds-utilities/src/styles/palettes/_index.scss

Since this is in the utilities directory, I'm wondering if these are used by utilities that are not output by default. We might find something helpful in _settings-utilities.scss

amyleadem · 2025-01-07T19:53:24Z

@szepeviktor,
For security reasons, USWDS now requires that all commits to this repo have a verified signature. Your commits are registering as unverified, so we will need you to complete the following steps before this contribution can be merged:

Set up signature verification in GitHub. Use one of the following GitHub guides to set up your verification signature:
- GPG commit signature verification
- SSH commit signature verification
Rebase your commits with your verified signature. Once your signature is set up, complete the following steps in the terminal to update the verification status of your previous commits:
```
git checkout branch-name
git rebase origin/main
git push --force-with-lease
```

Thanks again for your contribution. Please let us know if you have any questions or if we can help in any way.

szepeviktor · 2025-01-07T20:01:46Z

@amyleadem Voilà! Your dream just came true.

amyleadem · 2025-01-07T20:36:26Z

@szepeviktor Thank you for fixing that so quickly!

thisisdano · 2025-01-23T00:32:46Z

packages/uswds-utilities/src/styles/palettes/_index.scss

+@forward "color-palettes";
+@forward "default-palettes";
+@forward "font-palettes";
 @forward "palette-registry";
-@forward "spacing-palletes";
+@forward "spacing-palettes";


This index file appears to be here only as a formality and for consistency with other directories of Sass files. It is not referenced in the codebase. I was concerned that this might be a breaking change, but it appears not

szepeviktor requested a review from a team as a code owner December 12, 2024 10:12

szepeviktor commented Dec 12, 2024

View reviewed changes

packages/usa-icon/src/usa-icon--sizes/usa-icon--sizes.json Show resolved Hide resolved

amyleadem added this to the USWDS 3.12.0 (Draft) milestone Dec 13, 2024

amyleadem requested review from mejiaj, amyleadem, finekatie, cathybaptista, mahoneycm, mandylloyd and RachelCorsino January 2, 2025 15:49

mahoneycm added Status: Triage and removed Status: Triage labels Jan 2, 2025

amyleadem mentioned this pull request Jan 2, 2025

USWDS - Define empty placeholder link references #6277

Open

amyleadem approved these changes Jan 2, 2025

View reviewed changes

finekatie approved these changes Jan 3, 2025

View reviewed changes

mandylloyd approved these changes Jan 3, 2025

View reviewed changes

amyleadem requested review from heymatthenry and thisisdano January 3, 2025 16:57

heymatthenry approved these changes Jan 3, 2025

View reviewed changes

mahoneycm approved these changes Jan 3, 2025

View reviewed changes

This was referenced Jan 3, 2025

USWDS - Draft 3.12.0 release notes #6254

Closed

USWDS-Site: Documentation updates for 3.12.0 uswds/uswds-site#3039

Merged

amyleadem added the Needs: Commit verification label Jan 7, 2025

Fix typos

32866c7

szepeviktor force-pushed the typos branch from 9f3af15 to 32866c7 Compare January 7, 2025 20:01

amyleadem removed the Needs: Commit verification label Jan 7, 2025

thisisdano reviewed Jan 23, 2025

View reviewed changes

thisisdano approved these changes Jan 23, 2025

View reviewed changes

thisisdano merged commit a13eec6 into uswds:develop Jan 23, 2025
2 checks passed

szepeviktor deleted the typos branch January 23, 2025 05:32

heymatthenry mentioned this pull request Mar 7, 2025

USWDS: Release 3.12.0 #6434

Merged

USWDS: Fix typos #6251

USWDS: Fix typos #6251

Uh oh!

Conversation

szepeviktor commented Dec 12, 2024

Summary

Breaking change

Solution

Uh oh!

Uh oh!

amyleadem left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

szepeviktor commented Jan 2, 2025

Uh oh!

finekatie left a comment

Choose a reason for hiding this comment

Uh oh!

mandylloyd left a comment

Choose a reason for hiding this comment

Uh oh!

heymatthenry left a comment

Choose a reason for hiding this comment

Uh oh!

mahoneycm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amyleadem commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

szepeviktor commented Jan 7, 2025

Uh oh!

amyleadem commented Jan 7, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

amyleadem commented Jan 7, 2025 •

edited

Loading