Skip to content

USWDS-Site: Add January 2024 monthly call #2465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 9, 2024

Conversation

sarah-sch
Copy link
Contributor

@sarah-sch sarah-sch commented Jan 25, 2024

Adding the January 2024 video, along with a description and related links, to the USWDS monthly call page.

Summary

This purpose of this PR is to update the monthly call page to include a video (and supplemental information) for hte January 2024 monthly call. This update will keep the page relevant and timely.

Related issue

Closes #2464

Preview link

Monthly calls page

Problem statement

The January 2024 video needs to be added to the USWDS monthly calls page.

Solution

This action will add the January 2024 video to the monthly call page so that the USWDS community can enjoy it!

Provide a summary of the solution this PR offers.

Major changes

NA
For complex PRs, create a list of the significant updates made.

Testing and review

Please proof the new content and make sure it's formatted correctly.
Share recommended methods for reviewing this change.

Adding the January 2024 video, along with a description and related links, to the USWDS monthly call page.
@amyleadem amyleadem changed the title Update monthly-calls.yml USWDS-Site: Add January 2024 monthly call Jan 25, 2024
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I had a couple of comments but I don't think either needs to be a blocker.

  • Confirm January monthly call is present on the monthly calls page in the correct order
  • Confirm the date and title matches the presentation
  • Confirm the summary has no typos or errors
  • Confirm the links in the summary work
  • Confirm the slides link works as expected
  • Confirm the slide count and slides files size is accurate
  • Confirm the link to [digital.gov](http://digital.gov) works
    • Note: There is no script available on the page at this time.
  • Confirm the YouTube video loads correctly

Note

This PR has some build errors related to new HTML proofer errors. I am going to work on a separate PR to resolve these errors.

Copy link
Contributor

@finekatie finekatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sarah-sch , looks good! I did suggest a link change to make them all uniform.

sarah-sch and others added 3 commits January 25, 2024 16:14
Correcting links component test page link and adding sentence per revisions from Anne.
Adding "missing_text: true" to Jan. 2024 call per @amyleadem
s suggestion
@sarah-sch
Copy link
Contributor Author

@amyleadem and @finekatie - I believe I have responded to your comments/suggestions and a new sentence to the description from Anne ("We then prototyped the pages that explain how we tested and what we found in those tests.")

Copy link
Contributor Author

@sarah-sch sarah-sch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments and suggestions should now be resolved.

Copy link
Contributor

@finekatie finekatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Note

Need to merge USWDS-Site - HTML-proofer: Fix broken links to fix the HTML proofer errors in this PR.

@amyleadem amyleadem requested a review from thisisdano January 26, 2024 18:45
@thisisdano
Copy link
Contributor

Merging over Circle pa11y crash

@thisisdano thisisdano merged commit 5d5a869 into main Feb 9, 2024
@thisisdano thisisdano deleted the sls-jan-24-mc-page-updates branch February 9, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update monthly call page to include January video
4 participants