The Wayback Machine - https://web.archive.org/web/20200914210553/https://github.com/JuliaLang/Pkg.jl/pull/1916
Skip to content

/ Pkg.jl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BinaryPlatforms: Recognize MacOS(:aarch64) #1916

Merged
merged 1 commit into from Jul 11, 2020
Merged

BinaryPlatforms: Recognize MacOS(:aarch64) #1916

merged 1 commit into from Jul 11, 2020

Conversation

@Keno
Copy link
Member

Keno commented Jul 9, 2020

Also normalize arm64 -> aarch64, c.f.
https://lists.gnu.org/archive/html/config-patches/2020-07/msg00002.html
@Keno
BinaryPlatforms: Recognize MacOS(:aarch64)
Loading status checks…
1f45f09 
Also normalize arm64 -> aarch64, c.f.
https://lists.gnu.org/archive/html/config-patches/2020-07/msg00002.html
@Keno Keno requested a review from staticfloat Jul 9, 2020
@staticfloat
staticfloat approved these changes Jul 9, 2020
View changes
@Keno Keno merged commit 3eee6eb into master Jul 11, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Keno Keno deleted the kf/applearm64 branch Jul 11, 2020
@Keno Keno mentioned this pull request Jul 11, 2020
Open
9 of 13 tasks complete
@giordano
Copy link

giordano commented Jul 11, 2020

MacOS() still defaults to x86_64, kept for backward compatibility I guess?
@staticfloat
Copy link
Member

staticfloat commented Jul 12, 2020

Yes, it's going to be a while before that's changed, I think. :P
@giordano
Copy link

giordano commented Jul 12, 2020 •
edited

Sure, I was not thinking about changing the default, but rather about the fact other platforms with multiple possible architectures, like Linux and Windows, don't have a default constructor without the specification of the architecture. I assume removing the MacOS() method would be breaking though.
@staticfloat
Copy link
Member

staticfloat commented Jul 12, 2020

Indeed; hindsight is 20:20.

That being said, if we think it would be better, I have no qualms about breaking build_tarballs.jl files. It's a very easy fix, and Yggdrasil contains a high percentage of what we care about.
staticfloat added a commit that referenced this pull request Sep 3, 2020
@Keno @staticfloat
BinaryPlatforms: Recognize MacOS(:aarch64) (#1916)
Loading status checks…
26611f3 
Also normalize arm64 -> aarch64, c.f.
https://lists.gnu.org/archive/html/config-patches/2020-07/msg00002.html
fredrikekre pushed a commit that referenced this pull request Sep 5, 2020
@staticfloat @Keno
backport: BinaryPlatforms: Recognize MacOS(:aarch64) (#2003)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7e73e59 
Also normalize arm64 -> aarch64, c.f.
https://lists.gnu.org/archive/html/config-patches/2020-07/msg00002.html

(cherry-picked from commit 3eee6eb, PR #1916)

Co-authored-by: Keno Fischer <[email protected]>
Co-authored-by: Elliot Saba <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staticfloat staticfloat

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Keno @giordano @staticfloat
You can’t perform that action at this time.