The Wayback Machine - https://web.archive.org/web/20211122072357/http://reviews.llvm.org/
Page MenuHomePhabricator

Recent Activity
View All

Today

noajshu updated the diff for D112759: [llvm] [Debuginfo] Add llvm-debuginfod-find tool and end-to-end-tests..

Use latest debuginfod client library (D112758).
Also condition debuginfod-find lit test execution on availability of libcurl.

Sun, Nov 21, 11:21 PM · Restricted Project
ikudrin committed rGa05b694b1e1d: [ELF][NFC] Do not pass region name to expandMemoryRegion() (authored by ikudrin).
[ELF][NFC] Do not pass region name to expandMemoryRegion()
Sun, Nov 21, 11:19 PM
ikudrin closed D114228: [ELF][NFC] Do not pass region name to expandMemoryRegion().
Sun, Nov 21, 11:19 PM · Restricted Project, lld
noajshu updated the diff for D112758: [llvm] [Debuginfo] Debuginfod client library..

Introduce BuildIDRef and enable custom cache directory.

Sun, Nov 21, 11:18 PM · Restricted Project
• arnab-oss added a comment to D114238: [MLIR] Avoid creation of buggy affine maps when incorrect values of number of dimensions and number of symbols are provided..

ping @rriddle and @nicolasvasilache can you please take a look at the replies of your respective comments.

Sun, Nov 21, 11:07 PM · Restricted Project
• arnab-oss updated the diff for D114238: [MLIR] Avoid creation of buggy affine maps when incorrect values of number of dimensions and number of symbols are provided..

Removed unnecessary #include<algorithm>.

Sun, Nov 21, 11:06 PM · Restricted Project
cdevadas added a comment to D109301: [AMDGPU] Enable copy between VGPR and AGPR classes during regalloc.

The combination of Regcoalescer, superclass copy (tryInstructionSplit), and Spiller during regalloc introduce a superclass spill at extreme pressure situations.
Lit test llvm/test/CodeGen/AMDGPU/schedule-xdl-resource.ll demonstrates that.
This mostly happens for gfx908 where we need a copy for AGPR to VGPR. I didn’t see this happening for gfx90a.

Sun, Nov 21, 11:03 PM · Restricted Project
Jaysonyan added a comment to D114224: Add JSONScopedPrinter class.
In D114224#3142126, @jhenderson wrote:

Cross-posting this comment, since it's now applicable to this patch specifically: I think we probably need to do a bit of both: each method should be tested in isolation. I think we should ensure we have tests for the history stack, where it's applicable only. Basically, test the existing possible code paths, plus maybe one or two more interesting cases that test interaction between functions, if it seems sensible.

Sun, Nov 21, 11:02 PM · Restricted Project
• arnab-oss updated the diff for D114238: [MLIR] Avoid creation of buggy affine maps when incorrect values of number of dimensions and number of symbols are provided..

Addressed comments.

Sun, Nov 21, 11:01 PM · Restricted Project
Jaysonyan updated the diff for D114224: Add JSONScopedPrinter class.

Add printBinaryImpl implementation.
Remove duplicated logic for json scope logic.
Update printHex to print numbers.
Clean up formatting.

Sun, Nov 21, 11:01 PM · Restricted Project
mstorsjo requested review of D114347: [LLD] [COFF] Interpret the immediate in ARM64 adr/adrp relocations as signed 21 bit.
Sun, Nov 21, 10:51 PM · Restricted Project
kaz7 requested review of D114346: [runtimes][openmp] Change to not treat ARCH-unknown-linux-gnu as errors.
Sun, Nov 21, 10:20 PM · Restricted Project
pcwang-thead committed rGaf0ecfccae82: [RISCV] Generate pseudo instruction li (authored by pcwang-thead).
[RISCV] Generate pseudo instruction li
Sun, Nov 21, 10:04 PM
pcwang-thead closed D112692: [RISCV] Generate pseudo instruction li.
Sun, Nov 21, 10:04 PM · Restricted Project, Restricted Project
jw839097 updated jw839097.
Sun, Nov 21, 9:48 PM
qiucf accepted D113908: [PowerPC] Support of ppc_fp128 in lowering of llvm.is_fpclass.

Thanks

Sun, Nov 21, 9:25 PM · Restricted Project
qiucf requested review of D114345: [PowerPC] Implement general back2back fusion.
Sun, Nov 21, 9:23 PM · Restricted Project
pcwang-thead updated the diff for D112692: [RISCV] Generate pseudo instruction li.

Rebase.

Sun, Nov 21, 9:16 PM · Restricted Project, Restricted Project
Vigneshbalu added a comment to D100185: [OpenMP] [OMPD] [5/6] Implementation of OMPD debugging library - libompd. gdb-plugin: A Plugin code to gdb to leverage libompd to provide debugging support..

Gentle reminder, as it is one of the last two patches to complete OMPD.

Sun, Nov 21, 9:00 PM · Restricted Project
mkazantsev added inline comments to D114039: [runtime-unroll] Prune early exits when unrolling multiple exit loops.
Sun, Nov 21, 8:24 PM · Restricted Project
mkazantsev added a comment to D114260: [SCEV] Remove validity check on lookup (NFC).

Can we replace it with assert for the first time, and then delete it when we make sure it never fails?

Sun, Nov 21, 8:19 PM · Restricted Project
mkazantsev accepted D114263: [SCEV] Simplify forgetSymbolicName() (NFCI).
Sun, Nov 21, 8:16 PM · Restricted Project
mkazantsev accepted D113349: [SCEV] Fix and validate ValueExprMap/ExprValueMap consistency.

lg!

Sun, Nov 21, 8:16 PM · Restricted Project
rjmccall added a comment to D100879: [Clang] Propagate guaranteed alignment for malloc and others .

Platforms are permitted to make stronger guarantees than the C standard requires, and it is totally reasonable for compilers to assume that malloc meets the target platform's documented guarantees. Arguably, libraries should not be replacing malloc if they fail to meet the platform's documented guarantees.

Sun, Nov 21, 7:58 PM · Restricted Project
kazu committed rG49e3838145df: [llvm] Use make_early_inc_range (NFC) (authored by kazu).
[llvm] Use make_early_inc_range (NFC)
Sun, Nov 21, 7:24 PM
kazu committed rGea5421bd0db3: [llvm] Use range-based for loops (NFC) (authored by kazu).
[llvm] Use range-based for loops (NFC)
Sun, Nov 21, 7:24 PM
HsiangKai updated the diff for D113967: [RISCV] Reverse the order of loading/storing callee-saved registers..

Address @jrtc27's comments.

Sun, Nov 21, 6:56 PM · Restricted Project
sfuniak added a comment to D108543: Defines new PDLInterp operations needed for multi-root matching in PDL..

On the second thought, the two operations (pdl_interp.get_defining_op and pdl_interp.get_users) are not symmetric. And I do see value in mimicking c++ API. I will make the change requested.

Sun, Nov 21, 6:44 PM · Restricted Project
philnik requested review of D114344: [libc++] [NFC] Mark P0858R0 as implemented.
Sun, Nov 21, 6:25 PM · Restricted Project
dblaikie added inline comments to D114305: [Demangle] Add support for multiple identifiers in D qualified names.
Sun, Nov 21, 6:20 PM · Restricted Project
mcgrathr committed rGb72b56016a6b: NFC: clang-format lib/Transforms/Instrumentation/InstrProfiling.cpp (authored by mcgrathr).
NFC: clang-format lib/Transforms/Instrumentation/InstrProfiling.cpp
Sun, Nov 21, 6:16 PM
MarcusJohnson91 updated the summary of D114342: ConvertUTF, new wrapper API.
Sun, Nov 21, 6:16 PM · Restricted Project, Restricted Project
mcgrathr closed D114343: NFC: clang-format lib/Transforms/Instrumentation/InstrProfiling.cpp.
Sun, Nov 21, 6:16 PM · Restricted Project
MarcusJohnson91 abandoned D107202: ConvertUTF: convertUTF32ToUTF8String.

Reposted as @D114342

Sun, Nov 21, 6:15 PM · Restricted Project
mcgrathr requested review of D114343: NFC: clang-format lib/Transforms/Instrumentation/InstrProfiling.cpp.
Sun, Nov 21, 6:15 PM · Restricted Project
MarcusJohnson91 requested review of D114342: ConvertUTF, new wrapper API.
Sun, Nov 21, 6:13 PM · Restricted Project, Restricted Project
achieveartificialintelligence updated the diff for D98136: [RISCV][RFC] Initially support the K-extension instructions on the LLVM MC layer.

Rebase and Ping.

Sun, Nov 21, 6:13 PM · Restricted Project
ChuanqiXu added inline comments to D114151: [clang-format] [C++20] [Module] clang-format couldn't recognize partitions.
Sun, Nov 21, 6:02 PM · Restricted Project, Restricted Project
jloser updated the diff for D113161: [libc++] Implement P1989R2: range constructor for string_view.

Fix from_range.pass.cpp for no wide char support

Sun, Nov 21, 6:02 PM · Restricted Project
achieveartificialintelligence updated the diff for D93298: [RISCV] add the MC layer support of Zfinx extension.

Rebase and Ping.

Sun, Nov 21, 5:58 PM · Restricted Project, Restricted Project