C# Programming Issue

[jeffreybyrd9745 (jeffrey byrd)]

I have spent over 3 hours on this and gotten most of app to execute. However, for some reason, C# has decided not to recognize my first three methods saying :

Error 2 ‘HW7CH6_5.Form1.FlushCharges()’: not all code paths return a value

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Windows.Forms;

namespace HW7CH6_5
{
    public partial class Form1 : Form
    {
        public Form1()
        {
            InitializeComponent();
        }

        public static decimal svcOilCharges = 26.0m;
        public static decimal svcLubeCharges = 18.0m;
        public static decimal svcRadiatorCharges = 30.0m;
        public static decimal svcTransmissionCharges = 80.0m;
        public static decimal svcInspectionCharges = 15.0m;
        public static decimal svcMufflerCharges = 100.0m;
        public static decimal svcTireCharges = 20.0m;

        public decimal OilLubeCharges()
        {
            decimal charges = 0.0m;
            if (chboxOilChange.Checked && chboxLubeJob.Checked)
            {
                charges = svcOilCharges + svcLubeCharges;
                return charges;
            }
            if (chboxOilChange.Checked)
            {
                charges = svcOilCharges;
                return charges;
            }
            if(chboxLubeJob.Checked)
            {
                charges = svcLubeCharges;
                return charges;
            }
        }

        public decimal FlushCharges()
        {
            decimal charges = 0.0m;
            if (chboxRadiator.Checked && chboxTransmission.Checked)
            {
                charges = svcRadiatorCharges + svcTransmissionCharges;
                return charges;
            }
            if (chboxRadiator.Checked)
            {
                charges = svcRadiatorCharges;
                return charges;
            }
            if (chboxTransmission.Checked)
            {
                charges = svcTransmissionCharges;
                return charges;
            }
        }

        public decimal MiscCharges()
        {
            decimal charges = 0.0m;
            if (chboxInspection.Checked && chboxMuffler.Checked && chboxTireRotation.Checked)
            {
                charges = svcInspectionCharges + svcMufflerCharges + svcTireCharges;
                return charges;
            }
            if (chboxInspection.Checked)
            {
                charges = svcInspectionCharges;
                return charges;
            }
            if (chboxMuffler.Checked)
            {
                charges = svcMufflerCharges;
                return charges;
            }
            if (chboxTireRotation.Checked)
            {
                charges = svcTireCharges;
                return charges;
            }
        }

        public decimal OtherCharges()
        {
            try
            {
                decimal parts = Decimal.Parse(tbxParts.Text);
                decimal labor = Decimal.Parse(tbxLabor.Text);
                decimal charges = parts + labor;
                return charges;
            }
            catch {MessageBox.Show("Please enter valid data for either parts or labor fields."); }
            return 0.0m;
        }

        public decimal TaxCharges()
        {
            decimal charges = 0.0m;
            decimal salesTax = 0.6m;
            {
                try
                {
                    decimal taxparts = Decimal.Parse(tbxParts.Text);
                    charges = taxparts * salesTax;
                    return charges;
                }
                catch
                { MessageBox.Show("Please enter valid for parts field."); }
                return 0.0m;
            }
        }

        public decimal TotalCharges()
        {
            decimal charges = OilLubeCharges() + FlushCharges() + MiscCharges() + OtherCharges() + TaxCharges();
            return charges;
        }

        private void buttonCalculate_Click(object sender, EventArgs e)
        {
            decimal labor = Decimal.Parse(tbxLabor.Text);
            labelServiceLabor.Text = (OilLubeCharges()+FlushCharges()+ MiscCharges()+labor.ToString("C"));
            labelParts.Text = Decimal.Parse(tbxParts.Text).ToString("C");
            labelTax.Text = TaxCharges().ToString("C");
            labelTotalFees.Text = TotalCharges().ToString("C");
        }

        public void ClearOilLube()
        {
            chboxOilChange.Checked = false;
            chboxLubeJob.Checked = false;
        }

        public void ClearFlushes()
        {
            chboxRadiator.Checked = false;
            chboxTransmission.Checked = false;
        }

        public void ClearMiscCharges()
        {
            chboxInspection.Checked = false;
            chboxMuffler.Checked = false;
            chboxTransmission.Checked = false;
        }

        public void ClearOther()
        {
            tbxLabor.Text = "0";
            tbxParts.Text = "0";
        }

        public void ClearFees()
        {
            labelServiceLabor.Text = "";
            labelParts.Text = "";
            labelTax.Text = "";
            labelTotalFees.Text = "";
        }

        private void buttonClear_Click(object sender, EventArgs e)
        {
            ClearOilLube();
            ClearFlushes();
            ClearMiscCharges();
            ClearOther();
            ClearFees();
        }

        private void buttonExit_Click(object sender, EventArgs e)
        {
            //Close the form.
            this.Close();
        }
    }
}

[shabirhakim8605 (ShabirHakim)]

What i can see is you are returning after every block if you can just make bit change in your code like below i believe it will work fine

 public decimal FlushCharges()
{
decimal charges = 0.0m;
if (chboxRadiator.Checked && chboxTransmission.Checked)
{
charges = svcRadiatorCharges + svcTransmissionCharges;
return charges;
}
if (chboxRadiator.Checked)
{
charges = svcRadiatorCharges;
return charges;
}
if (chboxTransmission.Checked)
{
charges = svcTransmissionCharges;
return charges;
}
return charges;
}

[cshortridge (ChuckShortridge)]

All of your return statements in that function are in conditional blocks (if statements). Think about what happens if:

chboxRadiator.Checked == false

and

chboxTransmission.Checked == false

To fix it you just need a return statement that is not in an if statement.

Another way to take care of it would be to arrange your if statements and only have 1 return statement:

decimal charges = 0.0m;

if (chboxRadiator.Checked)
{
charges = svcRadiatorCharges;
}

if (chboxTransmission.Checked)
{
charges = svcTransmissionCharges;
}

if (chboxRadiator.Checked && chboxTransmission.Checked)
{
charges = svcRadiatorCharges + svcTransmissionCharges;
}

return charges;

[jeffreybyrd9745 (jeffrey byrd)]

Thanks guys.

[jeffreybyrd9745 (jeffrey byrd)]

I am still getting one more error though, there are no build errors but I am getting an exception error during the debugging process.

On this line (in bold and italicized)

private void buttonCalculate_Click(object sender, EventArgs e)
{
decimal labor = Decimal.Parse(tbxLabor.Text);
labelServiceLabor.Text = (OilLubeCharges()+FlushCharges()+ MiscCharges()+labor.ToString(“C”));
labelParts.Text = Decimal.Parse(tbxParts.Text).ToString(“C”);
labelTax.Text = TaxCharges().ToString(“C”);
labelTotalFees.Text = TotalCharges().ToString(“C”);
}
This is the exception error (in bold):

System.FormatException was unhandled
HResult=-2146233033
Message=Input string was not in a correct format.
Source=mscorlib
StackTrace:
at System.Number.StringToNumber(String str, NumberStyles options, NumberBuffer& number, NumberFormatInfo info, Boolean parseDecimal)
at System.Number.ParseDecimal(String value, NumberStyles options, NumberFormatInfo numfmt)
at System.Decimal.Parse(String s)
at HW7CH6_5.Form1.buttonCalculate_Click(Object sender, EventArgs e) in line 128
at System.Windows.Forms.Control.OnClick(EventArgs e)
at System.Windows.Forms.Button.OnClick(EventArgs e)
at System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent)
at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.ButtonBase.WndProc(Message& m)
at System.Windows.Forms.Button.WndProc(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.DebuggableCallback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
at System.Windows.Forms.UnsafeNativeMethods.DispatchMessageW(MSG& msg)
at System.Windows.Forms.Application.ComponentManager.System.Windows.Forms.UnsafeNativeMethods.IMsoComponentManager.FPushMessageLoop(IntPtr dwComponentID, Int32 reason, Int32 pvLoopData)
at System.Windows.Forms.Application.ThreadContext.RunMessageLoopInner(Int32 reason, ApplicationContext context)
at System.Windows.Forms.Application.ThreadContext.RunMessageLoop(Int32 reason, ApplicationContext context)
at System.Windows.Forms.Application.Run(Form mainForm)
at HW7CH6_5.Program.Main() in C:\Users\Jeff Byrd\documents\visual studio 2010\Projects\HW7CH6-5\HW7CH6-5\Program.cs:line 18
at System.AppDomain._nExecuteAssembly(RuntimeAssembly assembly, String args)
at System.AppDomain.ExecuteAssembly(String assemblyFile, Evidence assemblySecurity, String args)
at Microsoft.VisualStudio.HostingProcess.HostProc.RunUsersAssembly()
at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Threading.ThreadHelper.ThreadStart()
InnerException:

[jeffreybyrd9745 (jeffrey byrd)]

decimal labor = Decimal.Parse(tbxLabor.Text); is the line with problem; it works with decimal parts but not decimal labor; says i have it incorrectly formatted when decimal parts is in same format and works ???

[jeffreybyrd9745 (jeffrey byrd)]

I am still getting one more error though, there are no build errors but I am getting an exception error during the debugging process.

[geraldtjohnsonii (Jay4220)]

I would then think that tbxLabor.Text is not a String that can be converted to a decimal