Cannot figure this switch statement out

[spiceuser-5aro4]

Powershell n00b here, option 1 works perfectly but I can’t understand why this switch statement doesn’t work when I choose option 2. Is this because I’m reusing variables or something stupid? If I insert $defaultgroups.defaultPPFPOgroups somewhere in the second switch statement I can see that it reads the values from the second column of the CSV file. It just will not add those values to the member.

 $defaultgroups = Import-Csv .\ADGroupsCSV.csv
 
 function Show-Menu
{
    param (
        [string]$Title = 'Add AD Groups to user'
    )
    Clear-Host
    Write-Host "================ $Title ================"
    
    Write-Host "1: Press '1' to add default WH Groups."
    Write-Host "2: Press '2' to add default OT Groups."
    Write-Host "3: Press '3' to add Forest specific groups."
    Write-Host "Q: Type 'Q' to quit."
}

do
 {
     Show-Menu
     $selection = Read-Host "Please make a selection"
     try{
        switch ($selection)
        {
         '1' 
            {
             $Member = read-host -Prompt "Enter AD username, for example JohnS"
             try{$User = Get-ADUser -Identity $Member}
             catch{Write-Warning 'Enter a valid username'
                    Start-Sleep -Milliseconds 1000
                    break}                       
               
                    $ADGroups = foreach($Group in $defaultgroups.defaultWHgroups){         
                    Get-ADGroup -Identity $Group
                    Write-Progress -Activity "Adding $Group to $User"
                    start-sleep -Milliseconds 200                    
                    }
                    Add-ADPrincipalGroupMembership -Identity $member -MemberOf $ADGroups                                                                      
                    Write-Host "Finished adding groups to user $Member" -ForegroundColor green -BackgroundColor black                                                 
           }
                       
         '2' 
            {
             $Member = read-host -Prompt "Enter AD username, for example JohnS"
             try{$User = Get-ADUser -Identity $Member}
             catch{Write-Warning 'Enter a valid username'
                    Start-Sleep -Milliseconds 1000
                    break}     
               
                    $ADGroups = foreach($Group in $defaultgroups.defaultPPFPOgroups){

                    Get-ADGroup -Identity $Group
                    Write-Progress -Activity "Adding $Group to $User"
                    start-sleep -Milliseconds 200                    
                    }
                    Add-ADPrincipalGroupMembership -Identity $member -MemberOf $ADGroups                                                                      
                    Write-Host "Finished adding groups to user $Member" -ForegroundColor green -BackgroundColor black
                    Start-Sleep -Milliseconds 1000                                        

                               
         } 
         '3' {
             'Option #3'
         }
     }
     }
     catch{Write-Warning 'Enter a valid username.'}
 }
 until ($selection -eq 'q')
 Write-Host "You have chosen to quit."-ForegroundColor green -BackgroundColor black

[PatrickFarrell]

At first glance looks ok without me trying to run the code.

Any chance you have the column header spelled wrong on 2?

If you do the following, do you get a group list as expected?

$defaultgroups = Import-Csv .\ADGroupsCSV.csv
$defaultgroups.defaultPPFPOgroups

[spiceuser-5aro4]

I double checked the spelling and it all looks correct. I do get the expected output when I run the code below. I’ve been staring at it for hours trying to figure this out but I’m stuck!

$defaultgroups = Import-Csv .\ADGroupsCSV.csv
$defaultgroups.defaultPPFPOgroups

[deanmoncaster (deanmanchester)]

When i am doing this type of thing i make sure that my switch statement is working. so what i would suggest is do the following.

 $defaultgroups = Import-Csv .\ADGroupsCSV.csv
 
 function Show-Menu
{
    param (
        [string]$Title = 'Add AD Groups to user'
    )
    Clear-Host
    Write-Host "================ $Title ================"
    
    Write-Host "1: Press '1' to add default WH Groups."
    Write-Host "2: Press '2' to add default OT Groups."
    Write-Host "3: Press '3' to add Forest specific groups."
    Write-Host "Q: Type 'Q' to quit."
}

do
 {
     Show-Menu
     $selection = Read-Host "Please make a selection"
     try{
        switch ($selection)
        {
         '1' 
            {
             'Option #1' 
         '2' 
            {
            'Option #2'
                               
         } 
         '3' {
             'Option #3'
         }
     }
     }
     catch{Write-Warning 'Enter a valid username.'}
 }
 until ($selection -eq 'q')
 Write-Host "You have chosen to quit."-ForegroundColor green -BackgroundColor black

Then test all three options and if they work you know it isn’t your switch statement.

Then slowly start to add in your code for option 2 until it works how you want it then you know you have it right. Best way i have found to debug something.

Alternatively, if you know option 1 is working then swap the code from 2 into 1 and run it, it is working? No? Then your script is wrong and it will never work.

[spiceuser-5aro4]

It appears that the fundamental switch statement works fine. The second switch statement is identical to the first except it is selecting the second column in the csv. For some reason the second switch statement does not complete before returning to the menu function. Thanks for all the help so far. Any more ideas?

[tulioarends]

First, isolate the step that is failing. I pasted the script into VS Code an ran it after commenting out relevant sections. Your issue probably lies in this section:

$ADGroups = foreach ($Group in $defaultgroups.defaultPPFPOgroups) {
                    Get-ADGroup -Identity $Group
                    Write-Progress -Activity "Adding $Group to $User"
                    start-sleep -Milliseconds 200                    
                }
                Add-ADPrincipalGroupMembership -Identity $member -MemberOf $ADGroups

Possibly an uncaught exception due to a misspelled group name in the CSV. Use a Try-Catch block here too.

As an aside, I will point out some issues (personal opinions coming, your mileage may vary):

Your message “Adding $Group to $User” is misleading, it doesn’t happen until after that loop finishes.

Don’t slow things down with sleep when it’s not necessary.

The Get-ADGroup loops are unnecessary, Add-ADPrincipalGroupMembership will take the SAM account names happily. If you still prefer to verify the groups exist do it once at the beginning of the function. No need to repeat that step (and the code) in every branch of the switch. The last also applies to getting the user name, move that to a helper function (like Show-Menu).

I recommend you do this “THE POWERSHELL WAY!” (tongue very much in cheek ;). Don’t create a text menu. Instead you should look into Advanced Functions . They basically allow you to create commandlets in PowerShell, without having to program in a .Net language. You can even set it up to accept input from the pipeline, allowing you to do something like this:

jdoe, tcat, jmouse | Add-CompanyGroups -DefaultWHGroups -DefaultOTGroups -SpecifcGroups remote, sales, hq