1

Those of you who would like their code reviewed by other programmers in the Community post it here and depending on how many of us here know (and how well) the language you written your piece of code in you’ll get some suggestions on improving, optimising and/or making more elegant.

Please keep this thread free from questions on how to write a script or fix a bug in your script. Create new threads for these as usual please.

Hopefully we’ll get a new tag in the Community with syntax highlighting etc, so the reading/working experience with code should get much better soon.

15 Spice ups
2

Ah, what the heck. I’ve got one that you guys can play with. This is a simple pinging loop batch file that I use to log connectivity issues. Any more elegant solutions?

@echo off
set MACHINE=
set PREV_MACHINE=
:NEXTPC
set PREV_MACHINE=%MACHINE%
if “%PREV_MACHINE%”==“” set MACHINE=10.7.44.91
if “%PREV_MACHINE%”==“10.7.44.91” set MACHINE=10.7.44.61
if “%PREV_MACHINE%”==“10.7.44.61” set MACHINE=10.7.44.62
if “%PREV_MACHINE%”==“10.7.44.62” set MACHINE=10.7.44.63
if “%PREV_MACHINE%”==“10.7.44.63” set MACHINE=10.7.46.64
if “%PREV_MACHINE%”==“10.7.46.64” set MACHINE=10.7.46.65
if “%PREV_MACHINE%”==“10.7.46.65” set MACHINE=10.7.44.91

:ping
PING %MACHINE% | FIND “TTL=” > NUL
IF ERRORLEVEL 1 goto ERRORREPORT
goto NEXTPC

:ERRORREPORT
@echo off
For /f "tokens=2-4 delims=/ " %%a in (‘date /t’) do (set mydate=%%c-%%a-%%b)
For /f “tokens=1-2 delims=/:” %%a in (‘time /t’) do (set mytime=%%a%%b)
echo -------- >> pinglog.log
echo ERROR HAS BEEN DETECTED >> pinglog.log
echo %mydate%_%mytime% >> pinglog.log
echo %MACHINE% >> pinglog.log
echo -------- >> pinglog.log
goto NEXTPC

3

And you don’t care to be notified if there’s a connectivity issue, just log it in the pinglog.log file? One thing I would do is create a text file with the IP addresses or names in it then use the FOR command to loop through the contents of the file–would make adding and removing servers to monitor a lot easier.

1 Spice up
4

Yeah, these aren’t mission critical servers - it’s a test environment. No need for an email alert or anything. They always come back online. Sometimes they drop connectivity for a little bit due to high resource usage and I’m doing some troubleshooting with it right now to try and pinpoint date/time along with some other statistics that I gather.

The FOR loop might be worth looking into. Would make it easier to edit it for later use.

5

I can’t help but Powershell it, here’s what I came up with:

Param(
[array]$Computers = (Get-Content “c:\utils\servers.txt”),
[string]$LogPath = “C:\utils\pinglog.log”
)
ForEach ($Computer in $Computers)
{ If (-not (Test-Connection $Computer -Quiet -Count 2))
{ Add-Content -Path $LogPath -Value “$(Get-Date -Format ‘MM/dd/yyyy hh:mm:ss tt’) - Failed Ping, Server: $Computer”
}
}

The cool part here is you can have multiple pingchecks with this script without changing code. So:

.\PingCheck.ps1 -Computers server1,server2 -LogPath c:\servercheck.log
.\PingCheck.ps1 -Computers testserver1,testserver2 -LogPath c:\pinglog.log

If you don’t specify -Computers it will read a text file in the c:\utils directory called servers.txt and use that. By default it will also save the log at c:\utils\pinglog.log.

3 Spice ups
6

Ohhhh very nice :slight_smile:

Thanks!

7

I like this thread. Posting so I can keep an eye on it.

8

For an MVC 4 project I needed to add a tooltip system to give users pertinent info in various spots around the site. I tried to use some jQuery plugins (qTip 1 and 2, jQuery UI etc.) but none of them worked well out of the box with my project so I decided to write it custom since it only needed to be fairly simple. The help text is databased so I ended up placing spans with an icon image where I wanted my tooltips. On hover the jQuery strips the ending number from span ID and passes that to a db query and returns it with JSON as the content of the tooltip display div.

jQuery Code:

$('.help-info').hover(
            function (e) {
                //mouse enter

                //strips id number for database row based on id set for html element
                var helpID = $(this).attr('id').substring(10);

                //variable storing the hovered html element to manipulate later
                var infoElem = $(this);

                //url to fetch database text data for tooltip
                var url = location.protocol + '//' + location.host + '/Membership/GetHelpText';

                //calculate 
                var center = $(window).width() / 2
                var offset = infoElem.offset();
                var scrolltop = $(document).scrollTop();
                var xpos = (offset.left + 6).toString() + 'px';
                var ypos = (offset.top - scrolltop + 2).toString() + 'px';

                //creates container div with 2 inner divs
                var tipdiv = $('<div />').addClass('custip').css({ 'position': 'fixed', 'left': xpos, 'top': ypos, 'z-index': '100000' });
                var arrowdiv = $('<div />').addClass('arrow').css({ 'color': 'gray', 'font-size': '22px' }).html('▲');
                if (e.pageX > center) {
                    var textdiv = $('<div />').addClass('text').css({ 'margin-left': '-180px', 'color': 'white', 'background-color': 'gray', 'padding': '5px', 'margin-top': '-4px', 'width': '200px', '-moz-border-radius': '5px', '-webkit-border-radius': '5px', '-khtml-border-radius': '5px', 'border-radius': '5px', 'border': '1px solid black', 'box-shadow': '3px 3px 5px rgba(0,0,0,0.5)', '-webkit-box-shadow': '3px 3px 5px rgba(0,0,0,0.5)', '-moz-box-shadow': '3px 3px 5px rgba(0,0,0,0.5)' });
                }
                else {
                    var textdiv = $('<div />').addClass('text').css({ 'margin-left': '-20px', 'color': 'white', 'background-color': 'gray', 'padding': '5px', 'margin-top': '-4px', 'width': '200px', '-moz-border-radius': '5px', '-webkit-border-radius': '5px', '-khtml-border-radius': '5px', 'border-radius': '5px', 'border': '1px solid black', 'box-shadow': '3px 3px 5px rgba(0,0,0,0.5)', '-webkit-box-shadow': '3px 3px 5px rgba(0,0,0,0.5)', '-moz-box-shadow': '3px 3px 5px rgba(0,0,0,0.5)' });
                }

                tipdiv.append(arrowdiv);
                tipdiv.append(textdiv);

                //fetches text data from database
                $.getJSON(url, { HelpID: helpID }, function (result) {
                    //sets content of inner text div of tooltip to what is brought back from database
                    textdiv.html(result);
                    //appends tooltip container div to the hovered object
                    tipdiv.hide();
                    infoElem.append(tipdiv.fadeIn(500));
                });
            },
            function () {
                //mouse leave

                //destroy created tooltip divs
                $('.custip').fadeOut(500, function () { $(this).remove(); });
                $('.arrow').fadeOut(500, function () { $(this).remove(); });
                $('.text').fadeOut(500, function () { $(this).remove(); });
            }
        );

Html Span Code Example:

<span class="help-info" id="HelpID-01-5" style="position:relative;"><img src="../../Content/Images/icons/about-32.png" /></span>

Query DB For Help Text:

public virtual ActionResult GetHelpText(string HelpID)
        {
            TeamPortalService TPsvc = new TeamPortalService();

            int HelpIDint;
            if (Int32.TryParse(HelpID, out HelpIDint))
            {
                string HelpText = TPsvc.GetHelpTxt(HelpIDint);
                return Json(HelpText, JsonRequestBehavior.AllowGet);
            }
            else
            {
                return Json("Error getting help text", JsonRequestBehavior.AllowGet);
            }
        }

public string GetHelpTxt(int HelpID)
        {
            using (var db = TeamPortalDataContext.Instance)
            {
                return (from x in db.Help_Infos
                        where x.HelpID == HelpID
                        select x.HelpText).FirstOrDefault();
            }
        }

You could get the content in other ways from other sources easily.

I was lazy and put all the css right in the jQuery rather than it’s own file.

The main glaring limitation I feel this code has is the fixed width for the help text display div. Probably other issues I haven’t noticed yet.