1

Deleted

3 Spice ups
2

Sorry - but that script is way beyond a reasonable ask.

I suggest you post a much shorter sample (thsat’s not working). Of course, I do debugging like this for my clients every day! :slight_smile:

Also - you are doing some very convoluted things, for example:

$install = (([WMICLASS]“\$strComputer\ROOT\CIMV2:win32_process”).Create(“cmd /c md c:$msuFolder”))
start-sleep -seconds 1

WHy not just:

Invoke-Command -computer XXX -ScriptBlock {Md c:$msuolder} -credentials $Cred

2 Spice ups
3

What line did it throw the error?

4

In your error you did not post the entire error, looks like you just posted the “Invalid Parameter” section and not the information about what line is failing.

We need more information please.

Also, please remember when posting code to use the code button and select “Powershell” in this case (It makes it much easier to read)

Screen_Shot_2013-11-05_at_9.46.34_AM.png
Screen_Shot_2013-11-05_at_9.46.34_AM.png836×378 24.5 KB
1 Spice up
5

Sorry TFL,

My apologies, the whole script works. It’s just it only successful on 1 of 10 computers. I was receiving the error above, so I was just wondering if you guys have seen it before?

THanks a million, and I know its way more than just a ask. :slight_smile: If one feels up to it.

6

Is this something you built or downloaded from the internet?

I see a few things wrong with this script.

Your functions are built totally wrong, your’s go:

Function FunctionName {
	Param ([string]$Param1, $Param2, $Param3)
}

And they are missing a body (What the script actually does when you run the function)

It should be in the following format:

Function FunctionName
(
	[string]$Param1,
	[string]$Param2,
	[string]$Param3
)
{
	#Script Body Here
	#Call some Parameters from Param field
	#Do other cool things.
}
1 Spice up
7

Chamele0n,

Thanks for the feedback. No, I attempted to develop this script on my own. I am definitely a newbie at powershell, so sorry if the function and string statements are incorrect. I kind of self-taught myself. Do you think this would be causing that error?

Thanks again for the help.

-Chris

8

I’m scrolling back up but looks like you deleted a post. There was a post with some error messages, a lot of the messages stated “Function missing Body”…With that said, yes I would thing these functions would be causing some errors when running the scripts.

Even if it is not causing the problem and it does run successfully. It would be good for you to fix them, just so that you learn the right way to do it.

1 Spice up
9

Chamele0n,

Here are the messages I received.

Missing expression after unary operator '+'.
At line:3 char:5

Missing expression after unary operator '+'.
At line:4 char:5

Missing function body in function declaration.
At line:146 char:6

Missing function body in function declaration.
At line:154 char:2

Missing function body in function declaration.
At line:160 char:2

Missing function body in function declaration.
At line:214 char:2

You must provide a value expression on the right-hand side of the '=' operator.
At line:30 char:14

Missing closing ')' after expression in 'while' statement.
At line:398 char:6

Missing closing ')' after expression in 'while' statement.
At line:410 char:2

Missing closing ')' in expression.
At line:415 char:3

Unexpected token 'Write-Host' in expression or statement.
At line:415 char:3

Unexpected token 'Waiting for $jobcount Jobs to Complete sleeping 5 seconds' in expression or statement.
At line:415 char:14
10 
function InstallMSU {
    (
    [String]$strComputer,   
    [String]$objFile,
    [String]$sysArch, 
    [String]$antiarch
    )
    {

So something like this?

11

No, it should look like this:

Function InstallMSU
(
	[string]$strComputer,
	[string]$objFile,
	[string]$sysArch,
	[string]$antiarch,
)
{
	#Script Body Here
	#Call some Parameters from Param field
	#Do other cool things.
}
1 Spice up
12

If you’re looking to have named parameters in a Function, the proper syntax is:

Function InstallMSU
{  Param (
      [string]$strComputer,
      [string]$objFile,
      [string]$sysArch,
      [string]$antiarch
   )
   #Script Body Here
   #Call some Parameters from Param field
   #Do other cool things.
}
2 Spice ups
13

Okay guys, sorry for the late reply. I got the .msu part rolling well. Now I am stuck at the .msi part. As the .msu section I have multiple .msi in a folder. I want to run them quiet with no user interaction of course, but I cant figure out the correct WMICLASS cmd to get it rolling. The section of the code is below. Any help would be much appreciated. Thanks

function InstallMSI 
{  param(
       [String]$strComputer, 
       [String]$objFile, 
       [String] $sysArch, 
       [String]$antiarch
         )

    write-host ""
    write-host "Security Installer"
    write-host ""
    
    $MSIName = [string]$objFile.name
    $MSIExt = $objFile.extension
    $MSIFullName = $objFile.FullName
    $MSIProc = ($MSIName.trimend(".msi"))
    write-host $MSIProc
    
    $MSIProc = [string]$MSIProc
    
        if (($MSIName -Notmatch $sysArch) -and ($MSIName -match $antiarch))
        {
        return
        }
        
        if ($MSIName -match "ia64")
        {
        return
        }

    copy-item $MSIFullName \\$strComputer\c$\$MSIName -force
          
    $install = (([WMICLASS]"\\$strComputer\ROOT\CIMV2:win32_process").Create("cmd /c msiexec.exe /I c:\$MSIName /qn /passive")) 
    
    start-sleep -Seconds 5
                        
    $MSItest = get-process -cn $strComputer -name "$MSIProc"
                        
        while ($MSItest -ne $null)
        {
        start-sleep -seconds 1
        write-host "waiting for MSI install to complete"
        $MSItest = get-process -cn $strComputer -name "$MSIProc" 
 
        }

    }