1

Hi All,

I have pieced together below script which enables PSRemoting for selected computers.

Does anyone know how can improve on this, any suggestions ?

I.e

Is the use of

Function

any good in my case ? if not, how can get rid of it ?

Also, I want the script to export failures telling me which computers it could not enable PSRemoting on via a csv file.

$ComputersArray = Get-Content computers.txt

Function enableWinRM {

foreach ($Computer in $ComputersArray)
{

  $result = winrm id -r:$Computer 2>$null

  Write-Host  
    Write-Host "Enabling WinRM on" $Computer "..." -ForegroundColor cyan
    C:\PSTools\PsExec.exe \\$Computer -s powershell enable-PSRemoting -Force
    if ($LastExitCode -eq 0) {
      C:\PSTools\PsService.exe \\$Computer restart WinRM
      $result = winrm id -r:$Computer 2>$null
      
      if ($LastExitCode -eq 0) {Write-Host 'WinRM successfully enabled!' -ForegroundColor green}
      else {Write-Host 'WinRM failed to be enabled!' -ForegroundColor red}
    } 
    
  }
}

enableWinRM
exit 0

Many thanks

Regards

Kash

@alexw @jitensh

5 Spice ups
2

Maybe have a look into this:

https://community.spiceworks.com/scripts/show/2703-remotely-enable-winrm-powershell

3 Spice ups
3

What you tried?

The idea of the script you cited was to create a function to do the hard work, then you just use that function where you need it.

4

I see what you did there…

As for an “improvement” to the script you could check if the windows firewall is enabled, if so add the appropriate firewall rules to allow WinRM to work.

Also, instead of a script, you could just do this via GPO instead.

1 Spice up
5

check this out

begin { 
  
    function Test-PsRemoting { 
        param ( 
            [Parameter(Mandatory = $true)] 
            $computername 
        ) 
         
        try { 
            $errorActionPreference = "Stop" 
            $result = Invoke-Command -ComputerName $computername { 1 } 
        } catch { 
            Write-Verbose $_ 
            return $false 
        } 
         
        ## I’ve never seen this happen, but if you want to be 
        ## thorough…. 
        if ($result -ne 1) { 
            Write-Verbose "Remoting to $computerName returned an unexpected result." 
            return $false 
        } 
        $true 
    } 
     
    if (!(Test-Connection $Computername -Quiet -Count 1)) { 
        throw 'Computer is not reachable' 
    } elseif (!(Test-Path $PsExecPath)) { 
        throw 'Psexec.exe not found'     
    } 
} 
 
process { 
    if (Test-PsRemoting $Computername) { 
        Write-Warning "Remoting already enabled on $Computername" 
    } else { 
        Write-Verbose "Attempting to enable remoting on $Computername..." 
        & $PsExecPath "\\$Computername" -s c:\windows\system32\winrm.cmd quickconfig -quiet 2>&1> $null 
        if (!(Test-PsRemoting $Computername)) { 
            Write-Warning "Remoting was attempted but not enabled on $Computername" 
        } else { 
            Write-Verbose "Remoting successfully enabled on $Computername" 
        } 
    } 
}

src : https://gallery.technet.microsoft.com/scriptcenter/Enable-PsRemotingRemotely-2bb7b245

1 Spice up
6

Happy new year everyone;

Neally, tfl, chamele0n, JitenSh - Thanks all.

I don’t know much about Powershell so a ‘function’ is lost with me, me think!

Script which I pieced together, I have given it a list of computers to do a specific task. Which it does.

However, I want to export error as which PC’s` could not be reached also I want to get rid of the ‘function’.

How can I do this people ? plz

Ta

Regards

Kash

@chamele0n @thomaslee @alexw @jitensh

7

If I was you I wll simply open command prompt and

psexec @c:\computers.txt -s winrm.cmd quickconfig -q

Psremoting is something you do quickly there is no scene here doing it better way, best way the ultimate goal is to have it enable.

This script is best i found BDW

https://gallery.technet.microsoft.com/scriptcenter/Enable-PsRemotingRemotely-2bb7b245

2 Spice ups
8

Judging by your reply, you have two primary options: learn PowerShell or find a consultant to do it.

A function is just a cmdlet, but written in PowerShell’s language (cmdlets are usually written in C#, and compiled into a DLL). Functions typically do just one thing and take parameters to change the function’s behaviour. You could create a function that takes the parameter of the machine name to configure, then configures WinRM for that computer. Functions are, in effect, tools you can apply to many somewhat different situations.

I have given you already some clues as to where to learn more about PowerShell. The video series from Plataan TV (if I say so myself) are a great introduction to PowerShell. It doesn’t cover functions in depth (It was one of the modules we just did not have time to record), but it does cover modules. Why don’t you work through that series, then come back to this task?

If time is of the essence, hiring a consultant to do the work for you is another option. It has the benefit of getting a working solution quickly.

9

tfl - you have mistaken my reply.

I am trying to automate my daily tasks using powershell, vba, cmd ( batch files ) etc etc - I learn bit by bit as i go thanks to you guys and google.

else {Write-Host 'WinRM failed to be enabled!' -ForegroundColor red}

How can i export above into a csv file ? so it also shows which computer failed ?

Ta

10

I changed write-host into write-output, script is not generating me an export of pc’s it could not connect. Does anyone know why ?

why below is not working ?

else {Write-output "WinRM failed to be enabled on $computer" | Out-File PsRemoting_errors.txt -append}

following is the full script;

$ComputersArray = Get-Content computers.txt

foreach ($Computer in $ComputersArray)
{
	
		Write-Host "Enabling WinRM on" $Computer "..." -ForegroundColor cyan
		C:\PSTools\PsExec.exe \\$Computer -s powershell enable-PSRemoting -Force
		if ($LastExitCode -eq 0) {
			C:\PSTools\PsService.exe \\$Computer restart WinRM
			$result = winrm id -r:$Computer 2>$null
			
			if ($LastExitCode -eq 0) {Write-Host 'WinRM successfully enabled!' -ForegroundColor green}

			else {Write-output "WinRM failed to be enabled on $computer" | Out-File PsRemoting_errors.txt -append}
		} 
		
	}
11

Do something like this, very roughly

ForEach ($COMPUTER in (Get-Content c:\computers.txt
))
{if(!(Test-Connection -Cn $computer -BufferSize 16 -Count 1 -ea 0 -quiet))
 
{write-host "cannot reach $computer" -f red}
 
 
 
else {
 

	
		Write-Host "Enabling WinRM on" $Computer "..." -ForegroundColor cyan
		C:\PSTools\PsExec.exe \\$Computer -s powershell enable-PSRemoting -Force
		if ($LastExitCode -eq 0) {
			C:\PSTools\PsService.exe \\$Computer restart WinRM
			$result = winrm id -r:$Computer 2>$null
			
			if ($LastExitCode -eq 0) {Write-Host 'WinRM successfully enabled! on $computer' -ForegroundColor green}

			else{ $result | Add-Content c:\failed.txt "`n$computer"

 -append}
		} 
		
	}

}
}
1 Spice up
12

Thanks JitenSh. I made some changes to your script and now i am getting the desired export.

ForEach ($computer in (Get-Content computers.txt
))
{if(!(Test-Connection -Cn $computer -BufferSize 16 -Count 1 -ea 0 -quiet))
 
{Write-output "Can't Reach $computer" | Out-File 'PSRemoting_Can_not_Reach.txt' -append}
 
 
else {
 

	
		Write-Host "Enabling WinRM on" $computer "..." -ForegroundColor cyan
		C:\PSTools\PsExec.exe \\$computer -s powershell enable-PSRemoting -Force
		if ($LastExitCode -eq 0) {
			C:\PSTools\PsService.exe \\$computer restart WinRM
			
            $result = winrm id -r:$computer 2>$null			
			if ($LastExitCode -eq 0) {Write-Host 'WinRM successfully enabled!' -ForegroundColor green}
			else {Write-output "WinRM failed to be enabled on $computer" | Out-File 'PsRemoting_Fails.txt' -append}
}
}
}

@thomaslee @alexw @jitensh

4 Spice ups
13

awesome I wrote that very roughly from mobile , you are great learner :stuck_out_tongue:

1 Spice up
14

Thanks bro - I learn from the best.

1 Spice up