Skip to content

General updates applying BEM and USWDS structures #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 20, 2024
Merged

General updates applying BEM and USWDS structures #19

merged 6 commits into from
Aug 20, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Apr 26, 2024 •
edited
Loading

Related issue

Closes #18

Summary

Add new core templates and paragraph template to codebase.
Update the template class naming conventions to use BEM.

Breaking change

Indicate if this update includes a breaking change by selecting an option below:

  • This IS NOT a breaking change.
  • ⚠️ This IS a breaking change.

Testing and review

Setup

  1. Run lando drush cr

QA/Test

  1. Review the templates and markup to confirm BEM class naming

Checklist for the Developer

  • A link to the issue has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Reviewers

  • The file changes are relevant to the task objective and resolve the issue.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed.
  • Applicable logs are free of errors.

@rayestrada rayestrada requested a review from dfedorowycz7 April 26, 2024 23:45
mejiaj
mejiaj reviewed Jul 8, 2024
View reviewed changes
Copy link

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this.

Strictly reviewed code. No major issues, just questions & comments for clarity.

dfedorowycz7
dfedorowycz7 reviewed Aug 9, 2024
View reviewed changes
@rayestrada rayestrada merged commit 62945bc into dev Aug 20, 2024
@rayestrada rayestrada deleted the feature/template-additions branch August 20, 2024 14:57
@rayestrada rayestrada mentioned this pull request Dec 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejiaj mejiaj mejiaj left review comments

@dfedorowycz7 dfedorowycz7 dfedorowycz7 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more default templates and update them to use BEM class naming conventions
3 participants
@rayestrada @mejiaj @dfedorowycz7