Utilize $theme-font-weight-bold variable for customizing bold font-weight #3811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sawyerh
changed the title
mejiaj
approved these changes
Nov 5, 2020
|
@mejiaj Just confirming, no further action needed on my end for this? Couldn't tell why the |
|
@sawyerh no, you shouldn't have to do anything on your part. Just needs final review and pulled into a branch from @uswds/core to get the build working. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This addresses an issue where sites could not theme the weight value for "bold" using
$theme-font-weight-bold."bold"maps to700. This is an issue if a site is using a custom font that is not part of the USWDS and has a non-standard weight value (like550).Additional information
This was discovered why working a site that pretty heavily themes USWDS since it's a state govt website with their own unique branding. They utilize a variable font and "bold" is closer to
550.In my Sass, I've set
$theme-global-content-styles: trueand$theme-font-weight-bold: 550however all of the headings still outputfont-weight: bold. I would expect them to outputfont-weight: 550instead. This change should enable that.npm testand make sure the tests for the files you have changed have passed.