Skip to content

USWDS - 404 page layout: Create page tempate #4003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 10, 2021

Conversation

jaredcunha
Copy link
Contributor

@jaredcunha jaredcunha commented Feb 18, 2021

Description

Creates page layout for 404 pages

For #3693

Additional information

Screenshot_2021-02-18 USWDS Fractal example document

Other notes:

  • No new components created specifically for error pages
  • Included in the HTML are comments that define a structure that might be useful other types of error pages, or perhaps if a 404 page can be made more robust depending on the application

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@jaredcunha jaredcunha force-pushed the accelerator-3693/404-template branch from 757a161 to f8236f4 Compare February 18, 2021 13:43
@jaredcunha jaredcunha changed the title Accelerator 3693/404 template USWDS - 404 page layout: Create page tempate Feb 18, 2021
@jaredcunha jaredcunha marked this pull request as ready for review February 18, 2021 13:49
@thisisdano thisisdano changed the base branch from develop to uswds-2.11.0 March 1, 2021 20:49
@thisisdano thisisdano requested review from thisisdano and mejiaj March 1, 2021 20:49
@thisisdano thisisdano mentioned this pull request Mar 1, 2021
33 tasks
@thisisdano thisisdano merged commit c0acbd7 into uswds-2.11.0 Mar 10, 2021
@thisisdano thisisdano deleted the accelerator-3693/404-template branch March 10, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants