USWDS - global: Fix normalize.css precedence #4726
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #4698
Problem:
When either the
$theme-global-content-styles
or$theme-global-paragraph-styles
settings are set to true, styles from normalize.css take precedence over some USWDS global typography styles . Because normalize.css is reset CSS, it should not take precedence over any USWDS styles.This issue is demonstrated with vertical margin issues between text elements (outlined in #4698)
Solution:
This precedence issue is happening because normalize CSS is not compiling at the top of the file:
Because normalize does not reside at the top of the compiled file, it can take precedence over any compiled USWDS styles that come before it.
Moving the
@forward
references fornormalize
aboveuswds-core
will reorder the compiled CSS, and bring normalize to the top of the file.Testing:
$theme-global-content-styles
totrue
uswds.css
margin-top: 0
andmargin-bottom: 0
<button>
should havemargin-top: 1em
Additional information
Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm test
and make sure the tests for the files you have changed have passed.