USWDS - Testing: Add more URLs to axe testing. #1092
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 23, 2020
This was referenced Nov 25, 2020
|
No longer necessary given the full-site accessibility scans we added in #1227 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to uswds/uswds/issues/3733.
Added the following URLs to testing:
Additional information
a11y issues found:
Design tokens - 1 axe violation
/design-tokens/ Found 1 aXe violations. [ { id: 'scope-attr-valid', impact: 'moderate', tags: [ 'cat.tables', 'best-practice' ], description: 'Ensures the scope attribute is used correctly on tables', help: 'scope attribute should be used correctly', helpUrl: 'https://dequeuniversity.com/rules/axe/3.5/scope-attr-valid?application=axeAPI', nodes: [ [Object], [Object], [Object], [Object], [Object], [Object], [Object], [Object], [Object], [Object], [Object], [Object], [Object], [Object], [Object], [Object], [Object], [Object], [Object], [Object], [Object] ] } ]Page templates - 1 axe violation
/page-templates/ Found 1 aXe violations. [ { id: 'heading-order', impact: 'moderate', tags: [ 'cat.semantics', 'best-practice' ], description: 'Ensures the order of headings is semantically correct', help: 'Heading levels should only increase by one', helpUrl: 'https://dequeuniversity.com/rules/axe/3.5/heading-order?application=axeAPI', nodes: [ [Object], [Object] ] } ]Utilities - 1 axe violation
/utilities/ Found 1 aXe violations. [ { id: 'scope-attr-valid', impact: 'moderate', tags: [ 'cat.tables', 'best-practice' ], description: 'Ensures the scope attribute is used correctly on tables', help: 'scope attribute should be used correctly', helpUrl: 'https://dequeuniversity.com/rules/axe/3.5/scope-attr-valid?application=axeAPI', nodes: [ [Object], [Object], [Object], [Object], [Object], [Object], [Object], [Object], [Object], [Object] ] } ]Related Issues
Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm testand make sure the tests for the files you have changed have passed.