Skip to content

USWDS-Site - Accordion: Add accordion color settings #2081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 5, 2023
Merged

USWDS-Site - Accordion: Add accordion color settings #2081

merged 12 commits into from
Jun 5, 2023

Conversation

mejiaj
Copy link
Contributor

@mejiaj mejiaj commented May 3, 2023 •
edited
Loading

Summary

Documenting new accordion color settings & updating changelog entries.

Related issue

Part of uswds/uswds#5269.

Preview link

Preview link:

Problem statement

Settings and changelog entries need to be updated for accuracy.

Solution

  1. Add entries to _data/settings/components/accordion.yml
  2. Update changelog for both settings & component

Testing and review

Accordion component

  1. Visit Accordion component
  2. Settings table should include two new background color settings
  3. There should be a new changelog entry

Settings page

  1. Visit Settings page
  2. New accordion settings should be documented
  3. Go to changelog section at the bottom of the page
  4. There should be a new changelog entry for new settings

@mejiaj mejiaj mentioned this pull request May 3, 2023
Merged
2 tasks
amyleadem
amyleadem suggested changes May 9, 2023
View reviewed changes
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, @mejiaj ! I added comments for a couple possible changes. Let me know if you have questions:

Checks performed:

mahoneycm
mahoneycm approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good on my end!

I agree with @amyleadem comments to add the setting names to the change log as well as the adjustments to the setting's descriptions for improved clarity.

No further adjustments!

  • Checked for changelog items on Accordion and Settings page
  • Checked for setting's descriptions on Accordion page
  • Checked for new accordion settings on Settings page

@mejiaj mejiaj requested a review from amyleadem May 15, 2023 20:55
amyleadem
amyleadem suggested changes May 15, 2023
View reviewed changes
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just had one question related to affectsSettings.

@amyleadem amyleadem changed the title USWDS - Accordion: Add accordion color settings USWDS-Site - Accordion: Add accordion color settings May 15, 2023
@amyleadem
Copy link
Contributor

amyleadem commented May 15, 2023 •
edited
Loading

Whoops, one more note: thinking it would be a good idea to also add a changelog for the checkbox component since the calculation for determining the check icon color has been updated with this PR as well.
Removing this comment since the PR no longer affects the radio or checkbox components.

@amyleadem amyleadem mentioned this pull request Jun 2, 2023
Merged
24 tasks
@amyleadem amyleadem added this to the uswds 3.5.0 milestone Jun 2, 2023
@mejiaj mejiaj requested a review from amyleadem June 2, 2023 20:58
amyleadem
amyleadem reviewed Jun 2, 2023
View reviewed changes
amyleadem
amyleadem reviewed Jun 2, 2023
View reviewed changes
@amyleadem amyleadem changed the base branch from main to release-3.5.0 June 2, 2023 21:49
@amyleadem amyleadem changed the base branch from release-3.5.0 to dw-changelog-button-outline-whc June 2, 2023 22:01
@thisisdano thisisdano marked this pull request as ready for review June 5, 2023 17:05
@thisisdano thisisdano merged commit ddcce60 into dw-changelog-button-outline-whc Jun 5, 2023
@mejiaj mejiaj deleted the jm-accordion-background branch July 3, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisdano thisisdano thisisdano approved these changes

@mahoneycm mahoneycm mahoneycm approved these changes

@amyleadem amyleadem amyleadem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
uswds 3.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mejiaj @amyleadem @thisisdano @mahoneycm