Kf mar 24 mc page updates #2631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding March MC content and video link
This was referenced Apr 19, 2024
mahoneycm
reviewed
Apr 19, 2024
charlie fixed spacing and I accept Co-authored-by: mahoneycm <[email protected]>
|
Ok, preview is ready for review. @sarah-sch you can take a look whenever you have time :) |
sarah-sch
suggested changes
Apr 19, 2024
_data/monthly-calls.yml
Outdated
| description: | | ||
| Our USWDS team did a great live [tutorial on customizing and extending USWDS](https://github.com/uswds/uswds-tutorial). We covered working with settings, applying tokens, handling style conflicts, and ensuring good color contrast. | ||
| date: March 2024 | ||
| id: M2SVDceCM |
Advertisement
There was a problem hiding this comment.
The embedded video isn't playing for me. I'm wondering if we need these underscores in the ID: M2_SVDc_eCM
There was a problem hiding this comment.
I think we do. I thought they were glitches in a version of the link I saw. I'll add 'em back. I didn't have a chance to preview any of this before I sent to you for review. Busy day!
Fixed video link
mahoneycm
approved these changes
Apr 22, 2024
thisisdano
reviewed
Apr 26, 2024
thisisdano
reviewed
Apr 26, 2024
|
Hey @thisisdano, I got psyched to see this approved and am noticing some checks failed here too. Should I be bothering you to check or should I be asking Charlie? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the March event, along with a description and related links, to the USWDS monthly call page.
Summary
This purpose of this PR is to update the monthly call page to include a video (and supplemental information) for the March 2024 monthly call. This update will keep the page relevant and timely.
Important
This PR is based off the changes from #2576. We should wait to merge until that is merged into main.
Related issue
#2602
Preview link
Monthly calls page
Problem statement
The March 2024 event needs to be added to the USWDS monthly calls page (and accompany the Feb monthly call content also going on to the page)
Solution
This action will add the March 2024 event to the monthly call page so that the USWDS community can enjoy it!
Testing and review
Please proof the new content and make sure it's formatted correctly.