Skip to content

Add November summary to Monthly calls page #3015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 13, 2024
Merged

Conversation

finekatie
Copy link
Contributor

@finekatie finekatie commented Dec 12, 2024

Summary

Adding November Monthly Call content to Monthly Calls page

Important

The changelog date will need to be updated before merge.

Related issue

Closes #6215

Preview link

Monthly calls page

Problem statement

Needed to get Monthly calls page up to date with November call info.

Solution

November Monthly call summary was approved and is ready to be added to the page. Video will not be going up until later in the month. Will need a new ticket or branch off this when it's ready.

Testing and review

Need someone to look and make sure links work and content is clean and clear.

@finekatie finekatie added the Affects: Content Relates to content label Dec 12, 2024
Info was missing on the preview page. Added missing date field. Hoping that clears this up.
@finekatie
Copy link
Contributor Author

finekatie commented Dec 12, 2024

Hi @annepetersen , Dan said you can approve and merge if all looks good. I dated the changelog for tomorrow if that works. Thank you!

If the date needs to be changed again, please do so.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

believe you'll need to use Markup, not HTML, for the link to the design kit. Also there's a random "date: October 2024" that seems be hanging out at the end of the paragraph

Copy link
Contributor Author

@finekatie finekatie Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Thank you for the link info - will look and see about that and the October date issue. All set @annepetersen , I think this is good to go for tomorrow.

Copy link
Contributor

@annepetersen annepetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the number of slides for November is 108, not 109?

@finekatie
Copy link
Contributor Author

finekatie commented Dec 13, 2024

I think the number of slides for November is 108, not 109?

DG has 109 on their event page. That's where I normally pull from. I see the slide deck is 108. I will change to 108 and alert DG.

Had 109 as number of slides in presentation. It is 108. Updated.
Copy link
Contributor

@annepetersen annepetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@annepetersen annepetersen merged commit b1c4177 into main Dec 13, 2024
11 checks passed
@annepetersen annepetersen deleted the kf-novMC-MCspage branch December 13, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Content Relates to content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants