Skip to content

Add December to monthly calls page and November video link #3044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 13, 2025

Conversation

finekatie
Copy link
Contributor

@finekatie finekatie commented Jan 7, 2025

Summary

Summary of december call added along with event link and ppt link. Also added November video link since it's available

Important

The changelog date will need to be updated before merge.

Related issue

Closes #3045

Preview link

Monthly calls page

Problem statement

Needed to get Monthly calls page up to date with December summary call info. Also need November video

Solution

December monthly call summary was approved and is ready to be added to the page. Q&A and Video will not be going up until later in the month. Will need a new ticket or branch off this when it's ready.
Also adding November video.

Testing and review

Need someone to look and make sure links work and content is clean and clear.

Summary of december call added along with event link and ppt link. Also added november video link since it's available
@finekatie finekatie self-assigned this Jan 7, 2025
@finekatie finekatie requested a review from a team as a code owner January 7, 2025 20:23
@finekatie finekatie changed the title Add december to monthly calls page and November video link Add December to monthly calls page and November video link Jan 7, 2025
amycole501
amycole501 previously approved these changes Jan 7, 2025
amyleadem
amyleadem previously approved these changes Jan 7, 2025
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I noticed some failures in the build that are unrelated to this change. I'll work on getting a fix up for those in a separate PR. Once that is merged, I'll pull the fix into this PR so that we can get the tests passing.

@finekatie
Copy link
Contributor Author

LGTM!

I noticed some failures in the build that are unrelated to this change. I'll work on getting a fix up for those in a separate PR. Once that is merged, I'll pull the fix into this PR so that we can get the tests passing.

Do you have a sense of how long that will take? I'd like to get this in Dan's hands well before the MC if possible.

@amyleadem
Copy link
Contributor

Should be quick.
The HTML-proofer fix is in the works and is pretty straightforward: PR #3046

@finekatie finekatie dismissed stale reviews from amyleadem and amycole501 via 69b8334 January 13, 2025 16:36
Added December video link
@finekatie
Copy link
Contributor Author

Added December video and updated changelog description. This still needs review and merge.

amyleadem
amyleadem previously approved these changes Jan 13, 2025
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming that the addition of the December video looks good.

@finekatie
Copy link
Contributor Author

Changelog date is up, @thisisdano and this is ready for merge. :)

@thisisdano thisisdano merged commit 6e7fb7f into main Jan 13, 2025
11 checks passed
@thisisdano thisisdano deleted the kf-decMC-mcspage branch January 13, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add Dec 24 MC and Nov video to monthly calls page
4 participants